drm/amd/powerplay: declare driver if version mismatch as "warning" explicitly
Subsystems (2)
PATCH 1/1 drm/amd/powerplay: declare driver if version mismatch as "warning" explicitly
So that user knows it's just a warning and can be safely ignored.
--- drivers/gpu/drm/amd/powerplay/smu_v11_0.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/amd/powerplay/smu_v11_0.c +2 -2
@@ -318,11 +318,11 @@ int smu_v11_0_check_fw_version(struct smu_context *smu)* of halt driver loading. */ if (if_version != smu->smc_driver_if_version) { -dev_info (smu->adev->dev,"smu driver if version = 0x%08x, smu fw if version = 0x%08x, " +dev_warn (smu->adev->dev,"warning: smu driver if version = 0x%08x, smu fw if version = 0x%08x, " "smu fw version = 0x%08x (%d.%d.%d)\n" , smu->smc_driver_if_version, if_version, smu_version, smu_major, smu_minor, smu_debug); -dev_warn (smu->adev->dev,"SMU driver if version not matched\n" ); +dev_warn (smu->adev->dev,"warning: SMU driver if version not matched\n" ); }return ret;
Signature · 6 lines
2.27.0 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Quoted 2 lines · Evan Quan
So that user knows it's just a warning and can be safely ignored.
I'm not sure I follow this logic. I think a warning would cause more concern than just printing it as info. Why would you ignore a warning?
Alex
Quoted 28 lines
Change-Id Ic518ec3eb68c6bd6682e6131e32cfe90843341ffSigned-off-by Evan Quan <[email protected]>--- drivers/gpu/drm/amd/powerplay/smu_v11_0.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/gpu/drm/amd/powerplay/smu_v11_0.c +2
-3@@ -318,11 +318,11 @@ int smu_v11_0_check_fw_version(struct smu_context *smu)* of halt driver loading. */ if (if_version != smu->smc_driver_if_version) { -dev_info (smu->adev->dev,"smu driver if version = 0x%08x, smu fw if version = 0x%08x, " +dev_warn (smu->adev->dev,"warning: smu driver if version = 0x%08x, smu fw if version = 0x%08x, " "smu fw version = 0x%08x (%d.%d.%d)\n" , smu->smc_driver_if_version, if_version, smu_version, smu_major, smu_minor, smu_debug); -dev_warn (smu->adev->dev,"SMU driver if version not matched\n" ); +dev_warn (smu->adev->dev,"warning: SMU driver if version not matched\n" ); }return ret; --2.27.0
Quoted 4 lines
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
[AMD Official Use Only - Internal Distribution Only]
Hi Alex,
This was raised by Pramendra. He got plenty of questions from customer about this.
The customer saw these mismatch messages and did not know whether it's an indication of some critical error. The mismatch messages were update to be prefixed with "warning". So that it get customer reminded but not scared. Any better idea?
BR,
Evan
-----Original Message-----
From: Alex Deucher <[email protected]>
Sent: Thursday, June 18, 2020 5:15 AM
To: Quan, Evan <[email protected]>
Cc: amd-gfx list <[email protected]>; Deucher, Alexander <[email protected]>; Kumar, Pramendra <[email protected]>
Subject: Re: [PATCH] drm/amd/powerplay: declare driver if version mismatch as "warning" explicitly
Quoted 2 lines · Evan Quan
So that user knows it's just a warning and can be safely ignored.
I'm not sure I follow this logic. I think a warning would cause more concern than just printing it as info. Why would you ignore a warning?
Alex
Quoted 30 lines
Change-Id Ic518ec3eb68c6bd6682e6131e32cfe90843341ffSigned-off-by Evan Quan <[email protected]>--- drivers/gpu/drm/amd/powerplay/smu_v11_0.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/gpu/drm/amd/powerplay/smu_v11_0.c +3
-3@@ -318,11 +318,11 @@ int smu_v11_0_check_fw_version(struct smu_context *smu)* of halt driver loading. */ if (if_version != smu->smc_driver_if_version) { -dev_info (smu->adev->dev,"smu driver if version = 0x%08x, smu fw if version = 0x%08x, " + dev_warn(smu->adev->dev, "warning: smu driver if version = 0x%08x, smu fw if version = 0x%08x, " "smu fw version = 0x%08x (%d.%d.%d)\n", smu->smc_driver_if_version, if_version, smu_version, smu_major, smu_minor, smu_debug); -dev_warn (smu->adev->dev,"SMU driver if version not matched\n" ); + dev_warn(smu->adev->dev, "warning: SMU driver if + version not matched\n"); } return ret; --2.27.0
Quoted 8 lines
_______________________________________________
amd-gfx mailing list
[email protected]
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flist
s.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=02%7C01%7Cev an.quan%40amd.com%7Cefaab1a492c9408cacf208d8130393ca%7C3dd8961fe4884e6 08e11a82d994e183d%7C0%7C0%7C637280253365573223&sdata=REs2QnFT0V1gX yti8Ws4wn4hhcpMDvpd4mf8WEVUEk4%3D&reserved=0
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Quoted 9 lines · Evan
[AMD Official Use Only - Internal Distribution Only]
Hi Alex,
This was raised by Pramendra. He got plenty of questions from customer about this.
The customer saw these mismatch messages and did not know whether it's an indication of some critical error. The mismatch messages were update to be prefixed with "warning". So that it get customer reminded but not scared. Any better idea?
If the idea is not to raise concerns, then why change from dev_info to dev_warn? I warning is generally seen as more critical than info. I'd suggest making them both dev_info and instead of saying "warning:
SMU driver if version not matched", maybe say something like "SMU driver if version not matched, consider updating your firmware".
Alex
Quoted 48 lines
BR,
Evan
-----Original Message-----
From: Alex Deucher <[email protected]>
Sent: Thursday, June 18, 2020 5:15 AM
To: Quan, Evan <[email protected]>
Cc: amd-gfx list <[email protected]>; Deucher, Alexander <[email protected]>; Kumar, Pramendra <[email protected]>
Subject: Re: [PATCH] drm/amd/powerplay: declare driver if version mismatch as "warning" explicitlyQuoted 2 lines · Evan Quan
So that user knows it's just a warning and can be safely ignored.
I'm not sure I follow this logic. I think a warning would cause more concern than just printing it as info. Why would you ignore a warning?
Alex
Quoted 30 lines
Change-Id Ic518ec3eb68c6bd6682e6131e32cfe90843341ffSigned-off-by Evan Quan <[email protected]>--- drivers/gpu/drm/amd/powerplay/smu_v11_0.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/gpu/drm/amd/powerplay/smu_v11_0.c +3
-3@@ -318,11 +318,11 @@ int smu_v11_0_check_fw_version(struct smu_context *smu)* of halt driver loading. */ if (if_version != smu->smc_driver_if_version) { -dev_info (smu->adev->dev,"smu driver if version = 0x%08x, smu fw if version = 0x%08x, " + dev_warn(smu->adev->dev, "warning: smu driver if version = 0x%08x, smu fw if version = 0x%08x, " "smu fw version = 0x%08x (%d.%d.%d)\n", smu->smc_driver_if_version, if_version, smu_version, smu_major, smu_minor, smu_debug); -dev_warn (smu->adev->dev,"SMU driver if version not matched\n" ); + dev_warn(smu->adev->dev, "warning: SMU driver if + version not matched\n"); } return ret; --2.27.0
Quoted 8 lines
Quoted 8 lines
_______________________________________________
amd-gfx mailing list
[email protected]
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flist
s.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=02%7C01%7Cev an.quan%40amd.com%7Cefaab1a492c9408cacf208d8130393ca%7C3dd8961fe4884e6 08e11a82d994e183d%7C0%7C0%7C637280253365573223&sdata=REs2QnFT0V1gX yti8Ws4wn4hhcpMDvpd4mf8WEVUEk4%3D&reserved=0
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx