cmd: drop fitupd command
PATCH 1/1 cmd: drop fitupd command
The fitupd' command is not used by any board. The dfu tftp' command provides the same capabilities.
So let's drop the `fitupd' command.
--- cmd/Kconfig | 7 ------- cmd/Makefile | 1 - cmd/fitupd.c | 30 ------------------------------ doc/README.dfutftp | 2 -- doc/README.update | 5 ----- 5 files changed, 45 deletions(-) delete mode 100644 cmd/fitupd.c
cmd/Kconfig +0 -7
@@ -489,13 +489,6 @@ config CMD_SPL_WRITE_SIZE flash used by Falcon-mode boot. See the documentation until CMD_SPL for detail. -config CMD_FITUPD - bool "fitImage update command" - depends on UPDATE_TFTP - help - Implements the 'fitupd' command, which allows to automatically - store software updates present on a TFTP server in NOR Flash - config CMD_THOR_DOWNLOAD bool "thor - TIZEN 'thor' download" select DFU
cmd/Makefile +0 -1
@@ -61,7 +61,6 @@ obj-$(CONFIG_CMD_EXT4) += ext4.o obj-$(CONFIG_CMD_EXT2) += ext2.o obj-$(CONFIG_CMD_FAT) += fat.o obj-$(CONFIG_CMD_FDT) += fdt.o -obj-$(CONFIG_CMD_FITUPD) += fitupd.o obj-$(CONFIG_CMD_FLASH) += flash.o obj-$(CONFIG_CMD_FPGA) += fpga.o obj-$(CONFIG_CMD_FPGAD) += fpgad.o
cmd/fitupd.c deleted +0 -30
@@ -1,30 +0,0 @@ -// SPDX-License-Identifier: GPL-2.0+ -/* -* (C) Copyright 2011 -* Andreas Pretzsch, carpe noctem engineering, apr at cn-eng.de -*/ - -#include <common.h> -#include <command.h> -#include <net.h> - -static int do_fitupd (struct cmd_tbl *cmdtp,int flag,int argc, -char *const argv[]) -{ -ulong addr =0UL ; - -if (argc >2 ) -return CMD_RET_USAGE ; - -if (argc ==2 ) - addr =simple_strtoul (argv[1 ],NULL ,16 ); - -return update_tftp (addr,NULL ,NULL ); -} - -U_BOOT_CMD (fitupd,2 ,0 , do_fitupd, -"update from FIT image" , -"[addr]\n" -"\t- run update from FIT image at addr\n" -"\t or from tftp 'updatefile'" -);
doc/README.dfutftp +0 -2
@@ -42,8 +42,6 @@ for USB based DFU (CONFIG_DFU_*) and DFU TFTP update The "dfu" command has been extended to support transfer via TFTP - one needs to type for example "dfu tftp 0 mmc 0" -This feature does not depend on "fitupd" command enabled. - As of this writing (SHA1:8d77576371381ade83de475bb639949b44941e8c v2015.10-rc2) the update.c code is not enabled (CONFIG_UPDATE_TFTP) by any board in the contemporary u-boot tree.
doc/README.update +0 -5
@@ -51,11 +51,6 @@ the mkimage tool. dtc tool with support for binary includes, e.g. in version to be prepared. Refer to the doc/uImage.FIT/ directory for more details on FIT images. -This mechanism can be also triggered by the command "fitupd". -If an optional, non-zero address is provided as argument, the TFTP transfer -is skipped and the image at this address is used. -The fitupd command is enabled by CONFIG_CMD_FITUPD. - Example .its files ------------------
--
2.27.0
PATCH 1/1 cmd: drop fitupd command
Quoted 112 lines · On Wed, 17 Jun 2020 11:09:03 +0200 Heinrich Schuchardt <[email protected]>…
The
fitupd' command is not used by any board. Thedfu tftp' command provides the same capabilities.So let's drop the `fitupd' command.
Signed-off-by Heinrich Schuchardt <[email protected]>--- cmd/Kconfig | 7 ------- cmd/Makefile | 1 - cmd/fitupd.c | 30 ------------------------------ doc/README.dfutftp | 2 -- doc/README.update | 5 ----- 5 files changed, 45 deletions(-) delete mode 100644 cmd/fitupd.ccmd/Kconfig +0
-0@@ -489,13 +489,6 @@ config CMD_SPL_WRITE_SIZE flash used by Falcon-mode boot. See the documentationuntil
CMD_SPLfor detail.cmd/Kconfig +0
-5-config CMD_FITUPD - bool "fitImage update command" - depends on UPDATE_TFTP - help - Implements the 'fitupd' command, which allows toautomatically
cmd/Kconfig +0
-1- store software updates present on a TFTP server in NORFlash -
configCMD_THOR_DOWNLOADcmd/Kconfig +0
-0bool "thor - TIZEN 'thor' download" select DFUcmd/Makefile +0
-1@@ -61,7 +61,6 @@ obj-$(CONFIG_CMD_EXT4) += ext4.o obj-$(CONFIG_CMD_EXT2) += ext2.o obj-$(CONFIG_CMD_FAT) += fat.o obj-$(CONFIG_CMD_FDT) += fdt.o -obj-$(CONFIG_CMD_FITUPD) += fitupd.o obj-$(CONFIG_CMD_FLASH) += flash.o obj-$(CONFIG_CMD_FPGA) += fpga.o obj-$(CONFIG_CMD_FPGAD) += fpgad.ocmd/fitupd.c deleted +0
-30@@ -1,30 +0,0 @@ -// SPDX-License-Identifier: GPL-2.0+ -/* -* (C) Copyright 2011 -* Andreas Pretzsch, carpe noctem engineering, apr at cn-eng.de -*/ - -#include <common.h> -#include <command.h> -#include <net.h> - -static int do_fitupd (struct cmd_tbl *cmdtp,int flag,int argc, -char *const argv[]) -{ -ulong addr =0UL ; - -if (argc >2 ) -return CMD_RET_USAGE ; - -if (argc ==2 ) - addr =simple_strtoul (argv[1 ],NULL ,16 ); - -return update_tftp (addr,NULL ,NULL ); -} - -U_BOOT_CMD (fitupd,2 ,0 , do_fitupd, -"update from FIT image" , -"[addr]\n" -"\t- run update from FIT image at addr\n" -"\t or from tftp 'updatefile'" -);doc/README.dfutftp +0
-0@@ -42,8 +42,6 @@ for USB based DFU (CONFIG_DFU_*) and DFU TFTP update The "dfu" command has been extended to support transfer via TFTP -one needs to type for example "dfu tftp 0 mmc 0"
doc/README.dfutftp +0
-2-This feature does not depend on "fitupd" command enabled. - As of this writing (SHA1:8d77576371381ade83de475bb639949b44941e8cv2015.10-rc2) the
update.ccode is not enabled (CONFIG_UPDATE_TFTP) by any board in the contemporary u-boot tree.doc/README.update +0
-0@@ -51,11 +51,6 @@ the mkimage tool. dtc tool with support for binaryincludes, e.g. in version to be prepared. Refer to the doc/uImage.FIT/ directory for more details on FIT images.
doc/README.update +0
-2-This mechanism can be also triggered by the command "fitupd". -If an optional, non-zero address is provided as argument, the TFTPtransfer -is skipped and the image at this address is used.
doc/README.update +0
-3-The fitupd command is enabled by CONFIG_CMD_FITUPD. - Example .its files ------------------ --
Quoted 2 lines
2.27.0
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de -------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200617/5e2d21fd/attachment.sig>
PATCH 1/1 cmd: drop fitupd command
Quoted 10 lines · Lukasz Majewski
Quoted 7 lines · On Wed, 17 Jun 2020 11:09:03 +0200 Heinrich Schuchardt <[email protected]>…
The
fitupd' command is not used by any board. Thedfu tftp' command provides the same capabilities.So let's drop the `fitupd' command.
Signed-off-by Heinrich Schuchardt <[email protected]>---
<snip />
Quoted 2 lines
Reviewed-by Lukasz Majewski <[email protected]>
Will you create a pull request or should I take the patch into my tree?
Best regards
Heinrich
PATCH 1/1 cmd: drop fitupd command
Hi Heinrich,
Quoted 9 lines · Lukasz Majewski
Quoted 8 lines
Quoted 5 lines · On Wed, 17 Jun 2020 11:09:03 +0200 Heinrich Schuchardt <[email protected]>…
The
fitupd' command is not used by any board. Thedfu tftp' command provides the same capabilities.So let's drop the `fitupd' command.
Quoted 8 lines
Quoted 2 lines
Quoted 2 lines
Signed-off-by Heinrich Schuchardt <[email protected]>---
<snip />
Quoted 2 lines
Reviewed-by Lukasz Majewski <[email protected]>Will you create a pull request or should I take the patch into my tree?
I saw that you have some other patches depending on this work, so IMHO for this particular case, please pull it to your tree.
Quoted 4 lines
Best regards
Heinrich
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de -------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200716/a06c8593/attachment.sig>