Skip to contentSkip to conversation

fs : initialize return for iter_file_splice_write

PATCH New [email protected] 1 participant 1 message Jun 17, 2020 VFS

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fs : initialize return for iter_file_splice_write

From: Tom Rix <[email protected]>

clang static analysis flags this garbarge return
fs/splice.c:786:2: warning: Undefined or garbage value returned to caller [core.uninitialized.UndefReturn]

        return ret;
        ^~~~~~~~~~

ssize_t
iter_file_splice_write( ... size_t len, ..

	sd.total_len = len

	ssize_t ret;

	while (sd.total_len) {
	      ...
	      ret =
	}

If the input len is 0, the while loop will never run and ret will not be set.

So handle similar to splice_direct_to_actor and initialize ret to 0

---
 fs/splice.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/splice.c +1 -1
index d7c8a7c4db07..f65e072bcc2c 100644
@@ -691,7 +691,7 @@ iter_file_splice_write(struct pipe_inode_info *pipe, struct file *out,
 	int nbufs = pipe->max_usage;
 	struct bio_vec *array = kcalloc(nbufs, sizeof(struct bio_vec),
 					GFP_KERNEL);
-	ssize_t ret;
+	ssize_t ret = 0;
 
 	if (unlikely(!array))
 		return -ENOMEM;
Signature · 1 line
2.18.1