net: napi: remove useless stack trace
Subsystems (2)
PATCH 1/1 net: napi: remove useless stack trace
Whenever a buggy NAPI driver returns more than its budget, we emit a stack trace that is of no use, since it does not tell which driver is buggy.
Instead, emit a message giving the function name, and a descriptive message.
Signed-off-by Eric Dumazet <[email protected]>
--- net/core/dev.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
net/core/dev.c +3 -1
@@ -6683,7 +6683,9 @@ static int napi_poll(struct napi_struct *n, struct list_head *repoll)trace_napi_poll (n, work, weight); } -WARN_ON_ONCE (work > weight); +if (unlikely (work > weight)) +pr_err_once ("NAPI poll function %pS returned %d, exceeding its budget of %d.\n" , + n->poll, work, weight);if (likely (work < weight)) goto out_unlock;
Signature · 1 line
2.27.0.290.gba653c62da-goog
From: Eric Dumazet <[email protected]>
Date: Wed, 17 Jun 2020 09:40:51 -0700
Quoted 8 lines
Whenever a buggy NAPI driver returns more than its budget, we emit a stack trace that is of no use, since it does not tell which driver is buggy.
Instead, emit a message giving the function name, and a descriptive message.
Signed-off-by Eric Dumazet <[email protected]>
Applied, thanks Eric.