ARM: dts: imx6qdl-sabresd: Fix AR8031 phy-mode
Subsystems (2)
Fabio Estevam
reviewerPATCH 1/1 ARM: dts: imx6qdl-sabresd: Fix AR8031 phy-mode
As per kernel commit 0672d22a1924 ("ARM: dts: imx: Fix the AR803X phy-mode) the correct phy-mode should be "rgmii-id", so fix it accordingly to fix the Ethernet regression.
This problem has been exposed by commit:
commit 13114f38e2ccea9386726d8b9831dfc310589548
Author: Vladimir Oltean <[email protected]> Date: Thu May 7 00:11:51 2020 +0200
phy: atheros: Explicitly disable RGMII delays
To eliminate any doubts about the out-of-reset value of the PHY, that the driver previously relied on.
If bisecting shows that this commit breaks your board you probably have a wrong PHY interface mode. You probably want the PHY_INTERFACE_MODE_RGMII_RXID or PHY_INTERFACE_MODE_RGMII_ID mode.
---
Hi,
Probably syncing with the mainline kernel would help fixing other boards.
I tried this approach and noticed some dtb build breakage as there are some dtbs that are not in mainline, so to be on the safe side, apply the minimal fix for the sabresd board to fix the regression for 2020.07.
arch/arm/dts/imx6qdl-sabresd.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/dts/imx6qdl-sabresd.dtsi +1 -1
@@ -204,7 +204,7 @@ &fec { pinctrl-names = "default"; pinctrl-0 = <&pinctrl_enet>; - phy-mode = "rgmii"; + phy-mode = "rgmii-id"; phy-reset-gpios = <&gpio1 25 GPIO_ACTIVE_LOW>; status = "okay"; };
Signature · 1 line
2.17.1
PATCH 1/1 ARM: dts: imx6qdl-sabresd: Fix AR8031 phy-mode
Quoted 23 lines · Fabio Estevam
As per kernel commit
0672d22a1924("ARM: dts: imx: Fix the AR803X phy-mode) the correct phy-mode should be "rgmii-id", so fix it accordingly to fix the Ethernet regression.This problem has been exposed by commit:
commit
13114f38e2ccea9386726d8b9831dfc310589548Author: Vladimir Oltean <[email protected]> Date: Thu May 7 00:11:51 2020 +0200phy: atheros: Explicitly disable RGMII delays
To eliminate any doubts about the out-of-reset value of the PHY, that the driver previously relied on.
If bisecting shows that this commit breaks your board you probably have a wrong PHY interface mode. You probably want the
PHY_INTERFACE_MODE_RGMII_RXIDorPHY_INTERFACE_MODE_RGMII_IDmode.Signed-off-by Vladimir Oltean <[email protected]>Acked-by Joe Hershberger <[email protected]>Signed-off-by Fabio Estevam <[email protected]>
Quoted 8 lines
---
Hi,Probably syncing with the mainline kernel would help fixing other boards.
I tried this approach and noticed some dtb build breakage as there are some dtbs that are not in mainline, so to be on the safe side, apply the minimal fix for the sabresd board to fix the regression for 2020.07.
As part of tracking down the cubox problem yesterday before posting I found that some parts of your commit 0672d22a1924 in the kernel applied in U-Boot, mainly, ah, the sabre* boards. Others were already fixed or absent.
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 659 bytes Desc: not available URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200617/ffac7e94/attachment.sig>
PATCH 1/1 ARM: dts: imx6qdl-sabresd: Fix AR8031 phy-mode
In reply to Fabio EstevamQuoted 12 lines
As per kernel commit
0672d22a1924("ARM: dts: imx: Fix the AR803X phy-mode) the correct phy-mode should be "rgmii-id", so fix it accordingly to fix the Ethernet regression.
This problem has been exposed by commit:
commit13114f38e2ccea9386726d8b9831dfc310589548Author: Vladimir Oltean <[email protected]> Date: Thu May 7 00:11:51 2020 +0200phy: atheros: Explicitly disable RGMII delays
To eliminate any doubts about the out-of-reset value of the PHY, that the driver previously relied on.
Quoted 7 lines
If bisecting shows that this commit breaks your board you probably have a wrong PHY interface mode. You probably want the
PHY_INTERFACE_MODE_RGMII_RXIDorPHY_INTERFACE_MODE_RGMII_IDmode.Signed-off-by Vladimir Oltean <[email protected]>Acked-by Joe Hershberger <[email protected]>Signed-off-by Fabio Estevam <[email protected]>
Applied to u-boot-imx, master, thanks !
Best regards,
Stefano Babic
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================