drm/msm: Fix address space size after refactor.
Subsystems (4)
PATCH 1/2 drm/msm: Fix address space size after refactor.
Previously the address space went from 16M to ~0u, but with the refactor one of the 'f's was dropped, limiting us to 256MB. Additionally, the new interface takes a start and size, not start and end, so we can't just copy and paste.
Fixes regressions in dEQP-VK.memory.allocation.random.*
--- drivers/gpu/drm/msm/adreno/adreno_gpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/msm/adreno/adreno_gpu.c +1 -1
@@ -194,7 +194,7 @@ adreno_iommu_create_address_space(struct msm_gpu *gpu,struct msm_gem_address_space *aspace; aspace =msm_gem_address_space_create (mmu,"gpu" ,SZ_16M , -0xfffffff ); +0xffffffff -SZ_16M );if (IS_ERR (aspace) && !IS_ERR (mmu)) mmu->funcs->destroy (mmu);
Signature · 6 lines
2.26.2 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
PATCH 2/2 drm/msm: Fix setup of a6xx create_address_space.
We don't want it under CONFIG_DRM_MSM_GPU_STATE, we need it all the time (like the other GPUs do).
--- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/msm/adreno/a6xx_gpu.c +1 -1
@@ -893,8 +893,8 @@ static const struct adreno_gpu_funcs funcs = {#if defined(CONFIG_DRM_MSM_GPU_STATE ) .gpu_state_get = a6xx_gpu_state_get, .gpu_state_put = a6xx_gpu_state_put, - .create_address_space = adreno_iommu_create_address_space, #endif + .create_address_space = adreno_iommu_create_address_space, }, .get_timestamp = a6xx_get_timestamp, };
Signature · 6 lines
2.26.2 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 10 lines · Eric Anholt
Previously the address space went from 16M to ~0u, but with the refactor one of the 'f's was dropped, limiting us to 256MB. Additionally, the new interface takes a start and size, not start and end, so we can't just copy and paste.
Fixes regressions in dEQP-VK.memory.allocation.random.*
Fixes ccac7ce373c1 ("drm/msm: Refactor address space initialization")Signed-off-by Eric Anholt <[email protected]>
rebased on https://patchwork.freedesktop.org/series/78281/ (which fixed half of the problem) and pushed this and 2/2 to msm-next so it should show up in linux-next shortly..
planning to wait a short time more to see if we find any other issues and then send a -fixes PR
BR,
-R
Quoted 18 lines
--- drivers/gpu/drm/msm/adreno/adreno_gpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/msm/adreno/adreno_gpu.c +1
-2@@ -194,7 +194,7 @@ adreno_iommu_create_address_space(struct msm_gpu *gpu,struct msm_gem_address_space *aspace; aspace =msm_gem_address_space_create (mmu,"gpu" ,SZ_16M , -0xfffffff ); +0xffffffff -SZ_16M );if (IS_ERR (aspace) && !IS_ERR (mmu)) mmu->funcs->destroy (mmu); --
Quoted 2 lines
2.26.2
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 13 lines · Rob Clark
Quoted 10 lines · Eric Anholt
Previously the address space went from 16M to ~0u, but with the refactor one of the 'f's was dropped, limiting us to 256MB. Additionally, the new interface takes a start and size, not start and end, so we can't just copy and paste.
Fixes regressions in dEQP-VK.memory.allocation.random.*
Fixes ccac7ce373c1 ("drm/msm: Refactor address space initialization")Signed-off-by Eric Anholt <[email protected]>
Quoted 6 lines
rebased on https://patchwork.freedesktop.org/series/78281/ (which fixed half of the problem) and pushed this and 2/2 to msm-next so it should show up in linux-next shortly..
planning to wait a short time more to see if we find any other issues and then send a -fixes PR
I'll fix up the rest of the flubbed addresses sizes.
Jordan
Quoted 24 lines
BR,
-RQuoted 20 lines
--- drivers/gpu/drm/msm/adreno/adreno_gpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/msm/adreno/adreno_gpu.c +1
-2@@ -194,7 +194,7 @@ adreno_iommu_create_address_space(struct msm_gpu *gpu,struct msm_gem_address_space *aspace; aspace =msm_gem_address_space_create (mmu,"gpu" ,SZ_16M , -0xfffffff ); +0xffffffff -SZ_16M );if (IS_ERR (aspace) && !IS_ERR (mmu)) mmu->funcs->destroy (mmu); --2.26.2
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project