Skip to contentSkip to conversation

ARM: dts: omap3: Migrate AES from hwmods to sysc-omap2

PATCH In review Adam Ford 4 participants 5 messages Jun 17, 2020 – Jul 1, 2020

Subsystems (5)
lore
Share & tools
lore

Adam Ford

author
#0 lore raw

PATCH 1/1 ARM: dts: omap3: Migrate AES from hwmods to sysc-omap2

Various OMAP3 boards have two AES blocks, but only one is currently available, because the hwmods are only configured for one.

This patch migrates the hwmods for the AES engine to sysc-omap2 which allows the second AES crypto engine to become available.

omap-aes 480a6000.aes1: OMAP AES hw accel rev: 2.6 omap-aes 480a6000.aes1: will run requests pump with realtime priority omap-aes 480c5000.aes2: OMAP AES hw accel rev: 2.6 omap-aes 480c5000.aes2: will run requests pump with realtime priority

---
V2: Fix DMA for AES1, and remove from AM3517.

arch/arm/boot/dts/am3517.dtsi +3 -0
index dc8927f14b6c..6be310968c3a 100644
@@ -10,6 +10,9 @@
 
 #include "omap3.dtsi"
 
+/* AM3517 doesn't appear to have the crypto engines defined in omap3.dtsi */
+/delete-node/ &aes1_target;
+
 / {
 	aliases {
 		serial3 = &uart4;
arch/arm/boot/dts/omap3.dtsi +50 -7

63 lines not on this page · raw message

arch/arm/mach-omap2/omap_hwmod_3xxx_data.c +0 -61

109 lines not on this page · raw message

Signature · 1 line
2.25.1
#1 lore raw
Thank you for the patch! Yet something to improve:

Hi Adam,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on omap/for-next]
[cannot apply to balbi-usb/testing/next]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Adam-Ford/ARM-dts-omap3-Migrate-AES-from-hwmods-to-sysc-omap2/20200617-190017
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap.git for-next
config: arm-defconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0

reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm

If you fix the issue, kindly add following tag as appropriate

All errors (new ones prefixed by >>, old ones prefixed by <<):

>> Error: arch/arm/boot/dts/omap3-tao3530.dtsi:11.1-5 Label or path aes not found
>> FATAL ERROR: Syntax error parsing input tree
--
>> Error: arch/arm/boot/dts/omap3-n900.dts:22.1-5 Label or path aes not found
>> FATAL ERROR: Syntax error parsing input tree

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

maintainer
#2 lore raw
Quoted 9 lines · kernel test robot

Hi Adam,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on omap/for-next]
[cannot apply to balbi-usb/testing/next]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

This applies to v5.8-rc1, so the error above can be ignored now.

Applying patch into omap-for-v5.9/ti-sysc-drop-pdata.

Thanks,

Tony

#3 lore raw
Quoted 5 lines · Tony Lindgren
Quoted 4 lines · kernel test robot

Hi Adam,

Thank you for the patch! Yet something to improve:

Quoted 8 lines
Quoted 5 lines

[auto build test ERROR on omap/for-next]
[cannot apply to balbi-usb/testing/next]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

This applies to v5.8-rc1, so the error above can be ignored now.

Applying patch into omap-for-v5.9/ti-sysc-drop-pdata.

Hi Tony,

Thanks for the feedback, we'll fix the wrong base.

Best Regards,
Rong Chen

maintainer
#4 lore raw
Quoted 13 lines · Rong Chen
Quoted 10 lines · Tony Lindgren
Quoted 9 lines · kernel test robot

Hi Adam,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on omap/for-next]
[cannot apply to balbi-usb/testing/next]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

Quoted 7 lines
Quoted 3 lines

This applies to v5.8-rc1, so the error above can be ignored now.

Applying patch into omap-for-v5.9/ti-sysc-drop-pdata.

Hi Tony,

Thanks for the feedback, we'll fix the wrong base.

OK thanks. Not sure what you use to determine the base, but in general current Linux mainline master or for-next should work as the base.

Regards,

Tony