Skip to contentSkip to conversation

m68k: mcfmmu: remove stale part of comment about steal_context

PATCH Applied Mike Rapoport 2 participants 4 messages Jun 18, 2020 m68k architecture

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 m68k: mcfmmu: remove stale part of comment about steal_context

From: Mike Rapoport <[email protected]>

The comment about steal_context() came from powerpc and a part of it addresses differences between powerpc variants that are not really relevant to m68k.

Remove that part of the comment.

---
Hi,

I've found this by pure chance while grepping for pgalloc.h It's been there since 2011, but I don't think it's a stable material, so I didn't cc them.

 arch/m68k/mm/mcfmmu.c | 5 -----
 1 file changed, 5 deletions(-)
arch/m68k/mm/mcfmmu.c +0 -5
index 29f47923aa46..cb9f8675d81b 100644
@@ -214,11 +214,6 @@ void __init cf_mmu_context_init(void)
 
 /*
  * Steal a context from a task that has one at the moment.
- * This is only used on 8xx and 4xx and we presently assume that
- * they don't do SMP.  If they do then thicfpgalloc.hs will have to check
- * whether the MM we steal is in use.
- * We also assume that this is only used on systems that don't
- * use an MMU hash table - this is true for 8xx and 4xx.
  * This isn't an LRU system, it just frees up each context in
  * turn (sort-of pseudo-random replacement :).  This would be the
  * place to implement an LRU scheme if anyone was motivated to do it.
Signature · 1 line
2.25.4
Acked-by on v1 1/1
#1 lore raw

Hi Mike,

Quoted 9 lines · Mike Rapoport

From: Mike Rapoport <[email protected]>

The comment about steal_context() came from powerpc and a part of it addresses differences between powerpc variants that are not really relevant to m68k.

Remove that part of the comment.

Do you want me to carry that in my m68k (m68knommu) tree for v5.9?

Regards
Greg

Quoted 27 lines

---
Hi,

I've found this by pure chance while grepping for pgalloc.h It's been there since 2011, but I don't think it's a stable material, so I didn't cc them.

  arch/m68k/mm/mcfmmu.c | 5 -----
  1 file changed, 5 deletions(-)
arch/m68k/mm/mcfmmu.c +0 -5
index 29f47923aa46..cb9f8675d81b 100644
@@ -214,11 +214,6 @@ void __init cf_mmu_context_init(void)
 
  /*
   * Steal a context from a task that has one at the moment.
- * This is only used on 8xx and 4xx and we presently assume that
- * they don't do SMP.  If they do then thicfpgalloc.hs will have to check
- * whether the MM we steal is in use.
- * We also assume that this is only used on systems that don't
- * use an MMU hash table - this is true for 8xx and 4xx.
   * This isn't an LRU system, it just frees up each context in
   * turn (sort-of pseudo-random replacement :).  This would be the
   * place to implement an LRU scheme if anyone was motivated to do it.
#2 lore raw

Hi Greg,

Quoted 9 lines · Greg Ungerer

Hi Mike,

Quoted 6 lines · Mike Rapoport

From: Mike Rapoport <[email protected]>

The comment about steal_context() came from powerpc and a part of it addresses differences between powerpc variants that are not really relevant to m68k.

Quoted 7 lines
Quoted 3 lines

Remove that part of the comment.

Do you want me to carry that in my m68k (m68knommu) tree for v5.9?

Yes, please :)

Quoted 30 lines

Regards
Greg

Quoted 26 lines

---
Hi,

I've found this by pure chance while grepping for pgalloc.h It's been there since 2011, but I don't think it's a stable material, so I didn't cc them.

  arch/m68k/mm/mcfmmu.c | 5 -----
  1 file changed, 5 deletions(-)
arch/m68k/mm/mcfmmu.c +0 -5
index 29f47923aa46..cb9f8675d81b 100644
@@ -214,11 +214,6 @@ void __init cf_mmu_context_init(void)
  /*
   * Steal a context from a task that has one at the moment.
- * This is only used on 8xx and 4xx and we presently assume that
- * they don't do SMP.  If they do then thicfpgalloc.hs will have to check
- * whether the MM we steal is in use.
- * We also assume that this is only used on systems that don't
- * use an MMU hash table - this is true for 8xx and 4xx.
   * This isn't an LRU system, it just frees up each context in
   * turn (sort-of pseudo-random replacement :).  This would be the
   * place to implement an LRU scheme if anyone was motivated to do it.
 
Signature · 2 lines
Sincerely yours,
Mike.
Applied
#3 lore raw

Hi Mike

Quoted 10 lines · Mike Rapoport
Quoted 9 lines · Greg Ungerer
Quoted 8 lines · Mike Rapoport

From: Mike Rapoport <[email protected]>

The comment about steal_context() came from powerpc and a part of it addresses differences between powerpc variants that are not really relevant to m68k.

Remove that part of the comment.

Quoted 7 lines
Quoted 5 lines
Quoted 1 line

Do you want me to carry that in my m68k (m68knommu) tree for v5.9?

Yes, please :)

Applied to for-next branch of m68knommu git tree.

Thanks!
Greg

Quoted 27 lines
Quoted 26 lines
Quoted 26 lines

---
Hi,

I've found this by pure chance while grepping for pgalloc.h It's been there since 2011, but I don't think it's a stable material, so I didn't cc them.

   arch/m68k/mm/mcfmmu.c | 5 -----
   1 file changed, 5 deletions(-)
arch/m68k/mm/mcfmmu.c +0 -5
index 29f47923aa46..cb9f8675d81b 100644
@@ -214,11 +214,6 @@ void __init cf_mmu_context_init(void)
   /*
    * Steal a context from a task that has one at the moment.
- * This is only used on 8xx and 4xx and we presently assume that
- * they don't do SMP.  If they do then thicfpgalloc.hs will have to check
- * whether the MM we steal is in use.
- * We also assume that this is only used on systems that don't
- * use an MMU hash table - this is true for 8xx and 4xx.
    * This isn't an LRU system, it just frees up each context in
    * turn (sort-of pseudo-random replacement :).  This would be the
    * place to implement an LRU scheme if anyone was motivated to do it.