serial: 8250_em: Switch to use platform_get_irq()
PATCH 1/1 serial: 8250_em: Switch to use platform_get_irq()
platform_get_irq() provides an established error code and error message. Also, it's better to use dedicated API to retrieve Linux IRQ resource.
Signed-off-by Andy Shevchenko <[email protected]>
--- drivers/tty/serial/8250/8250_em.c | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-)
drivers/tty/serial/8250/8250_em.c +10 -6
@@ -78,14 +78,18 @@ static void serial8250_em_serial_dl_write(struct uart_8250_port *up, int value)static int serial8250_em_probe (struct platform_device *pdev) { -struct resource *regs =platform_get_resource (pdev,IORESOURCE_MEM ,0 ); -struct resource *irq =platform_get_resource (pdev,IORESOURCE_IRQ ,0 );struct serial8250_em_priv *priv;struct uart_8250_port up; -int ret; +struct resource *regs; +int irq, ret; -if (!regs || !irq) { -dev_err (&pdev->dev,"missing registers or irq\n" ); + irq =platform_get_irq (pdev,0 ); +if (irq <0 ) +return irq; + + regs =platform_get_resource (pdev,IORESOURCE_MEM ,0 ); +if (!regs) { +dev_err (&pdev->dev,"missing registers\n" );return -EINVAL ; }
@@ -101,7 +105,7 @@ static int serial8250_em_probe(struct platform_device *pdev)memset (&up,0 ,sizeof (up)); up.port.mapbase = regs->start; - up.port.irq = irq->start; + up.port.irq = irq; up.port.type =PORT_UNKNOWN ; up.port.flags =UPF_BOOT_AUTOCONF |UPF_FIXED_PORT |UPF_IOREMAP ; up.port.dev = &pdev->dev;
Signature · 1 line
2.27.0.rc2