firmware: tee_bnxt: Use UUID API for exporting the UUID
PATCH 1/1 firmware: tee_bnxt: Use UUID API for exporting the UUID
There is export_uuid() function which exports uuid_t to the u8 array. Use it instead of open coding variant.
This allows to hide the uuid_t internals.
Signed-off-by Andy Shevchenko <[email protected]>
--- drivers/firmware/broadcom/tee_bnxt_fw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/firmware/broadcom/tee_bnxt_fw.c +1 -1
@@ -197,7 +197,7 @@ static int tee_bnxt_fw_probe(struct device *dev)return -ENODEV ;/* Open session with Bnxt load Trusted App */ -memcpy (sess_arg.uuid, bnxt_device->id.uuid.b,TEE_IOCTL_UUID_LEN ); +export_uuid (sess_arg.uuid, &bnxt_device->id.uuid); sess_arg.clnt_login =TEE_IOCTL_LOGIN_PUBLIC ; sess_arg.num_params =0 ;
Signature · 1 line
2.26.1
Quoted 4 lines · Andy Shevchenko
There is
export_uuid()function which exportsuuid_tto the u8 array. Use it instead of open coding variant.This allows to hide the
uuid_tinternals.
Any comment on this?
Quoted 21 lines
Signed-off-by Andy Shevchenko <[email protected]>--- drivers/firmware/broadcom/tee_bnxt_fw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/firmware/broadcom/tee_bnxt_fw.c +1
-1@@ -197,7 +197,7 @@ static int tee_bnxt_fw_probe(struct device *dev)return -ENODEV ;/* Open session with Bnxt load Trusted App */ -memcpy (sess_arg.uuid, bnxt_device->id.uuid.b,TEE_IOCTL_UUID_LEN ); +export_uuid (sess_arg.uuid, &bnxt_device->id.uuid); sess_arg.clnt_login =TEE_IOCTL_LOGIN_PUBLIC ; sess_arg.num_params =0 ;Signature · 1 line
2.26.1
Signature · 2 lines
With Best Regards, Andy Shevchenko
Quoted 7 lines · Andy Shevchenko
Quoted 4 lines · Andy Shevchenko
There is
export_uuid()function which exportsuuid_tto the u8 array. Use it instead of open coding variant.This allows to hide the
uuid_tinternals.Any comment on this?
Guys, who is going to pick this up?
Quoted 18 lines
Quoted 18 lines
Signed-off-by Andy Shevchenko <[email protected]>--- drivers/firmware/broadcom/tee_bnxt_fw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/firmware/broadcom/tee_bnxt_fw.c +1
-1@@ -197,7 +197,7 @@ static int tee_bnxt_fw_probe(struct device *dev)return -ENODEV ;/* Open session with Bnxt load Trusted App */ -memcpy (sess_arg.uuid, bnxt_device->id.uuid.b,TEE_IOCTL_UUID_LEN ); +export_uuid (sess_arg.uuid, &bnxt_device->id.uuid); sess_arg.clnt_login =TEE_IOCTL_LOGIN_PUBLIC ; sess_arg.num_params =0 ;
Signature · 2 lines
With Best Regards, Andy Shevchenko