serial: 8250_ingenic: Switch to use platform_get_irq()
Subsystems (2)
PATCH 1/1 serial: 8250_ingenic: Switch to use platform_get_irq()
platform_get_irq() provides an established error code and error message. Also, it's better to use dedicated API to retrieve Linux IRQ resource.
Signed-off-by Andy Shevchenko <[email protected]>
--- drivers/tty/serial/8250/8250_ingenic.c | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-)
drivers/tty/serial/8250/8250_ingenic.c +10 -6
@@ -207,12 +207,11 @@ static unsigned int ingenic_uart_serial_in(struct uart_port *p, int offset)static int ingenic_uart_probe (struct platform_device *pdev) {struct uart_8250_port uart = {}; -struct resource *regs =platform_get_resource (pdev,IORESOURCE_MEM ,0 ); -struct resource *irq =platform_get_resource (pdev,IORESOURCE_IRQ ,0 );struct ingenic_uart_data *data;const struct ingenic_uart_config *cdata;const struct of_device_id *match; -int err, line; +struct resource *regs; +int irq, err, line; match =of_match_device (of_match, &pdev->dev);if (!match) {
@@ -221,8 +220,13 @@ static int ingenic_uart_probe(struct platform_device *pdev) } cdata = match->data; -if (!regs || !irq) { -dev_err (&pdev->dev,"no registers/irq defined\n" ); + irq =platform_get_irq (pdev,0 ); +if (irq <0 ) +return irq; + + regs =platform_get_resource (pdev,IORESOURCE_MEM ,0 ); +if (!regs) { +dev_err (&pdev->dev,"no registers defined\n" );return -EINVAL ; }
@@ -238,7 +242,7 @@ static int ingenic_uart_probe(struct platform_device *pdev) uart.port.regshift =2 ; uart.port.serial_out = ingenic_uart_serial_out; uart.port.serial_in = ingenic_uart_serial_in; - uart.port.irq = irq->start; + uart.port.irq = irq; uart.port.dev = &pdev->dev; uart.port.fifosize = cdata->fifosize; uart.tx_loadsz = cdata->tx_loadsz;
Signature · 1 line
2.27.0.rc2