Skip to contentSkip to conversation

ir-validate: remove orphan comments

PATCH In review garritfra 2 participants 2 messages Jun 18, 2020 Sparse checker

lore
Share & tools
lore

garritfra

author
#0 lore raw

PATCH 1/1 ir-validate: remove orphan comments

Please let me know if these comments have a right to be there, but I think they are orphans and can be removed.

---
 optimize.c | 7 -------
 1 file changed, 7 deletions(-)
optimize.c +0 -7
index e8cb7fc3..31d94e61 100644
@@ -75,7 +75,6 @@ repeat:
 	 */
 	do {
 		simplify_memops(ep);
-		//ir_validate(ep);
 		do {
 			repeat_phase = 0;
 			clean_up_insns(ep);
@@ -86,15 +85,11 @@ repeat:
 
 			if (repeat_phase & REPEAT_SYMBOL_CLEANUP)
 				simplify_memops(ep);
-			//ir_validate(ep);
 		} while (repeat_phase);
 		pack_basic_blocks(ep);
-		//ir_validate(ep);
 		if (repeat_phase & REPEAT_CFG_CLEANUP)
 			kill_unreachable_bbs(ep);
-		//ir_validate(ep);
 	} while (repeat_phase);
-	//ir_validate(ep);
 
 	vrfy_flow(ep);
 
@@ -111,13 +106,11 @@ repeat:
 	 * again
 	 */
 	if (simplify_flow(ep)) {
-		//ir_validate(ep);
 		clear_liveness(ep);
 		if (repeat_phase & REPEAT_CFG_CLEANUP)
 			kill_unreachable_bbs(ep);
 		goto repeat;
 	}
-	//ir_validate(ep);
 
 	/* Finally, add deathnotes to pseudos now that we have them */
 	if (dbg_dead)
Signature · 1 line
2.25.1
#1 lore raw

On Thu, Jun 18, 2020 at 04:09:14PM +0200, garritfra wrote:

Hi,

Quoted 2 lines

Please let me know if these comments have a right to be there, but I think they are orphans and can be removed.

Indeed, they have been commited more or less by error and have never been removed.

Thanks for the patch.
-- Luc