Skip to contentSkip to conversation

staging: rtl8723bs: os_dep: ioctl_cfg80211: fixed code styl issues

PATCH In review Shihab Rashed 2 participants 2 messages Jun 18, 2020 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: rtl8723bs: os_dep: ioctl_cfg80211: fixed code styl issues

Fixed two brace coding style issues and one comment style issue found by checkpatch.

---
 drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 15 +++++++--------
 1 file changed, 7 insertions(+), 8 deletions(-)
drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c +7 -8
index 2fb80b6eb51d..3b06b60cdfd1 100644
@@ -117,15 +117,12 @@ static struct ieee80211_supported_band *rtw_spt_band_alloc(
 	struct ieee80211_supported_band *spt_band = NULL;
 	int n_channels, n_bitrates;
 
-	if (band == NL80211_BAND_2GHZ)
-	{
+	if (band == NL80211_BAND_2GHZ)	{
 		n_channels = RTW_2G_CHANNELS_NUM;
 		n_bitrates = RTW_G_RATES_NUM;
-	}
-	else
-	{
+	} else	{
 		goto exit;
-	}
+		}
 
 	spt_band = rtw_zmalloc(sizeof(struct ieee80211_supported_band) +
 			       sizeof(struct ieee80211_channel) * n_channels +
@@ -203,8 +200,10 @@ rtw_cfg80211_default_mgmt_stypes[NUM_NL80211_IFTYPES] = {
 
 static int rtw_ieee80211_channel_to_frequency(int chan, int band)
 {
-	/* see 802.11 17.3.8.3.2 and Annex J
-	* there are overlapping channel numbers in 5GHz and 2GHz bands */
+	/*
+	 * see 802.11 17.3.8.3.2 and Annex J
+	 * there are overlapping channel numbers in 5GHz and 2GHz bands
+	 */
 	if (band == NL80211_BAND_2GHZ) {
 		if (chan == 14)
 			return 2484;
Signature · 1 line
2.17.1
#1 lore raw
Quoted 13 lines · Shihab Rashed

Fixed two brace coding style issues and one comment style issue found by checkpatch.

---
 drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 15 +++++++--------
 1 file changed, 7 insertions(+), 8 deletions(-)
drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c +0 -0
index 2fb80b6eb51d..3b06b60cdfd1 100644

drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c static struct ieee80211_supported_band *rtw_spt_band_alloc( · line 120

Quoted 6 lines
drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c +1 -2
@@ -117,15 +117,12 @@ static struct ieee80211_supported_band *rtw_spt_band_alloc(
 	struct ieee80211_supported_band *spt_band = NULL;
 	int n_channels, n_bitrates;
 
-	if (band == NL80211_BAND_2GHZ)
-	{
+	if (band == NL80211_BAND_2GHZ)	{
                                      ^^

too many spaces.

drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c static struct ieee80211_supported_band *rtw_spt_band_alloc( · line 123

Quoted 6 lines
drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c +1 -3
 		n_channels = RTW_2G_CHANNELS_NUM;
 		n_bitrates = RTW_G_RATES_NUM;
-	}
-	else
-	{
+	} else	{
              ^^

too many spaces.

drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c static struct ieee80211_supported_band *rtw_spt_band_alloc( · line 125

Quoted 3 lines
drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c +1 -1
 		goto exit;
-	}
+		}
                ^

Indented too far.

drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c static struct ieee80211_supported_band *rtw_spt_band_alloc( · line 128

Quoted 3 lines
drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c +0 -0
 	spt_band = rtw_zmalloc(sizeof(struct ieee80211_supported_band) +
 			       sizeof(struct ieee80211_channel) * n_channels +

regards,
dan carpenter