Skip to contentSkip to conversation

dma-mapping: DMA_COHERENT_POOL should select GENERIC_ALLOCATOR

PATCH In review Christoph Hellwig 2 participants 2 messages Jun 18, 2020 DMA mapping helpers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dma-mapping: DMA_COHERENT_POOL should select GENERIC_ALLOCATOR

The dma coherent pool code needs genalloc. Move the select over from DMA_REMAP, which doesn't actually need it.

Fixes dbed452a078d ("dma-pool: decouple DMA_REMAP from DMA_COHERENT_POOL")
---
 kernel/dma/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/dma/Kconfig +1 -1
index a0ce3c1494fdd2..6ad16b7c96526c 100644
@@ -74,12 +74,12 @@ config DMA_NONCOHERENT_MMAP
 	bool
 
 config DMA_COHERENT_POOL
+	select GENERIC_ALLOCATOR
 	bool
 
 config DMA_REMAP
 	bool
 	depends on MMU
-	select GENERIC_ALLOCATOR
 	select DMA_NONCOHERENT_MMAP
 
 config DMA_DIRECT_REMAP
Signature · 1 line
2.26.2
Acked-by on v1 1/1
#1 lore raw
Quoted 5 lines · Christoph Hellwig

The dma coherent pool code needs genalloc. Move the select over from DMA_REMAP, which doesn't actually need it.

Fixes dbed452a078d ("dma-pool: decouple DMA_REMAP from DMA_COHERENT_POOL")

Thanks Christoph. In the initial bug report from Alex Xu, his .config set CONFIG_GENERIC_ALLOCATOR already so I think there is very little risk with this patch.