Skip to contentSkip to conversation

ARM: dts: stm32: Reinstate card detect behavior on DHSOM

PATCH New Marek Vasut 2 participants 4 messages Jun 18, 2020 – Jun 19, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: dts: stm32: Reinstate card detect behavior on DHSOM

The cd-gpios with (GPIO_ACTIVE_LOW | GPIO_PULL_UP) gpio is thus far unsupported, reinstate the old cd-gpios behavior until this handling is fully implemented. This permits the DHSOM to boot from SD again, without this patch the card detect fails.

Cc Patrick Delaunay <[email protected]>
Cc Patrice Chotard <[email protected]>
---
 arch/arm/dts/stm32mp15xx-dhcom-u-boot.dtsi | 3 +++
 1 file changed, 3 insertions(+)
arch/arm/dts/stm32mp15xx-dhcom-u-boot.dtsi +3 -0
index 75d75266e8..df63ad4a24 100644
@@ -273,6 +273,9 @@
 
 &sdmmc1 {
 	u-boot,dm-spl;
+	broken-cd;
+	/delete-property/ cd-gpios;
+	/delete-property/ disable-wp;
 };
 
 &sdmmc1_b4_pins_a {
Signature · 1 line
2.27.0
#1 lore raw

PATCH 1/1 ARM: dts: stm32: Reinstate card detect behavior on DHSOM

Hi Marek,

Quoted 31 lines

From: Marek Vasut <[email protected]>
Sent: jeudi 18 juin 2020 20:35

The cd-gpios with (GPIO_ACTIVE_LOW | GPIO_PULL_UP) gpio is thus far unsupported, reinstate the old cd-gpios behavior until this handling is fully implemented. This permits the DHSOM to boot from SD again, without this patch the card detect fails.

Cc Patrick Delaunay <[email protected]>
Cc Patrice Chotard <[email protected]>
---
 arch/arm/dts/stm32mp15xx-dhcom-u-boot.dtsi | 3 +++
 1 file changed, 3 insertions(+)
arch/arm/dts/stm32mp15xx-dhcom-u-boot.dtsi +3 -1
index 75d75266e8..df63ad4a24 100644
@@ -273,6 +273,9 @@
 
 &sdmmc1 {
 	u-boot,dm-spl;
+	broken-cd;
+	/delete-property/ cd-gpios;
+	/delete-property/ disable-wp;
 };
 
 &sdmmc1_b4_pins_a {
--
Quoted 1 line

2.27.0

This fix should be included in v2020.07....
So I will prepare a pull request.

Just for information: I assumed that PULL_UP was correctly managed when I update the device tree.

Support is added in ucalss by the serie with the patches 788ea834124 ("gpio: add function _dm_gpio_set_dir_flags") 477ca57b9a5 ("gpio: add support of new GPIO direction flag")

But I forget that the driver part wasn't yet accepted / merged in master branch.

http://patchwork.ozlabs.org/project/uboot/list/?series=181294

In particular the commit "gpio: stm32: add ops set_dir_flags"

Today I target this serie in v2020.10 after review
(I think it is late v2020.07 as it is impacting STM32MP MPU and STM32 MCU)

Sorry for disturbance....

Thanks

Patrick

#2 lore raw

PATCH 1/1 ARM: dts: stm32: Reinstate card detect behavior on DHSOM

Quoted 48 lines · Patrick DELAUNAY

Hi Marek,

Quoted 31 lines

From: Marek Vasut <[email protected]>
Sent: jeudi 18 juin 2020 20:35

The cd-gpios with (GPIO_ACTIVE_LOW | GPIO_PULL_UP) gpio is thus far unsupported, reinstate the old cd-gpios behavior until this handling is fully implemented. This permits the DHSOM to boot from SD again, without this patch the card detect fails.

Cc Patrick Delaunay <[email protected]>
Cc Patrice Chotard <[email protected]>
---
 arch/arm/dts/stm32mp15xx-dhcom-u-boot.dtsi | 3 +++
 1 file changed, 3 insertions(+)
arch/arm/dts/stm32mp15xx-dhcom-u-boot.dtsi +3 -1
index 75d75266e8..df63ad4a24 100644
@@ -273,6 +273,9 @@
 
 &sdmmc1 {
 	u-boot,dm-spl;
+	broken-cd;
+	/delete-property/ cd-gpios;
+	/delete-property/ disable-wp;
 };
 
 &sdmmc1_b4_pins_a {
--
Quoted 1 line

2.27.0

This fix should be included in v2020.07....
So I will prepare a pull request.

Just for information: I assumed that PULL_UP was correctly managed when I update the device tree.

Support is added in ucalss by the serie with the patches 788ea834124 ("gpio: add function _dm_gpio_set_dir_flags") 477ca57b9a5 ("gpio: add support of new GPIO direction flag")

But I forget that the driver part wasn't yet accepted / merged in master branch.

Quoted 8 lines

http://patchwork.ozlabs.org/project/uboot/list/?series=181294

In particular the commit "gpio: stm32: add ops set_dir_flags"

Today I target this serie in v2020.10 after review
(I think it is late v2020.07 as it is impacting STM32MP MPU and STM32 MCU)

Sorry for disturbance....

No problem, thanks!

#3 lore raw

PATCH 1/1 ARM: dts: stm32: Reinstate card detect behavior on DHSOM

In reply to Marek Vasut

Dear Marek

Quoted 8 lines

From: Marek Vasut <[email protected]>
Sent: jeudi 18 juin 2020 20:35

The cd-gpios with (GPIO_ACTIVE_LOW | GPIO_PULL_UP) gpio is thus far unsupported, reinstate the old cd-gpios behavior until this handling is fully implemented. This permits the DHSOM to boot from SD again, without this patch the card detect fails.

Quoted 4 lines
Cc Patrick Delaunay <[email protected]>
Cc Patrice Chotard <[email protected]>

---

Applied to u-boot-stm/master, thanks!

Regards

Patrick