Skip to contentSkip to conversation

ice: implement snapshot for device capabilities

PATCH New Jacob Keller 2 participants 2 messages Jun 18, 2020 – Jun 22, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 ice: implement snapshot for device capabilities

Add a new devlink region used for capturing a snapshot of the device capabilities buffer which is reported by the firmware over the AdminQ. This information can useful in debugging driver and firmware interactions.

---
v2
* Fixed ice_devlink_destroy_regions to properly release the new region

 drivers/net/ethernet/intel/ice/ice.h         |  1 +
 drivers/net/ethernet/intel/ice/ice_common.c  | 66 +++++++++++++++-----
 drivers/net/ethernet/intel/ice/ice_common.h  |  3 +
 drivers/net/ethernet/intel/ice/ice_devlink.c | 59 +++++++++++++++++
 4 files changed, 115 insertions(+), 14 deletions(-)
drivers/net/ethernet/intel/ice/ice.h +1 -0
index a4cda8212e64..7486d010a619 100644
@@ -373,6 +373,7 @@ struct ice_pf {
 	struct devlink_port devlink_port;
 
 	struct devlink_region *nvm_region;
+	struct devlink_region *devcaps_region;
 
 	/* OS reserved IRQ details */
 	struct msix_entry *msix_entries;
drivers/net/ethernet/intel/ice/ice_common.c +52 -14

84 lines not on this page · raw message

drivers/net/ethernet/intel/ice/ice_common.h +3 -0
index 9b9e50d2398b..e72529e9f022 100644
@@ -87,6 +87,9 @@ enum ice_status
 ice_aq_get_phy_caps(struct ice_port_info *pi, bool qual_mods, u8 report_mode,
 		    struct ice_aqc_get_phy_caps_data *caps,
 		    struct ice_sq_cd *cd);
+enum ice_status
+ice_aq_list_caps(struct ice_hw *hw, void *buf, u16 buf_size, u32 *cap_count,
+		 enum ice_adminq_opc opc, struct ice_sq_cd *cd);
 void
 ice_update_phy_type(u64 *phy_type_low, u64 *phy_type_high,
 		    u16 link_speeds_bitmap);
drivers/net/ethernet/intel/ice/ice_devlink.c +59 -0

81 lines not on this page · raw message

Signature · 1 line
2.25.2
#1 lore raw

PATCH v2 1/1 ice: implement snapshot for device capabilities

Quoted 17 lines

-----Original Message-----
From: Intel-wired-lan <[email protected]> On Behalf Of Jacob Keller
Sent: Thursday, June 18, 2020 11:46 AM
To: Intel Wired LAN <[email protected]>
Subject: [Intel-wired-lan] [PATCH v2] ice: implement snapshot for device capabilities

Add a new devlink region used for capturing a snapshot of the device capabilities buffer which is reported by the firmware over the AdminQ. This information can useful in debugging driver and firmware interactions.

---
v2
* Fixed ice_devlink_destroy_regions to properly release the new region

Quoted 5 lines
 drivers/net/ethernet/intel/ice/ice.h         |  1 +
 drivers/net/ethernet/intel/ice/ice_common.c  | 66 +++++++++++++++-----
drivers/net/ethernet/intel/ice/ice_common.h  |  3 +
drivers/net/ethernet/intel/ice/ice_devlink.c | 59 +++++++++++++++++
 4 files changed, 115 insertions(+), 14 deletions(-)