Skip to contentSkip to conversation

package/python-pybind: rename package to python-pybind11

PATCH New Guillaume W. Bres 2 participants 2 messages Jun 18, 2020

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 package/python-pybind: rename package to python-pybind11

Renaming this package because the current name
might be misleading in the future

---

Please note that this package only allows C++->python bindings at the moment, Asaf's related work must be merged for python->c++ bindings

---
 DEVELOPERS                                          |  2 +-
 package/Config.in                                   |  2 +-
 package/python-pybind/python-pybind.mk              | 13 -------------
 .../{python-pybind => python-pybind11}/Config.in    |  6 +++---
 .../python-pybind11.hash}                           |  2 +-
 package/python-pybind11/python-pybind11.mk          | 13 +++++++++++++
 6 files changed, 19 insertions(+), 19 deletions(-)
 delete mode 100644 package/python-pybind/python-pybind.mk
 rename package/{python-pybind => python-pybind11}/Config.in (53%)
 rename package/{python-pybind/python-pybind.hash => python-pybind11/python-pybind11.hash} (83%)
 create mode 100644 package/python-pybind11/python-pybind11.mk
DEVELOPERS +1 -1
index cbe6bc1856..147381bf0b 100644
@@ -1053,7 +1053,7 @@ F:	package/sdl2/
 N:	Guillaume William Brs <[email protected]>
 F:	package/liquid-dsp/
 F:	package/pixiewps/
-F:	package/python-pybind/
+F:	package/python-pybind11/
 F:	package/reaver/
 
 N:	Guo Ren <[email protected]>
package/Config.in +1 -1
index 1f44fe7ca9..36e9c606c7 100644
@@ -1070,7 +1070,7 @@ menu "External python modules"
 	source "package/python-pyalsa/Config.in"
 	source "package/python-pyasn1/Config.in"
 	source "package/python-pyasn1-modules/Config.in"
-	source "package/python-pybind/Config.in"
+	source "package/python-pybind11/Config.in"
 	source "package/python-pycairo/Config.in"
 	source "package/python-pycares/Config.in"
 	source "package/python-pycli/Config.in"
package/python-pybind/python-pybind.mk deleted +0 -13
deleted file mode 100644
index 634e869e40..0000000000
@@ -1,13 +0,0 @@
-################################################################################
-#
-# python-pybind
-#
-################################################################################
-
-PYTHON_PYBIND_VERSION = 2.5.0
-PYTHON_PYBIND_SITE = $(call github,pybind,pybind11,v$(PYTHON_PYBIND_VERSION))
-PYTHON_PYBIND_LICENSE = BSD-3-Clause
-PYTHON_PYBIND_LICENSE_FILES = LICENSE
-PYTHON_PYBIND_SETUP_TYPE = setuptools
-
-$(eval $(python-package))
package/python-pybind11/Config.in renamed from package/python-pybind/Config.in +3 -3
similarity index 53%
rename from package/python-pybind/Config.in
rename to package/python-pybind11/Config.in
index 604cb9ee67..714c37f13c 100644
@@ -1,7 +1,7 @@
-config BR2_PACKAGE_PYTHON_PYBIND
-	bool "python-pybind"
+config BR2_PACKAGE_PYTHON_PYBIND11
+	bool "python-pybind11"
 	help
-	  PyBind is a lightweight header-only library that exposes C++
+	  PyBind11 is a lightweight header-only library that exposes C++
 	  types in Python and vice versa, mainly to create Python
 	  bindings of existing C++ code.
 
package/python-pybind11/python-pybind11.hash renamed from package/python-pybind/python-pybind.hash +1 -1
similarity index 83%
rename from package/python-pybind/python-pybind.hash
rename to package/python-pybind11/python-pybind11.hash
index 751b0bdf6e..2cdcbee8b2 100644
@@ -1,4 +1,4 @@
 # Locally calculated
-sha256  97504db65640570f32d3fdf701c25a340c8643037c3b69aec469c10c93dc8504   python-pybind-2.5.0.tar.gz
+sha256  97504db65640570f32d3fdf701c25a340c8643037c3b69aec469c10c93dc8504   python-pybind11-2.5.0.tar.gz
 # License files, locally calculated
 sha256  9a37ea54aa3cf12c7f3292799f20822ffd4b9b7142b36a7a9997b28c39264dc9   LICENSE
package/python-pybind11/python-pybind11.mk new file +13 -0
new file mode 100644
index 0000000000..c4fc578894
@@ -0,0 +1,13 @@
+################################################################################
+#
+# python-pybind11
+#
+################################################################################
+
+PYTHON_PYBIND11_VERSION = 2.5.0
+PYTHON_PYBIND11_SITE = $(call github,pybind,pybind11,v$(PYTHON_PYBIND11_VERSION))
+PYTHON_PYBIND11_LICENSE = BSD-3-Clause
+PYTHON_PYBIND11_LICENSE_FILES = LICENSE
+PYTHON_PYBIND11_SETUP_TYPE = setuptools
+
+$(eval $(python-package))
Signature · 1 line
2.20.1
#1 lore raw

PATCH v2 1/1 package/python-pybind: rename package to python-pybind11

Quoted 4 lines · On Thu, 18 Jun 2020 15:40:17 +0200 "Guillaume W. Bres"…

Renaming this package because the current name might be misleading in the future

I still don't get how "misleading in the future" is a good justification.

Quoted 3 lines

Please note that this package only allows C++->python bindings at the moment, Asaf's related work must be merged for python->c++ bindings

I also don't understand why this note makes sense here. If the current package is limited, its Config.in help text should be improved to document those limitations.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com