ARM: dts: imx6qdl-sabreauto: Fix AR8031 phy-mode
Subsystems (2)
Fabio Estevam
reviewerPATCH 1/1 ARM: dts: imx6qdl-sabreauto: Fix AR8031 phy-mode
As per kernel commit 0672d22a1924 ("ARM: dts: imx: Fix the AR803X phy-mode) the correct phy-mode should be "rgmii-id", so fix it accordingly to fix the Ethernet regression.
This problem has been exposed by commit:
commit 13114f38e2ccea9386726d8b9831dfc310589548
Author: Vladimir Oltean <[email protected]> Date: Thu May 7 00:11:51 2020 +0200
phy: atheros: Explicitly disable RGMII delays
To eliminate any doubts about the out-of-reset value of the PHY, that the driver previously relied on.
If bisecting shows that this commit breaks your board you probably have a wrong PHY interface mode. You probably want the PHY_INTERFACE_MODE_RGMII_RXID or PHY_INTERFACE_MODE_RGMII_ID mode.
Fix the phy-mode accordingly to fix the regression.
--- arch/arm/dts/imx6qdl-sabreauto.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/dts/imx6qdl-sabreauto.dtsi +1 -1
@@ -281,7 +281,7 @@ &fec { pinctrl-names = "default"; pinctrl-0 = <&pinctrl_enet>; - phy-mode = "rgmii"; + phy-mode = "rgmii-id"; interrupts-extended = <&gpio1 6 IRQ_TYPE_LEVEL_HIGH>, <&intc 0 119 IRQ_TYPE_LEVEL_HIGH>; fsl,err006687-workaround-present;
Signature · 1 line
2.17.1
PATCH 1/1 ARM: dts: imx6qdl-sabreauto: Fix AR8031 phy-mode
Quoted 13 lines
As per kernel commit
0672d22a1924("ARM: dts: imx: Fix the AR803X phy-mode) the correct phy-mode should be "rgmii-id", so fix it accordingly to fix the Ethernet regression.
This problem has been exposed by commit:
commit13114f38e2ccea9386726d8b9831dfc310589548Author: Vladimir Oltean <[email protected]> Date: Thu May 7 00:11:51 2020 +0200phy: atheros: Explicitly disable RGMII delays
To eliminate any doubts about the out-of-reset value of the PHY, that the driver previously relied on.
If bisecting shows that this commit breaks your board you probably have a wrong PHY interface mode. You probably want thePHY_INTERFACE_MODE_RGMII_RXIDorPHY_INTERFACE_MODE_RGMII_IDmode.
Quoted 4 lines
Signed-off-by Vladimir Oltean <[email protected]>Acked-by Joe Hershberger <[email protected]>Fix the phy-mode accordingly to fix the regression.
Signed-off-by Fabio Estevam <[email protected]>
Applied to u-boot-imx, master, thanks !
Best regards,
Stefano Babic
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================