Skip to contentSkip to conversation

drm/virtio: Fix an IS_ERR() vs NULL check in virtio_gpu_object_shmem_init()

PATCH New Dan Carpenter 1 participant 1 message Jun 19, 2020

Subsystems (5)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/virtio: Fix an IS_ERR() vs NULL check in virtio_gpu_object_shmem_init()

The drm_gem_shmem_get_pages_sgt() function returns error pointers on error, it never returns NULL.

Fixes d323bb44e4d2 ("drm/virtio: Call the right shmem helpers")
---
 drivers/gpu/drm/virtio/virtgpu_object.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/virtio/virtgpu_object.c +2 -2
index 346cef5ce251..0cd5ecf4b3c0 100644
@@ -151,9 +151,9 @@ static int virtio_gpu_object_shmem_init(struct virtio_gpu_device *vgdev,
 		return -EINVAL;
 
 	shmem->pages = drm_gem_shmem_get_pages_sgt(&bo->base.base);
-	if (!shmem->pages) {
+	if (IS_ERR(shmem->pages)) {
 		drm_gem_shmem_unpin(&bo->base.base);
-		return -EINVAL;
+		return PTR_ERR(shmem->pages);
 	}
 
 	if (use_dma_api) {
Signature · 1 line
2.27.0