RDMA/rtrs: fix potential resources leaks
Subsystems (2)
PATCH 1/1 RDMA/rtrs: fix potential resources leaks
Dev is returned from allocation function kzalloc but it does not free it in out_err path.
Detected by CoverityScan, CID# 1464569: (Resource leak)
---drivers/infiniband/ulp/rtrs/rtrs.c | 1 +
1 file changed, 1 insertion(+)
drivers/infiniband/ulp/rtrs/rtrs.c +0 -0
@@ -607,6 +607,7 @@ rtrs_ib_dev_find_or_add(struct ib_device *ib_dev,
else kfree(dev); out_err: + kfree(dev); return NULL; }
EXPORT_SYMBOL(rtrs_ib_dev_find_or_add);
--
2.11.0
Hi, Bo,
Quoted 3 lines · Bo YU
Dev is returned from allocation function kzalloc but it does not free it in
out_errpath.
If allocation failed, kzalloc return NULL, nothing to free.
Quoted 24 lines
Detected by CoverityScan, CID# 1464569: (Resource leak)
Fixes c0894b3ea69d3("RDMA/rtrs: core: lib functions shared between client and server modules")Signed-off-by Bo YU <[email protected]>--- drivers/infiniband/ulp/rtrs/rtrs.c | 1 + 1 file changed, 1 insertion(+)drivers/infiniband/ulp/rtrs/rtrs.c +1
-1@@ -607,6 +607,7 @@ rtrs_ib_dev_find_or_add(struct ib_device *ib_dev,else kfree (dev); out_err: +kfree (dev);return NULL ; }EXPORT_SYMBOL (rtrs_ib_dev_find_or_add); --2.11.0
Quoted 6 lines · Jinpu Wang
Hi, Bo,
Quoted 3 lines · Bo YU
Dev is returned from allocation function kzalloc but it does not free it in
out_errpath.If allocation failed, kzalloc return NULL, nothing to free.
You should re-organize this to not confuse coverity.
IS_ERR_OR_NULL should rarely be used and is the problem here
Jason