arm64: perf: add support for Cortex-A55/A75/A76
Subsystems (3)
cover arm64: perf: add support for Cortex-A55/A75/A76
The Cortex-A55/A75/A76 use some implementation defined perf events. Add the support.
Jisheng Zhang (3):
arm64: perf: add support for Cortex-A55
arm64: perf: add support for Cortex-A75
arm64: perf: add support for Cortex-A76
arch/arm64/kernel/perf_event.c | 49 +++++++++++++++++++++++++++++++--- 1 file changed, 45 insertions(+), 4 deletions(-)
Signature · 1 line
2.27.0
PATCH 1/3 arm64: perf: add support for Cortex-A55
The Cortex-A55 uses some implementation defined perf events. This patch sets up the necessary mapping for Cortex-A55.
Mappings are based on Cortex-A55 TRM r2p0, section C2.4 PMU Events (pages C2-567 to C2-582).
--- arch/arm64/kernel/perf_event.c | 25 +++++++++++++++++++++++-- 1 file changed, 23 insertions(+), 2 deletions(-)
arch/arm64/kernel/perf_event.c +23 -2
@@ -21,7 +21,7 @@#include <linux/platform_device.h> #include <linux/smp.h> -/* ARMv8 Cortex-A53 specific event types. */ +/* ARMv8 Cortex-A53/A55 specific event types. */ #define ARMV8_A53_PERFCTR_PREF_LINEFILL 0xC2/* ARMv8 Cavium ThunderX specific event types. */
@@ -81,6 +81,22 @@ static const unsigned armv8_a53_perf_cache_map[PERF_COUNT_HW_CACHE_MAX] [C(NODE)][C(OP_WRITE)][C(RESULT_ACCESS)] = ARMV8_IMPDEF_PERFCTR_BUS_ACCESS_WR, }; +static const unsigned armv8_a55_perf_cache_map[PERF_COUNT_HW_CACHE_MAX ] + [PERF_COUNT_HW_CACHE_OP_MAX ] + [PERF_COUNT_HW_CACHE_RESULT_MAX ] = { +PERF_CACHE_MAP_ALL_UNSUPPORTED , + + [C (L1D )][C (OP_READ )][C (RESULT_ACCESS )] =ARMV8_IMPDEF_PERFCTR_L1D_CACHE_RD , + [C (L1D )][C (OP_READ )][C (RESULT_MISS )] =ARMV8_IMPDEF_PERFCTR_L1D_CACHE_REFILL_RD , + [C (L1D )][C (OP_WRITE )][C (RESULT_ACCESS )] =ARMV8_IMPDEF_PERFCTR_L1D_CACHE_WR , + [C (L1D )][C (OP_WRITE )][C (RESULT_MISS )] =ARMV8_IMPDEF_PERFCTR_L1D_CACHE_REFILL_WR , + [C (L1D )][C (OP_PREFETCH )][C (RESULT_MISS )] =ARMV8_A53_PERFCTR_PREF_LINEFILL , + + + [C (NODE )][C (OP_READ )][C (RESULT_ACCESS )] =ARMV8_IMPDEF_PERFCTR_BUS_ACCESS_RD , + [C (NODE )][C (OP_WRITE )][C (RESULT_ACCESS )] =ARMV8_IMPDEF_PERFCTR_BUS_ACCESS_WR , +}; +static const unsigned armv8_a57_perf_cache_map[PERF_COUNT_HW_CACHE_MAX ] [PERF_COUNT_HW_CACHE_OP_MAX ] [PERF_COUNT_HW_CACHE_RESULT_MAX ] = {
@@ -909,6 +925,11 @@ static int armv8_a53_map_event(struct perf_event *event)return __armv8_pmuv3_map_event (event,NULL , &armv8_a53_perf_cache_map); } +static int armv8_a55_map_event (struct perf_event *event) +{ +return __armv8_pmuv3_map_event (event,NULL , &armv8_a55_perf_cache_map); +} +static int armv8_a57_map_event (struct perf_event *event) {return __armv8_pmuv3_map_event (event,NULL , &armv8_a57_perf_cache_map);
@@ -1050,7 +1071,7 @@ static int armv8_a53_pmu_init(struct arm_pmu *cpu_pmu)static int armv8_a55_pmu_init (struct arm_pmu *cpu_pmu) {return armv8_pmu_init (cpu_pmu,"armv8_cortex_a55" , - armv8_pmuv3_map_event,NULL ,NULL ); + armv8_a55_map_event,NULL ,NULL ); }static int armv8_a57_pmu_init (struct arm_pmu *cpu_pmu)
Signature · 1 line
2.27.0
PATCH 2/3 arm64: perf: add support for Cortex-A75
In reply to Jisheng ZhangThe Cortex-A75 uses some implementation defined perf events. This patch sets up the necessary mapping for Cortex-A75.
Mappings are based on Cortex-A75 TRM r3p1, section C2.3 PMU Events (pages C2-578 to C2-586).
--- arch/arm64/kernel/perf_event.c | 22 +++++++++++++++++++++- 1 file changed, 21 insertions(+), 1 deletion(-)
arch/arm64/kernel/perf_event.c +21 -1
@@ -123,6 +123,21 @@ static const unsigned armv8_a73_perf_cache_map[PERF_COUNT_HW_CACHE_MAX] [C(L1D)][C(OP_WRITE)][C(RESULT_ACCESS)] = ARMV8_IMPDEF_PERFCTR_L1D_CACHE_WR, }; +static const unsigned armv8_a75_perf_cache_map[PERF_COUNT_HW_CACHE_MAX ] + [PERF_COUNT_HW_CACHE_OP_MAX ] + [PERF_COUNT_HW_CACHE_RESULT_MAX ] = { +PERF_CACHE_MAP_ALL_UNSUPPORTED , + + [C (L1D )][C (OP_READ )][C (RESULT_ACCESS )] =ARMV8_IMPDEF_PERFCTR_L1D_CACHE_RD , + [C (L1D )][C (OP_READ )][C (RESULT_MISS )] =ARMV8_IMPDEF_PERFCTR_L1D_CACHE_REFILL_RD , + [C (L1D )][C (OP_WRITE )][C (RESULT_ACCESS )] =ARMV8_IMPDEF_PERFCTR_L1D_CACHE_WR , + [C (L1D )][C (OP_WRITE )][C (RESULT_MISS )] =ARMV8_IMPDEF_PERFCTR_L1D_CACHE_REFILL_WR , + + + [C (NODE )][C (OP_READ )][C (RESULT_ACCESS )] =ARMV8_IMPDEF_PERFCTR_BUS_ACCESS_RD , + [C (NODE )][C (OP_WRITE )][C (RESULT_ACCESS )] =ARMV8_IMPDEF_PERFCTR_BUS_ACCESS_WR , +}; +static const unsigned armv8_thunder_perf_cache_map[PERF_COUNT_HW_CACHE_MAX ] [PERF_COUNT_HW_CACHE_OP_MAX ] [PERF_COUNT_HW_CACHE_RESULT_MAX ] = {
@@ -940,6 +955,11 @@ static int armv8_a73_map_event(struct perf_event *event)return __armv8_pmuv3_map_event (event,NULL , &armv8_a73_perf_cache_map); } +static int armv8_a75_map_event (struct perf_event *event) +{ +return __armv8_pmuv3_map_event (event,NULL , &armv8_a75_perf_cache_map); +} +static int armv8_thunder_map_event (struct perf_event *event) { return __armv8_pmuv3_map_event(event, NULL,
@@ -1101,7 +1121,7 @@ static int armv8_a73_pmu_init(struct arm_pmu *cpu_pmu)static int armv8_a75_pmu_init (struct arm_pmu *cpu_pmu) {return armv8_pmu_init (cpu_pmu,"armv8_cortex_a75" , - armv8_pmuv3_map_event,NULL ,NULL ); + armv8_a75_map_event,NULL ,NULL ); }static int armv8_a76_pmu_init (struct arm_pmu *cpu_pmu)
Signature · 1 line
2.27.0
PATCH 3/3 arm64: perf: add support for Cortex-A76
In reply to Jisheng ZhangThe Cortex-A76 uses some implementation defined perf events. Per Cortex-A76 TRM r4p0, section C2.3 PMU Events (pages C2-386 to C2-394), we can reuse Cortex-A57's perf events mapping currently.
--- arch/arm64/kernel/perf_event.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/kernel/perf_event.c +1 -1
@@ -1127,7 +1127,7 @@ static int armv8_a75_pmu_init(struct arm_pmu *cpu_pmu)static int armv8_a76_pmu_init (struct arm_pmu *cpu_pmu) {return armv8_pmu_init (cpu_pmu,"armv8_cortex_a76" , - armv8_pmuv3_map_event,NULL ,NULL ); + armv8_a57_map_event,NULL ,NULL ); }static int armv8_a77_pmu_init (struct arm_pmu *cpu_pmu)
Signature · 1 line
2.27.0
Will Deacon
maintainerQuoted 10 lines · Jisheng Zhang
The Cortex-A55/A75/A76 use some implementation defined perf events. Add the support.
Jisheng Zhang (3):
arm64: perf: add support for Cortex-A55
arm64: perf: add support for Cortex-A75
arm64: perf: add support for Cortex-A76arch/arm64/kernel/perf_event.c | 49 +++++++++++++++++++++++++++++++--- 1 file changed, 45 insertions(+), 4 deletions(-)
Do we really need this? I'd prefer for this stuff to live in userspace now that the perf tool has supported JSON event descriptions for a while, and the in-kernel driver advertises the architected events advertised by PMCEID*.
Will
Hi Will,
Quoted 11 lines · On Fri, 3 Jul 2020 13:33:47 +0100 Will Deacon wrote:
Quoted 8 lines · Jisheng Zhang
The Cortex-A55/A75/A76 use some implementation defined perf events. Add the support.
Jisheng Zhang (3):
arm64: perf: add support for Cortex-A55
arm64: perf: add support for Cortex-A75
arm64: perf: add support for Cortex-A76
Quoted 4 lines
Quoted 2 lines
arch/arm64/kernel/perf_event.c | 49 +++++++++++++++++++++++++++++++--- 1 file changed, 45 insertions(+), 4 deletions(-)Do we really need this? I'd prefer for this stuff to live in userspace
IMHO, this stuff is to add a relationship between linux standard HW events and ARM PMU events, take CA55 for example:
w/o the stuff, perf -e PREFETCH_LINEFILL
w/ the stuff, perf -e L1-dcache-prefetch-misses
But indeed, we also need to add json descriptions in perf tool, I'll submit patches.
Thanks
Quoted 5 lines
now that the perf tool has supported JSON event descriptions for a while, and the in-kernel driver advertises the architected events advertised by PMCEID*.
Will