nvdimm/region: Use struct_size() in kzalloc()
PATCH 1/1 nvdimm/region: Use struct_size() in kzalloc()
Make use of the struct_size() helper instead of an open-coded version in order to avoid any potential type mistakes.
This issue was found with the help of Coccinelle and, audited and fixed manually.
Addresses-KSPP-ID: https://github.com/KSPP/linux/issues/83
Signed-off-by Gustavo A. R. Silva <[email protected]>
--- drivers/nvdimm/region_devs.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/nvdimm/region_devs.c +1 -2
@@ -1063,8 +1063,7 @@ static struct nd_region *nd_region_create(struct nvdimm_bus *nvdimm_bus,struct nd_blk_region *ndbr; ndbr_desc =to_blk_region_desc (ndr_desc); - ndbr =kzalloc (sizeof (*ndbr) +sizeof (struct nd_mapping ) - * ndr_desc->num_mappings, + ndbr =kzalloc (struct_size (ndbr, nd_region.mapping, ndr_desc->num_mappings),GFP_KERNEL );if (ndbr) { nd_region = &ndbr->nd_region;
Signature · 1 line
2.27.0
Quoted 8 lines · Gustavo A. R. Silva
Make use of the
struct_size()helper instead of an open-coded version in order to avoid any potential type mistakes.This issue was found with the help of Coccinelle and, audited and fixed manually.
Addresses-KSPP-ID: https://github.com/KSPP/linux/issues/83
Signed-off-by Gustavo A. R. Silva <[email protected]>
Reviewed-by Ira Weiny <[email protected]>
Quoted 21 lines
--- drivers/nvdimm/region_devs.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)drivers/nvdimm/region_devs.c +1
-2@@ -1063,8 +1063,7 @@ static struct nd_region *nd_region_create(struct nvdimm_bus *nvdimm_bus,struct nd_blk_region *ndbr; ndbr_desc =to_blk_region_desc (ndr_desc); - ndbr =kzalloc (sizeof (*ndbr) +sizeof (struct nd_mapping ) - * ndr_desc->num_mappings, + ndbr =kzalloc (struct_size (ndbr, nd_region.mapping, ndr_desc->num_mappings),GFP_KERNEL );if (ndbr) { nd_region = &ndbr->nd_region;Signature · 1 line
2.27.0
_______________________________________________
Linux-nvdimm mailing list -- [email protected] To unsubscribe send an email to [email protected]