drm/amd: fix potential memleak in err branch
Subsystems (3)
PATCH v3 1/1 drm/amd: fix potential memleak in err branch
The function kobject_init_and_add alloc memory like:kobject_init_and_add->kobject_add_varg->kobject_set_name_vargs ->kvasprintf_const->kstrdup_const->kstrdup->kmalloc_track_caller ->kmalloc_slab, in err branch this memory not free. If use kmemleak, this path maybe catched.
These changes are to add kobject_put in kobject_init_and_add failed branch, fix potential memleak.
Signed-off-by Bernard Zhao <[email protected]>
---
Changes since V2:
*remove duplicate kobject_put in kfd_procfs_init.
Link for V1:
*https://lore.kernel.org/patchwork/patch/1258608/
--- drivers/gpu/drm/amd/amdkfd/kfd_process.c | 1 + 1 file changed, 1 insertion(+)
drivers/gpu/drm/amd/amdkfd/kfd_process.c +1 -0
@@ -428,6 +428,7 @@ struct kfd_process *kfd_create_process(struct file *filep) (int)process->lead_thread->pid);if (ret) {pr_warn ("Creating procfs pid directory failed" ); +kobject_put (process->kobj); goto out; }
Signature · 1 line
2.17.1