Cosmetic cleanup in SJA1105 DSA driver
Vladimir Oltean
maintainercover Cosmetic cleanup in SJA1105 DSA driver
From: Vladimir Oltean <[email protected]>
This removes the sparse warnings from the sja1105 driver and makes some structures constant.
Vladimir Oltean (3):
net: dsa: sja1105: remove empty structures from config table ops
net: dsa: sja1105: make config table operation structures constant
net: dsa: sja1105: make the instantiations of struct sja1105_info
constant
drivers/net/dsa/sja1105/sja1105.h | 12 +++---- .../net/dsa/sja1105/sja1105_dynamic_config.c | 25 ++----------- .../net/dsa/sja1105/sja1105_dynamic_config.h | 4 +-- drivers/net/dsa/sja1105/sja1105_spi.c | 17 +++++---- .../net/dsa/sja1105/sja1105_static_config.c | 36 ++++--------------- .../net/dsa/sja1105/sja1105_static_config.h | 12 +++---- 6 files changed, 33 insertions(+), 73 deletions(-)
Signature · 1 line
2.25.1
Vladimir Oltean
maintainerPATCH 1/3 net: dsa: sja1105: remove empty structures from config table ops
From: Vladimir Oltean <[email protected]>
Sparse is complaining and giving the following warning message:
'Using plain integer as NULL pointer'.
This is not what's going on, instead {0} is used as a zero initializer for the structure members, to indicate that the particular chip revision does not support those particular config tables.
But since the config tables are declared globally, the unpopulated elements are zero-initialized anyway. So, to make sparse shut up, let's remove the zero initializers.
--- .../net/dsa/sja1105/sja1105_dynamic_config.c | 21 ---------------- .../net/dsa/sja1105/sja1105_static_config.c | 24 ------------------- 2 files changed, 45 deletions(-)
drivers/net/dsa/sja1105/sja1105_dynamic_config.c +0 -21
@@ -639,8 +639,6 @@ static size_t sja1105pqrs_cbs_entry_packing(void *buf, void *entry_ptr,/* SJA1105E/T: First generation */ struct sja1105_dynamic_table_ops sja1105et_dyn_ops[BLK_IDX_MAX_DYN ] = { - [BLK_IDX_SCHEDULE ] = {0 }, - [BLK_IDX_SCHEDULE_ENTRY_POINTS ] = {0 }, [BLK_IDX_VL_LOOKUP ] = { .entry_packing = sja1105et_vl_lookup_entry_packing, .cmd_packing = sja1105_vl_lookup_cmd_packing,
@@ -649,8 +647,6 @@ struct sja1105_dynamic_table_ops sja1105et_dyn_ops[BLK_IDX_MAX_DYN] = { .packed_size = SJA1105ET_SJA1105_SIZE_VL_LOOKUP_DYN_CMD, .addr = 0x35, }, - [BLK_IDX_VL_POLICING] = {0}, - [BLK_IDX_VL_FORWARDING] = {0}, [BLK_IDX_L2_LOOKUP] = { .entry_packing = sja1105et_dyn_l2_lookup_entry_packing, .cmd_packing = sja1105et_l2_lookup_cmd_packing,
@@ -667,7 +663,6 @@ struct sja1105_dynamic_table_ops sja1105et_dyn_ops[BLK_IDX_MAX_DYN] = { .packed_size = SJA1105ET_SIZE_L2_LOOKUP_DYN_CMD, .addr = 0x20, }, - [BLK_IDX_L2_POLICING] = {0}, [BLK_IDX_VLAN_LOOKUP] = { .entry_packing = sja1105_vlan_lookup_entry_packing, .cmd_packing = sja1105_vlan_lookup_cmd_packing,
@@ -692,9 +687,6 @@ struct sja1105_dynamic_table_ops sja1105et_dyn_ops[BLK_IDX_MAX_DYN] = { .packed_size = SJA1105ET_SIZE_MAC_CONFIG_DYN_CMD, .addr = 0x36, }, - [BLK_IDX_SCHEDULE_PARAMS] = {0}, - [BLK_IDX_SCHEDULE_ENTRY_POINTS_PARAMS] = {0}, - [BLK_IDX_VL_FORWARDING_PARAMS] = {0}, [BLK_IDX_L2_LOOKUP_PARAMS] = { .entry_packing = sja1105et_l2_lookup_params_entry_packing, .cmd_packing = sja1105et_l2_lookup_params_cmd_packing,
@@ -703,8 +695,6 @@ struct sja1105_dynamic_table_ops sja1105et_dyn_ops[BLK_IDX_MAX_DYN] = { .packed_size = SJA1105ET_SIZE_L2_LOOKUP_PARAMS_DYN_CMD, .addr = 0x38, }, - [BLK_IDX_L2_FORWARDING_PARAMS] = {0}, - [BLK_IDX_AVB_PARAMS] = {0}, [BLK_IDX_GENERAL_PARAMS] = { .entry_packing = sja1105et_general_params_entry_packing, .cmd_packing = sja1105et_general_params_cmd_packing,
@@ -729,13 +719,10 @@ struct sja1105_dynamic_table_ops sja1105et_dyn_ops[BLK_IDX_MAX_DYN] = { .packed_size = SJA1105ET_SIZE_CBS_DYN_CMD, .addr = 0x2c, }, - [BLK_IDX_XMII_PARAMS] = {0}, };/* SJA1105P/Q/R/S: Second generation */ struct sja1105_dynamic_table_ops sja1105pqrs_dyn_ops[BLK_IDX_MAX_DYN ] = { - [BLK_IDX_SCHEDULE] = {0}, - [BLK_IDX_SCHEDULE_ENTRY_POINTS] = {0}, [BLK_IDX_VL_LOOKUP ] = { .entry_packing = sja1105_vl_lookup_entry_packing, .cmd_packing = sja1105_vl_lookup_cmd_packing,
@@ -744,8 +731,6 @@ struct sja1105_dynamic_table_ops sja1105pqrs_dyn_ops[BLK_IDX_MAX_DYN] = { .packed_size = SJA1105PQRS_SJA1105_SIZE_VL_LOOKUP_DYN_CMD, .addr = 0x47, }, - [BLK_IDX_VL_POLICING] = {0}, - [BLK_IDX_VL_FORWARDING] = {0}, [BLK_IDX_L2_LOOKUP] = { .entry_packing = sja1105pqrs_dyn_l2_lookup_entry_packing, .cmd_packing = sja1105pqrs_l2_lookup_cmd_packing,
@@ -762,7 +747,6 @@ struct sja1105_dynamic_table_ops sja1105pqrs_dyn_ops[BLK_IDX_MAX_DYN] = { .packed_size = SJA1105PQRS_SIZE_L2_LOOKUP_DYN_CMD, .addr = 0x24, }, - [BLK_IDX_L2_POLICING] = {0}, [BLK_IDX_VLAN_LOOKUP] = { .entry_packing = sja1105_vlan_lookup_entry_packing, .cmd_packing = sja1105_vlan_lookup_cmd_packing,
@@ -787,9 +771,6 @@ struct sja1105_dynamic_table_ops sja1105pqrs_dyn_ops[BLK_IDX_MAX_DYN] = { .packed_size = SJA1105PQRS_SIZE_MAC_CONFIG_DYN_CMD, .addr = 0x4B, }, - [BLK_IDX_SCHEDULE_PARAMS] = {0}, - [BLK_IDX_SCHEDULE_ENTRY_POINTS_PARAMS] = {0}, - [BLK_IDX_VL_FORWARDING_PARAMS] = {0}, [BLK_IDX_L2_LOOKUP_PARAMS] = { .entry_packing = sja1105pqrs_l2_lookup_params_entry_packing, .cmd_packing = sja1105pqrs_l2_lookup_params_cmd_packing,
@@ -798,7 +779,6 @@ struct sja1105_dynamic_table_ops sja1105pqrs_dyn_ops[BLK_IDX_MAX_DYN] = { .packed_size = SJA1105PQRS_SIZE_L2_LOOKUP_PARAMS_DYN_CMD, .addr = 0x54, }, - [BLK_IDX_L2_FORWARDING_PARAMS] = {0}, [BLK_IDX_AVB_PARAMS] = { .entry_packing = sja1105pqrs_avb_params_entry_packing, .cmd_packing = sja1105pqrs_avb_params_cmd_packing,
@@ -831,7 +811,6 @@ struct sja1105_dynamic_table_ops sja1105pqrs_dyn_ops[BLK_IDX_MAX_DYN] = { .packed_size = SJA1105PQRS_SIZE_CBS_DYN_CMD, .addr = 0x32, }, - [BLK_IDX_XMII_PARAMS] = {0}, };/* Provides read access to the settings through the dynamic interface
drivers/net/dsa/sja1105/sja1105_static_config.c +0 -24
@@ -839,11 +839,6 @@ sja1105_static_config_get_length(const struct sja1105_static_config *config)/* SJA1105E: First generation, no TTEthernet */ struct sja1105_table_ops sja1105e_table_ops[BLK_IDX_MAX ] = { - [BLK_IDX_SCHEDULE ] = {0 }, - [BLK_IDX_SCHEDULE_ENTRY_POINTS ] = {0 }, - [BLK_IDX_VL_LOOKUP ] = {0 }, - [BLK_IDX_VL_POLICING ] = {0 }, - [BLK_IDX_VL_FORWARDING ] = {0 }, [BLK_IDX_L2_LOOKUP ] = { .packing = sja1105et_l2_lookup_entry_packing, .unpacked_entry_size =sizeof (struct sja1105_l2_lookup_entry ),
@@ -874,9 +869,6 @@ struct sja1105_table_ops sja1105e_table_ops[BLK_IDX_MAX] = { .packed_entry_size = SJA1105ET_SIZE_MAC_CONFIG_ENTRY, .max_entry_count = SJA1105_MAX_MAC_CONFIG_COUNT, }, - [BLK_IDX_SCHEDULE_PARAMS] = {0}, - [BLK_IDX_SCHEDULE_ENTRY_POINTS_PARAMS] = {0}, - [BLK_IDX_VL_FORWARDING_PARAMS] = {0}, [BLK_IDX_L2_LOOKUP_PARAMS] = { .packing = sja1105et_l2_lookup_params_entry_packing, .unpacked_entry_size = sizeof(struct sja1105_l2_lookup_params_entry),
@@ -1035,11 +1027,6 @@ struct sja1105_table_ops sja1105t_table_ops[BLK_IDX_MAX] = {/* SJA1105P: Second generation, no TTEthernet, no SGMII */ struct sja1105_table_ops sja1105p_table_ops[BLK_IDX_MAX ] = { - [BLK_IDX_SCHEDULE ] = {0 }, - [BLK_IDX_SCHEDULE_ENTRY_POINTS ] = {0 }, - [BLK_IDX_VL_LOOKUP ] = {0 }, - [BLK_IDX_VL_POLICING ] = {0 }, - [BLK_IDX_VL_FORWARDING ] = {0 }, [BLK_IDX_L2_LOOKUP ] = { .packing = sja1105pqrs_l2_lookup_entry_packing, .unpacked_entry_size =sizeof (struct sja1105_l2_lookup_entry ),
@@ -1070,9 +1057,6 @@ struct sja1105_table_ops sja1105p_table_ops[BLK_IDX_MAX] = { .packed_entry_size = SJA1105PQRS_SIZE_MAC_CONFIG_ENTRY, .max_entry_count = SJA1105_MAX_MAC_CONFIG_COUNT, }, - [BLK_IDX_SCHEDULE_PARAMS] = {0}, - [BLK_IDX_SCHEDULE_ENTRY_POINTS_PARAMS] = {0}, - [BLK_IDX_VL_FORWARDING_PARAMS] = {0}, [BLK_IDX_L2_LOOKUP_PARAMS] = { .packing = sja1105pqrs_l2_lookup_params_entry_packing, .unpacked_entry_size = sizeof(struct sja1105_l2_lookup_params_entry),
@@ -1231,11 +1215,6 @@ struct sja1105_table_ops sja1105q_table_ops[BLK_IDX_MAX] = {/* SJA1105R: Second generation, no TTEthernet, SGMII */ struct sja1105_table_ops sja1105r_table_ops[BLK_IDX_MAX ] = { - [BLK_IDX_SCHEDULE ] = {0 }, - [BLK_IDX_SCHEDULE_ENTRY_POINTS ] = {0 }, - [BLK_IDX_VL_LOOKUP ] = {0 }, - [BLK_IDX_VL_POLICING ] = {0 }, - [BLK_IDX_VL_FORWARDING ] = {0 }, [BLK_IDX_L2_LOOKUP ] = { .packing = sja1105pqrs_l2_lookup_entry_packing, .unpacked_entry_size =sizeof (struct sja1105_l2_lookup_entry ),
@@ -1266,9 +1245,6 @@ struct sja1105_table_ops sja1105r_table_ops[BLK_IDX_MAX] = { .packed_entry_size = SJA1105PQRS_SIZE_MAC_CONFIG_ENTRY, .max_entry_count = SJA1105_MAX_MAC_CONFIG_COUNT, }, - [BLK_IDX_SCHEDULE_PARAMS] = {0}, - [BLK_IDX_SCHEDULE_ENTRY_POINTS_PARAMS] = {0}, - [BLK_IDX_VL_FORWARDING_PARAMS] = {0}, [BLK_IDX_L2_LOOKUP_PARAMS] = { .packing = sja1105pqrs_l2_lookup_params_entry_packing, .unpacked_entry_size = sizeof(struct sja1105_l2_lookup_params_entry),
Signature · 1 line
2.25.1
Vladimir Oltean
maintainerPATCH 2/3 net: dsa: sja1105: make config table operation structures constant
In reply to Vladimir OlteanFrom: Vladimir Oltean <[email protected]>
The per-chip instantiations of struct sja1105_table_ops and struct sja1105_dynamic_table_ops can be made constant, so do that.
--- drivers/net/dsa/sja1105/sja1105_dynamic_config.c | 4 ++-- drivers/net/dsa/sja1105/sja1105_dynamic_config.h | 4 ++-- drivers/net/dsa/sja1105/sja1105_static_config.c | 12 ++++++------ drivers/net/dsa/sja1105/sja1105_static_config.h | 12 ++++++------ 4 files changed, 16 insertions(+), 16 deletions(-)
drivers/net/dsa/sja1105/sja1105_dynamic_config.c +2 -2
@@ -638,7 +638,7 @@ static size_t sja1105pqrs_cbs_entry_packing(void *buf, void *entry_ptr,#define OP_SEARCH BIT(3)/* SJA1105E/T: First generation */ -struct sja1105_dynamic_table_ops sja1105et_dyn_ops[BLK_IDX_MAX_DYN ] = { +const struct sja1105_dynamic_table_ops sja1105et_dyn_ops[BLK_IDX_MAX_DYN ] = { [BLK_IDX_VL_LOOKUP ] = { .entry_packing = sja1105et_vl_lookup_entry_packing, .cmd_packing = sja1105_vl_lookup_cmd_packing,
@@ -722,7 +722,7 @@ struct sja1105_dynamic_table_ops sja1105et_dyn_ops[BLK_IDX_MAX_DYN] = { };/* SJA1105P/Q/R/S: Second generation */ -struct sja1105_dynamic_table_ops sja1105pqrs_dyn_ops[BLK_IDX_MAX_DYN ] = { +const struct sja1105_dynamic_table_ops sja1105pqrs_dyn_ops[BLK_IDX_MAX_DYN ] = { [BLK_IDX_VL_LOOKUP ] = { .entry_packing = sja1105_vl_lookup_entry_packing, .cmd_packing = sja1105_vl_lookup_cmd_packing,
drivers/net/dsa/sja1105/sja1105_dynamic_config.h +2 -2
@@ -34,7 +34,7 @@ struct sja1105_mgmt_entry { u64 index; }; -extern struct sja1105_dynamic_table_ops sja1105et_dyn_ops[BLK_IDX_MAX_DYN ]; -extern struct sja1105_dynamic_table_ops sja1105pqrs_dyn_ops[BLK_IDX_MAX_DYN ]; +extern const struct sja1105_dynamic_table_ops sja1105et_dyn_ops[BLK_IDX_MAX_DYN ]; +extern const struct sja1105_dynamic_table_ops sja1105pqrs_dyn_ops[BLK_IDX_MAX_DYN ];#endif
drivers/net/dsa/sja1105/sja1105_static_config.c +6 -6
@@ -838,7 +838,7 @@ sja1105_static_config_get_length(const struct sja1105_static_config *config)/* Compatibility matrices */ /* SJA1105E: First generation, no TTEthernet */ -struct sja1105_table_ops sja1105e_table_ops[BLK_IDX_MAX ] = { +const struct sja1105_table_ops sja1105e_table_ops[BLK_IDX_MAX ] = { [BLK_IDX_L2_LOOKUP ] = { .packing = sja1105et_l2_lookup_entry_packing, .unpacked_entry_size =sizeof (struct sja1105_l2_lookup_entry ),
@@ -908,7 +908,7 @@ struct sja1105_table_ops sja1105e_table_ops[BLK_IDX_MAX] = { };/* SJA1105T: First generation, TTEthernet */ -struct sja1105_table_ops sja1105t_table_ops[BLK_IDX_MAX ] = { +const struct sja1105_table_ops sja1105t_table_ops[BLK_IDX_MAX ] = { [BLK_IDX_SCHEDULE ] = { .packing = sja1105_schedule_entry_packing, .unpacked_entry_size =sizeof (struct sja1105_schedule_entry ),
@@ -1026,7 +1026,7 @@ struct sja1105_table_ops sja1105t_table_ops[BLK_IDX_MAX] = { };/* SJA1105P: Second generation, no TTEthernet, no SGMII */ -struct sja1105_table_ops sja1105p_table_ops[BLK_IDX_MAX ] = { +const struct sja1105_table_ops sja1105p_table_ops[BLK_IDX_MAX ] = { [BLK_IDX_L2_LOOKUP ] = { .packing = sja1105pqrs_l2_lookup_entry_packing, .unpacked_entry_size =sizeof (struct sja1105_l2_lookup_entry ),
@@ -1096,7 +1096,7 @@ struct sja1105_table_ops sja1105p_table_ops[BLK_IDX_MAX] = { };/* SJA1105Q: Second generation, TTEthernet, no SGMII */ -struct sja1105_table_ops sja1105q_table_ops[BLK_IDX_MAX ] = { +const struct sja1105_table_ops sja1105q_table_ops[BLK_IDX_MAX ] = { [BLK_IDX_SCHEDULE ] = { .packing = sja1105_schedule_entry_packing, .unpacked_entry_size =sizeof (struct sja1105_schedule_entry ),
@@ -1214,7 +1214,7 @@ struct sja1105_table_ops sja1105q_table_ops[BLK_IDX_MAX] = { };/* SJA1105R: Second generation, no TTEthernet, SGMII */ -struct sja1105_table_ops sja1105r_table_ops[BLK_IDX_MAX ] = { +const struct sja1105_table_ops sja1105r_table_ops[BLK_IDX_MAX ] = { [BLK_IDX_L2_LOOKUP ] = { .packing = sja1105pqrs_l2_lookup_entry_packing, .unpacked_entry_size =sizeof (struct sja1105_l2_lookup_entry ),
@@ -1284,7 +1284,7 @@ struct sja1105_table_ops sja1105r_table_ops[BLK_IDX_MAX] = { };/* SJA1105S: Second generation, TTEthernet, SGMII */ -struct sja1105_table_ops sja1105s_table_ops[BLK_IDX_MAX ] = { +const struct sja1105_table_ops sja1105s_table_ops[BLK_IDX_MAX ] = { [BLK_IDX_SCHEDULE ] = { .packing = sja1105_schedule_entry_packing, .unpacked_entry_size =sizeof (struct sja1105_schedule_entry ),
drivers/net/dsa/sja1105/sja1105_static_config.h +6 -6
@@ -381,12 +381,12 @@ struct sja1105_static_config {struct sja1105_table tables[BLK_IDX_MAX ]; }; -extern struct sja1105_table_ops sja1105e_table_ops[BLK_IDX_MAX ]; -extern struct sja1105_table_ops sja1105t_table_ops[BLK_IDX_MAX ]; -extern struct sja1105_table_ops sja1105p_table_ops[BLK_IDX_MAX ]; -extern struct sja1105_table_ops sja1105q_table_ops[BLK_IDX_MAX ]; -extern struct sja1105_table_ops sja1105r_table_ops[BLK_IDX_MAX ]; -extern struct sja1105_table_ops sja1105s_table_ops[BLK_IDX_MAX ]; +extern const struct sja1105_table_ops sja1105e_table_ops[BLK_IDX_MAX ]; +extern const struct sja1105_table_ops sja1105t_table_ops[BLK_IDX_MAX ]; +extern const struct sja1105_table_ops sja1105p_table_ops[BLK_IDX_MAX ]; +extern const struct sja1105_table_ops sja1105q_table_ops[BLK_IDX_MAX ]; +extern const struct sja1105_table_ops sja1105r_table_ops[BLK_IDX_MAX ]; +extern const struct sja1105_table_ops sja1105s_table_ops[BLK_IDX_MAX ];size_t sja1105_table_header_packing (void *buf,void *hdr,enum packing_op op);void
Signature · 1 line
2.25.1
Vladimir Oltean
maintainerPATCH 3/3 net: dsa: sja1105: make the instantiations of struct sja1105_info constant
In reply to Vladimir OlteanFrom: Vladimir Oltean <[email protected]>
Since struct sja1105_private only holds a const pointer to one of these structures based on device tree compatible string, the structures themselves can be made const.
Also add an empty line between each structure definition, to appease checkpatch.
--- drivers/net/dsa/sja1105/sja1105.h | 12 ++++++------ drivers/net/dsa/sja1105/sja1105_spi.c | 17 +++++++++++------ 2 files changed, 17 insertions(+), 12 deletions(-)
drivers/net/dsa/sja1105/sja1105.h +6 -6
@@ -262,12 +262,12 @@ int sja1105_static_config_upload(struct sja1105_private *priv);int sja1105_inhibit_tx (const struct sja1105_private *priv,unsigned long port_bitmap,bool tx_inhibited); -extern struct sja1105_info sja1105e_info; -extern struct sja1105_info sja1105t_info; -extern struct sja1105_info sja1105p_info; -extern struct sja1105_info sja1105q_info; -extern struct sja1105_info sja1105r_info; -extern struct sja1105_info sja1105s_info; +extern const struct sja1105_info sja1105e_info; +extern const struct sja1105_info sja1105t_info; +extern const struct sja1105_info sja1105p_info; +extern const struct sja1105_info sja1105q_info; +extern const struct sja1105_info sja1105r_info; +extern const struct sja1105_info sja1105s_info;/* From sja1105_clocking.c */
drivers/net/dsa/sja1105/sja1105_spi.c +11 -6
@@ -507,7 +507,7 @@ static struct sja1105_regs sja1105pqrs_regs = { .ptpsyncts = 0x1F, }; -struct sja1105_info sja1105e_info = { +const struct sja1105_info sja1105e_info = { .device_id =SJA1105E_DEVICE_ID , .part_no =SJA1105ET_PART_NO , .static_ops = sja1105e_table_ops,
@@ -523,7 +523,8 @@ struct sja1105_info sja1105e_info = { .regs = &sja1105et_regs, .name = "SJA1105E", }; -struct sja1105_info sja1105t_info = { + +const struct sja1105_info sja1105t_info = { .device_id =SJA1105T_DEVICE_ID , .part_no =SJA1105ET_PART_NO , .static_ops = sja1105t_table_ops,
@@ -539,7 +540,8 @@ struct sja1105_info sja1105t_info = { .regs = &sja1105et_regs, .name = "SJA1105T", }; -struct sja1105_info sja1105p_info = { + +const struct sja1105_info sja1105p_info = { .device_id =SJA1105PR_DEVICE_ID , .part_no =SJA1105P_PART_NO , .static_ops = sja1105p_table_ops,
@@ -556,7 +558,8 @@ struct sja1105_info sja1105p_info = { .regs = &sja1105pqrs_regs, .name = "SJA1105P", }; -struct sja1105_info sja1105q_info = { + +const struct sja1105_info sja1105q_info = { .device_id =SJA1105QS_DEVICE_ID , .part_no =SJA1105Q_PART_NO , .static_ops = sja1105q_table_ops,
@@ -573,7 +576,8 @@ struct sja1105_info sja1105q_info = { .regs = &sja1105pqrs_regs, .name = "SJA1105Q", }; -struct sja1105_info sja1105r_info = { + +const struct sja1105_info sja1105r_info = { .device_id =SJA1105PR_DEVICE_ID , .part_no =SJA1105R_PART_NO , .static_ops = sja1105r_table_ops,
@@ -590,7 +594,8 @@ struct sja1105_info sja1105r_info = { .regs = &sja1105pqrs_regs, .name = "SJA1105R", }; -struct sja1105_info sja1105s_info = { + +const struct sja1105_info sja1105s_info = { .device_id =SJA1105QS_DEVICE_ID , .part_no =SJA1105S_PART_NO , .static_ops = sja1105s_table_ops,
Signature · 1 line
2.25.1
Jakub Kicinski
maintainerQuoted 4 lines · On Sat, 20 Jun 2020 20:18:29 +0300 Vladimir Oltean wrote:
From: Vladimir Oltean <[email protected]>
This removes the sparse warnings from the sja1105 driver and makes some structures constant.
Errors and warnings before: 526 this patch: 0
Whoop!
David Miller
maintainerFrom: Vladimir Oltean <[email protected]>
Date: Sat, 20 Jun 2020 20:18:29 +0300
Quoted 4 lines
From: Vladimir Oltean <[email protected]>
This removes the sparse warnings from the sja1105 driver and makes some structures constant.
Series applied, thanks.