vfio: fix resource leak when mapping fails
PATCH 1/1 vfio: fix resource leak when mapping fails
Currently, only the 'vfio_dev_fd' is closed in failure path, so some resources are not released(such as 'vfio_group_fd'). The rte_vfio_release_device() should be used to avoid this problem.
--- drivers/bus/pci/linux/pci_vfio.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/bus/pci/linux/pci_vfio.c +4 -2
@@ -789,7 +789,8 @@ pci_vfio_map_resource_primary(struct rte_pci_device *dev) err_vfio_res:rte_free (vfio_res); err_vfio_dev_fd: -close (vfio_dev_fd); +rte_vfio_release_device (rte_pci_get_sysfs_path (), + pci_addr, vfio_dev_fd);return -1 ; }
@@ -857,7 +858,8 @@ pci_vfio_map_resource_secondary(struct rte_pci_device *dev)return 0 ; err_vfio_dev_fd: -close (vfio_dev_fd); +rte_vfio_release_device (rte_pci_get_sysfs_path (), + pci_addr, vfio_dev_fd);return -1 ; }
Signature · 1 line
2.18.1
PATCH RESEND v2 1/1 vfio: fix resource leak when mapping fails
From: Yunjian Wang <[email protected]>
Currently, only the 'vfio_dev_fd' is closed in failure path, so some resources are not released(such as 'vfio_group_fd'). The rte_vfio_release_device() should be used to avoid this problem.
---
v2:
Update email address
--- drivers/bus/pci/linux/pci_vfio.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/bus/pci/linux/pci_vfio.c +4 -2
@@ -826,7 +826,8 @@ pci_vfio_map_resource_primary(struct rte_pci_device *dev) err_vfio_res:rte_free (vfio_res); err_vfio_dev_fd: -close (vfio_dev_fd); +rte_vfio_release_device (rte_pci_get_sysfs_path (), + pci_addr, vfio_dev_fd);return -1 ; }
@@ -894,7 +895,8 @@ pci_vfio_map_resource_secondary(struct rte_pci_device *dev)return 0 ; err_vfio_dev_fd: -close (vfio_dev_fd); +rte_vfio_release_device (rte_pci_get_sysfs_path (), + pci_addr, vfio_dev_fd);return -1 ; }
Signature · 1 line
2.23.0
Quoted 11 lines · wangyunjian
From: Yunjian Wang <[email protected]>
Currently, only the '
vfio_dev_fd' is closed in failure path, so some resources are notreleased(such as 'vfio_group_fd'). Therte_vfio_release_device()should be used to avoid this problem.Fixes 33604c31354a ("vfio: refactor PCI BAR mapping")Signed-off-by Yunjian Wang <[email protected]>---
Signature · 2 lines
Thanks, Anatoly
Quoted 11 lines · wangyunjian
From: Yunjian Wang <[email protected]>
Currently, only the '
vfio_dev_fd' is closed in failure path, so some resources are notreleased(such as 'vfio_group_fd'). Therte_vfio_release_device()should be used to avoid this problem.Fixes 33604c31354a ("vfio: refactor PCI BAR mapping")Signed-off-by Yunjian Wang <[email protected]>
Applied, thanks.
Signature · 1 line
David Marchand