Skip to contentSkip to conversation

xinit: add rxvt in RDEPENDS

PATCH Superseded Changqing Li 3 participants 3 messages Jun 22, 2020

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 xinit: add rxvt in RDEPENDS

From: Changqing Li <[email protected]>

fix below error:
/etc/X11/xinit/xinitrc: line 55: exec: xterm: not found

by default, xinit will generate /etc/X11/xinit/xinitrc, and have below config in it:
XTERM -geometry 80x50+494+51 &
XTERM -geometry 80x20+494-0 &
exec XTERM -geometry 80x66+0+0 -name login

the default XTERM is xterm, but xterm is in meta-oe, use rxvt instead

---
 meta/recipes-graphics/xorg-app/xinit_1.4.1.bb | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
meta/recipes-graphics/xorg-app/xinit_1.4.1.bb +4 -1
index c9e28d9bba..2f2ba3af71 100644
@@ -19,4 +19,7 @@ SRC_URI[sha256sum] = "de9b8f617b68a70f6caf87da01fcf0ebd2b75690cdcba9c921d0ef54fa
 
 EXTRA_OECONF = "ac_cv_path_MCOOKIE=${bindir}/mcookie"
 
-RDEPENDS_${PN} += "util-linux-mcookie"
+PACKAGECONFIG ??= "xterm"
+PACKAGECONFIG[xterm] = "--with-xterm=rxvt,,,"
+
+RDEPENDS_${PN} += "util-linux-mcookie rxvt-unicode"
Signature · 1 line
2.17.1
#1 lore raw
Quoted 24 lines · Changqing Li

From: Changqing Li <[email protected]>

fix below error:
/etc/X11/xinit/xinitrc: line 55: exec: xterm: not found

by default, xinit will generate /etc/X11/xinit/xinitrc, and have below config in it:
XTERM -geometry 80x50+494+51 &
XTERM -geometry 80x20+494-0 &
exec XTERM -geometry 80x66+0+0 -name login

the default XTERM is xterm, but xterm is in meta-oe, use rxvt instead

---
  meta/recipes-graphics/xorg-app/xinit_1.4.1.bb | 5 ++++-
  1 file changed, 4 insertions(+), 1 deletion(-)
meta/recipes-graphics/xorg-app/xinit_1.4.1.bb +0 -0
index c9e28d9bba..2f2ba3af71 100644

meta/recipes-graphics/xorg-app/xinit_1.4.1.bb SRC_URI[sha256sum] = "de9b8f617b68a70f6caf87da01fcf0ebd2b75690cdcba9c921d0ef54fa · line 24

Quoted 7 lines
meta/recipes-graphics/xorg-app/xinit_1.4.1.bb +3 -1
@@ -19,4 +19,7 @@ SRC_URI[sha256sum] = "de9b8f617b68a70f6caf87da01fcf0ebd2b75690cdcba9c921d0ef54fa
 
  EXTRA_OECONF = "ac_cv_path_MCOOKIE=${bindir}/mcookie"
 
-RDEPENDS_${PN} += "util-linux-mcookie"
+PACKAGECONFIG ??= "xterm"
+PACKAGECONFIG[xterm] = "--with-xterm=rxvt,,,"
+

Maybe "rxvt" would be a more suitable name for the PACKAGECONFIG ?

Jacob

#2 lore raw
Quoted 28 lines · Jacob Kroon
Quoted 27 lines · Changqing Li

From: Changqing Li <[email protected]>

fix below error:
/etc/X11/xinit/xinitrc: line 55: exec: xterm: not found

by default, xinit will generate /etc/X11/xinit/xinitrc, and have below config in it:
XTERM -geometry 80x50+494+51 &
XTERM -geometry 80x20+494-0 &
exec XTERM -geometry 80x66+0+0 -name login

the default XTERM is xterm, but xterm is in meta-oe, use rxvt instead

---
  meta/recipes-graphics/xorg-app/xinit_1.4.1.bb | 5 ++++-
  1 file changed, 4 insertions(+), 1 deletion(-)
meta/recipes-graphics/xorg-app/xinit_1.4.1.bb +0 -0
index c9e28d9bba..2f2ba3af71 100644
@@ -19,4 +19,7 @@ SRC_URI[sha256sum] =

"de9b8f617b68a70f6caf87da01fcf0ebd2b75690cdcba9c921d0ef54fa

Quoted 8 lines

meta/recipes-graphics/xorg-app/xinit_1.4.1.bb SRC_URI[sha256sum] = "de9b8f617b68a70f6caf87da01fcf0ebd2b75690cdcba9c921d0ef54fa · line 24

Quoted 6 lines
  EXTRA_OECONF = "ac_cv_path_MCOOKIE=${bindir}/mcookie"
meta/recipes-graphics/xorg-app/xinit_1.4.1.bb +3 -1
-RDEPENDS_${PN} += "util-linux-mcookie"
+PACKAGECONFIG ??= "xterm"
+PACKAGECONFIG[xterm] = "--with-xterm=rxvt,,,"
+

Maybe "rxvt" would be a more suitable name for the PACKAGECONFIG ?

Also, the RDEPENDS should be in the PACKAGECONFIG entry itself.

Cheers,

Richard