igc: Fix double definition
Subsystems (2)
PATCH 1/2 igc: Fix double definition
Accordance to the i225 specification address 0x4118 used for Host Good Packet Transmitted Count and defined as read on clear. IGC_ICTXQEC not in use and could be removed.
Signed-off-by Sasha Neftin <[email protected]>
--- drivers/net/ethernet/intel/igc/igc_mac.c | 1 - drivers/net/ethernet/intel/igc/igc_main.c | 1 - drivers/net/ethernet/intel/igc/igc_regs.h | 2 -- 3 files changed, 4 deletions(-)
drivers/net/ethernet/intel/igc/igc_mac.c +0 -1
@@ -301,7 +301,6 @@ void igc_clear_hw_cntrs_base(struct igc_hw *hw)rd32 (IGC_ICRXATC );rd32 (IGC_ICTXPTC );rd32 (IGC_ICTXATC ); -rd32 (IGC_ICTXQEC );rd32 (IGC_ICTXQMTC );rd32 (IGC_ICRXDMTC );
drivers/net/ethernet/intel/igc/igc_main.c +0 -1
@@ -3736,7 +3736,6 @@ void igc_update_stats(struct igc_adapter *adapter) adapter->stats.icrxatc +=rd32 (IGC_ICRXATC ); adapter->stats.ictxptc +=rd32 (IGC_ICTXPTC ); adapter->stats.ictxatc +=rd32 (IGC_ICTXATC ); - adapter->stats.ictxqec +=rd32 (IGC_ICTXQEC ); adapter->stats.ictxqmtc +=rd32 (IGC_ICTXQMTC ); adapter->stats.icrxdmtc +=rd32 (IGC_ICRXDMTC );
drivers/net/ethernet/intel/igc/igc_regs.h +0 -2
@@ -63,7 +63,6 @@#define IGC_ICRXATC 0x04108/* Rx Absolute Timer Expire Count */ #define IGC_ICTXPTC 0x0410C/* Tx Packet Timer Expire Count */ #define IGC_ICTXATC 0x04110/* Tx Absolute Timer Expire Count */ -#define IGC_ICTXQEC 0x04118/* Tx Queue Empty Count */ #define IGC_ICTXQMTC 0x0411C/* Tx Queue Min Threshold Count */ #define IGC_ICRXDMTC 0x04120/* Rx Descriptor Min Threshold Count */ #define IGC_ICRXOC 0x04124/* Receiver Overrun Count */
@@ -184,7 +183,6 @@#define IGC_IAC 0x04100/* Interrupt Assertion Count */ #define IGC_ICTXPTC 0x0410C/* Interrupt Cause Tx Pkt Timer Expire Count */ #define IGC_ICTXATC 0x04110/* Interrupt Cause Tx Abs Timer Expire Count */ -#define IGC_ICTXQEC 0x04118/* Interrupt Cause Tx Queue Empty Count */ #define IGC_ICTXQMTC 0x0411C/* Interrupt Cause Tx Queue Min Thresh Count */ #define IGC_RPTHC 0x04104/* Rx Packets To Host */ #define IGC_TLPIC 0x04148/* EEE Tx LPI Count */
Signature · 1 line
2.11.0
Brown
PATCH 1/2 igc: Fix double definition
Quoted 10 lines
From: Intel-wired-lan <[email protected]> On Behalf Of Sasha Neftin
Sent: Monday, June 22, 2020 12:20 AM
To: intel-wired-lan at lists.osuosl.org
Subject: [Intel-wired-lan] [PATCH v1 1/2] igc: Fix double definitionAccordance to the i225 specification address
0x4118used for Host Good Packet Transmitted Count and defined as read on clear.IGC_ICTXQECnot in use and could be removed.
Quoted 7 lines
Signed-off-by Sasha Neftin <[email protected]>--- drivers/net/ethernet/intel/igc/igc_mac.c | 1 - drivers/net/ethernet/intel/igc/igc_main.c | 1 - drivers/net/ethernet/intel/igc/igc_regs.h | 2 -- 3 files changed, 4 deletions(-)
Tested-by Aaron Brown <[email protected]>