package/libnids: new package
PATCH 1/1 package/libnids: new package
Libnids is a C based networking library, part of networking intrusion detection tools. It can watch network traffic & provide informations.
---
Hello guys, things to note about this lib
+ glic & glib2 are the main dependencies, libnet & libpcap also required, the proposed selections should take care of everything
+ running ./configure as is, leads to an internal makefile pointing to host /usr env (I don't know why). Therefore possibly pointing to host libpcap & libnet. I work this out by forcing 'prefix' & 'exec_prefix' variables with a LIBNIDS_CONF_OPTS. Maybe someone more knowledgeable will have an input
+ More info here: http://libnids.sourceforge.net/
--- DEVELOPERS | 1 + package/Config.in | 1 + package/libnids/Config.in | 19 +++++++++++++++++++ package/libnids/libnids.hash | 3 +++ package/libnids/libnids.mk | 17 +++++++++++++++++ 5 files changed, 41 insertions(+) create mode 100644 package/libnids/Config.in create mode 100644 package/libnids/libnids.hash create mode 100644 package/libnids/libnids.mk
DEVELOPERS +1 -0
@@ -1053,6 +1053,7 @@ F: package/c-icap-modules/ F: package/sdl2/ N: Guillaume William Brs <[email protected]> +F: package/libnids/ F: package/liquid-dsp/ F: package/pixiewps/ F: package/python-pybind/
package/Config.in +1 -0
@@ -1710,6 +1710,7 @@ menu "Networking" source "package/libnfnetlink/Config.in" source "package/libnftnl/Config.in" source "package/libnice/Config.in" + source "package/libnids/Config.in" source "package/libnl/Config.in" source "package/liboauth/Config.in" source "package/liboping/Config.in"
package/libnids/Config.in new file +19 -0
@@ -0,0 +1,19 @@ +comment "libnids requires a glibc toolchain" + depends on !BR2_TOOLCHAIN_USES_GLIBC + +config BR2_PACKAGE_LIBNIDS + bool "libnids" + depends on BR2_TOOLCHAIN_USES_GLIBC + select BR2_PACKAGE_LIBGLIB2 + select BR2_PACKAGE_LIBNET + select BR2_PACKAGE_LIBPCAP + help + Libnids is an implementation of an E-component + of Network Intrusion Detection System. + libnids watches all local network traffic, + and provides convenient information on them to + perform further analysis. + Libnids offers IP defragmentation, + TCP stream assembly, TCP port scan detection. + + http://libnids.sourceforge.net/
package/libnids/libnids.hash new file +3 -0
@@ -0,0 +1,3 @@ +# Locally calculated +sha256 314b4793e0902fbf1fdb7fb659af37a3c1306ed1aad5d1c84de6c931b351d359 libnids-1.24.tar.gz +sha256 91df39d1816bfb17a4dda2d3d2c83b1f6f2d38d53e53e41e8f97ad5ac46a0cad COPYING
package/libnids/libnids.mk new file +17 -0
@@ -0,0 +1,17 @@ +################################################################################ +# +# libnids +# +################################################################################ + +LIBNIDS_VERSION = 1.24 +LIBNIDS_SITE = https://sourceforge.net/projects/libnids/files/libnids/$(LIBNIDS_VERSION) +LIBNIDS_LICENSE = GPL-2.0 +LIBNIDS_LICENSE_FILES = COPYING +LIBNIDS_INSTALL_STAGING = YES + +LIBNIDS_CONF_OPTS += \ + prefix="$(STAGING_DIR)/usr" \ + exec_prefix="$(STAGING_DIR)/usr" + +$(eval $(autotools-package))
Signature · 1 line
2.20.1
PATCH 1/1 package/libnids: new package
Hello Guillaume,
Quoted 5 lines · On Mon, 22 Jun 2020 12:53:59 +0200 "Guillaume W. Bres"…
Libnids is a C based networking library, part of networking intrusion detection tools. It can watch network traffic & provide informations.
Signed-off-by Guillaume W. Bres <[email protected]>
I have applied your patch, with a number of changes. See below for comments, and see the final commit at:
https://git.buildroot.org/buildroot/commit/?id=b6ce06cd64b0d85c9065c60fad933c8585730320
package/libnids/Config.in line 6
Quoted 3 lines
package/libnids/Config.in new file +3
-0+config BR2_PACKAGE_LIBNIDS + bool "libnids" + depends on BR2_TOOLCHAIN_USES_GLIBC
glibc is not required: it builds fine with uclibc.
package/libnids/Config.in line 7
Quoted 1 line
package/libnids/Config.in new file +1
-0+ select BR2_PACKAGE_LIBGLIB2
This dependency is not mandatory, so I dropped it. It should be easy to re-add it with a follow-up patch.
package/libnids/Config.in line 8
Quoted 1 line
package/libnids/Config.in new file +1
-0+ select BR2_PACKAGE_LIBNET
This dependency is not mandatory, so I dropped it. Re-adding it is possible, but will need some tweaks in the configure.in script.
package/libnids/Config.in line 9
Quoted 1 line
package/libnids/Config.in new file +1
-0+ select BR2_PACKAGE_LIBPCAP
This dependency is indeed mandatory.
package/libnids/libnids.mk line 11
Quoted 5 lines
package/libnids/libnids.mk new file +5
-0+LIBNIDS_VERSION = 1.24 +LIBNIDS_SITE = https://sourceforge.net/projects/libnids/files/libnids/$(LIBNIDS_VERSION) +LIBNIDS_LICENSE = GPL-2.0 +LIBNIDS_LICENSE_FILES = COPYING +LIBNIDS_INSTALL_STAGING = YES
You forgot the _DEPENDENCIES variable, so nothing ensured that your dependencies are built before this package.
package/libnids/libnids.mk line 15
Quoted 3 lines
package/libnids/libnids.mk new file +3
-0+LIBNIDS_CONF_OPTS += \ + prefix="$(STAGING_DIR)/usr" \ + exec_prefix="$(STAGING_DIR)/usr"
So, I instead fixed this by:
(1) Adding a patch for the configure.in script that changes the detection of libpcap to use pkg-config
(2) Passing the appropriate install_prefix value at install time, since the hand-written Makefile.in use install_prefix and not DESTDIR
If you need the libglib and libnet optional dependencies, don't hesitate to send follow-up patches to add support for them.
Thanks!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
PATCH 1/1 package/libnids: new package
Hello Thomas,
thank you for your input
glibc is not required: it builds fine with uclibc.
Quoted 1 line
Quoted 1 line
+ select
BR2_PACKAGE_LIBGLIB2
This dependency is not mandatory, so I dropped it. It should be easy to
Quoted 1 line
re-add it with a follow-up patch.
Ok, I did not see the configure script had options to disable them, it's better to have a default package compatible with everyone
(2) Passing the appropriate install_prefix value at install time,
since the hand-written Makefile.in use install_prefix and not DESTDIR
it's cleaner to override at the given step (I'll keep that!)
if you need the libglib and libnet optional dependencies, don't
Quoted 1 line
hesitate to send follow-up patches to add support for them.
I need to check whether I need libglib because it's not obvious. But I certainly need libnet.
Let's say I introduce a "BR2_PACKAGE_LIBNIDS_WITH_LIBNET" option, if I add a 0002-patch to also have libnet checked with pkg-config, Is it fine with you having a patch always applied, even though we are in the --disable-libnet context?
Guillaume W. Bres
Software engineer
<[email protected]>
Le lun. 22 juin 2020 ? 22:27, Thomas Petazzoni <[email protected]> a ?crit :
Quoted 64 lines
Hello Guillaume,
Quoted 5 lines · On Mon, 22 Jun 2020 12:53:59 +0200 "Guillaume W. Bres"…
Libnids is a C based networking library, part of networking intrusion detection tools. It can watch network traffic & provide informations.
Signed-off-by Guillaume W. Bres <[email protected]>I have applied your patch, with a number of changes. See below for comments, and see the final commit at:
https://git.buildroot.org/buildroot/commit/?id=b6ce06cd64b0d85c9065c60fad933c8585730320
package/libnids/Config.in line 6
Quoted 3 lines
package/libnids/Config.in new file +3
-0+config BR2_PACKAGE_LIBNIDS + bool "libnids" + depends on BR2_TOOLCHAIN_USES_GLIBCglibc is not required: it builds fine with uclibc.
Quoted 1 line
+ select
BR2_PACKAGE_LIBGLIB2This dependency is not mandatory, so I dropped it. It should be easy to re-add it with a follow-up patch.
Quoted 1 line
+ select
BR2_PACKAGE_LIBNETThis dependency is not mandatory, so I dropped it. Re-adding it is possible, but will need some tweaks in the configure.in script.
Quoted 1 line
+ select
BR2_PACKAGE_LIBPCAPThis dependency is indeed mandatory.
Review
Quoted 2 lines
(quoted diff) +2
-0+LIBNIDS_VERSION = 1.24 +LIBNIDS_SITE =https://sourceforge.net/projects/libnids/files/libnids/$(LIBNIDS_VERSION)
package/libnids/libnids.mk line 11
Quoted 3 lines
package/libnids/libnids.mk new file +3
-0+LIBNIDS_LICENSE = GPL-2.0 +LIBNIDS_LICENSE_FILES = COPYING +LIBNIDS_INSTALL_STAGING = YESYou forgot the
_DEPENDENCIESvariable, so nothing ensured that your dependencies are built before this package.package/libnids/libnids.mk line 15
Quoted 3 lines
package/libnids/libnids.mk new file +3
-0+LIBNIDS_CONF_OPTS += \ + prefix="$(STAGING_DIR)/usr" \ + exec_prefix="$(STAGING_DIR)/usr"So, I instead fixed this by:
(1) Adding a patch for the configure.in script that changes the detection of libpcap to use pkg-config
(2) Passing the appropriate
install_prefixvalue at install time, since the hand-written Makefile.in useinstall_prefixand not DESTDIRIf you need the libglib and libnet optional dependencies, don't hesitate to send follow-up patches to add support for them.
Quoted 8 lines
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20200623/0d0a76e8/attachment.html>
PATCH 1/1 package/libnids: new package
correction:
Let's say I introduce a "BR2_PACKAGE_LIBNIDS_WITH_LIBNET" option,
Quoted 1 line
I will rather check in the .mk script if BR2_PACKAGE_LIBNET is in use and
adapt dependencies & configure flags,
rather than introducing a BR2_PACKAGE_LIBNIDS_ sub option.
question about the patch still applies though
Guillaume W. Bres
Software engineer
<[email protected]>
Le mar. 23 juin 2020 ? 11:01, Guillaume Bres <[email protected]> a ?crit :
Quoted 33 lines
Hello Thomas,
thank you for your input
glibc is not required: it builds fine with uclibc.
Quoted 1 line
Quoted 1 line
+ select
BR2_PACKAGE_LIBGLIB2This dependency is not mandatory, so I dropped it. It should be easy to
Quoted 1 line
re-add it with a follow-up patch.
Ok, I did not see the configure script had options to disable them, it's better to have a default package compatible with everyone
(2) Passing the appropriate
install_prefixvalue at install time,since the hand-written Makefile.in use
install_prefixand not DESTDIRit's cleaner to override at the given step (I'll keep that!)
if you need the libglib and libnet optional dependencies, don't
Quoted 1 line
hesitate to send follow-up patches to add support for them.
I need to check whether I need libglib because it's not obvious. But I certainly need libnet.
Let's say I introduce a "
BR2_PACKAGE_LIBNIDS_WITH_LIBNET" option, if I add a 0002-patch to also have libnet checked with pkg-config, Is it fine with you having a patch always applied, even though we are in the --disable-libnet context?
Quoted 81 lines
Guillaume W. Bres
Software engineer
<[email protected]>Le lun. 22 juin 2020 ? 22:27, Thomas Petazzoni <
thomas.petazzoni at bootlin.com> a ?crit :Quoted 72 lines
Hello Guillaume,
Quoted 5 lines · On Mon, 22 Jun 2020 12:53:59 +0200 "Guillaume W. Bres"…
Libnids is a C based networking library, part of networking intrusion detection tools. It can watch network traffic & provide informations.
Signed-off-by Guillaume W. Bres <[email protected]>I have applied your patch, with a number of changes. See below for comments, and see the final commit at:
https://git.buildroot.org/buildroot/commit/?id=b6ce06cd64b0d85c9065c60fad933c8585730320
package/libnids/Config.in line 6
Quoted 3 lines
package/libnids/Config.in new file +3
-0+config BR2_PACKAGE_LIBNIDS + bool "libnids" + depends on BR2_TOOLCHAIN_USES_GLIBCglibc is not required: it builds fine with uclibc.
Quoted 1 line
+ select
BR2_PACKAGE_LIBGLIB2This dependency is not mandatory, so I dropped it. It should be easy to re-add it with a follow-up patch.
Quoted 1 line
+ select
BR2_PACKAGE_LIBNETThis dependency is not mandatory, so I dropped it. Re-adding it is possible, but will need some tweaks in the configure.in script.
Quoted 1 line
+ select
BR2_PACKAGE_LIBPCAPThis dependency is indeed mandatory.
Review
Quoted 2 lines
(quoted diff) +2
-0+LIBNIDS_VERSION = 1.24 +LIBNIDS_SITE =https://sourceforge.net/projects/libnids/files/libnids/$(LIBNIDS_VERSION)
package/libnids/libnids.mk line 11
Quoted 3 lines
package/libnids/libnids.mk new file +3
-0+LIBNIDS_LICENSE = GPL-2.0 +LIBNIDS_LICENSE_FILES = COPYING +LIBNIDS_INSTALL_STAGING = YESYou forgot the
_DEPENDENCIESvariable, so nothing ensured that your dependencies are built before this package.package/libnids/libnids.mk line 15
Quoted 3 lines
package/libnids/libnids.mk new file +3
-0+LIBNIDS_CONF_OPTS += \ + prefix="$(STAGING_DIR)/usr" \ + exec_prefix="$(STAGING_DIR)/usr"So, I instead fixed this by:
(1) Adding a patch for the configure.in script that changes the detection of libpcap to use pkg-config
(2) Passing the appropriate
install_prefixvalue at install time, since the hand-written Makefile.in useinstall_prefixand not DESTDIRIf you need the libglib and libnet optional dependencies, don't hesitate to send follow-up patches to add support for them.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20200623/6b1dddc0/attachment.html>
PATCH 1/1 package/libnids: new package
Sorry for the rapid posts about the same topic,
but on the other hand, further discussions will be more fruitful
First off, it turns out libnids in the current configuration completely fits my needs
-----
Trying to build libnids with libnet:
- libnet does not have a pkg-config description file, so what I previously said/thought cannot apply
- unfortunately because of that, removing --disable-libnet option from configure, has LNETLIB & LNET_CFLAGS pointing to /usr/include
- they have a --with-libnet option, I tried something like --with-libnet=$(STAGING_DIR), but they look for a very specific combination
if test -f $withval/include/libnet.h -a -f $withval/lib/libnet.a -a -f
Quoted 2 lines
$withval/libnet-config ; then (line 133 in $libnids/configure.in)
- $withval/include/libnet.h exists, we have a $withval/lib/libnet.la but that is not exactly what they want, $withval/libnet-config does not exist
- so at the moment I am not able to submit anything further about this topic, because of the combination of files they look for. I don't think messing with $libnids/configure.in is an option either, that would be too dirty
- I am not familiar with pkg-config at the moment, I don't know if we can "activate libnet.pc" and have pkg-config look for it
-----
Trying to build libnids with glib2 if possible
- no problem, I may submit a patch in a near future
Guillaume W. Bres
Software engineer
<[email protected]>
Le mar. 23 juin 2020 ? 11:07, Guillaume Bres <[email protected]> a ?crit :
Quoted 11 lines
correction:
Let's say I introduce a "
BR2_PACKAGE_LIBNIDS_WITH_LIBNET" option,Quoted 1 line
I will rather check in the .mk script if
BR2_PACKAGE_LIBNETis in use and
adapt dependencies & configure flags,
rather than introducing aBR2_PACKAGE_LIBNIDS_sub option.question about the patch still applies though
Quoted 122 lines
Guillaume W. Bres
Software engineer
<[email protected]>Le mar. 23 juin 2020 ? 11:01, Guillaume Bres <[email protected]> a ?crit :
Quoted 114 lines
Hello Thomas,
thank you for your input
glibc is not required: it builds fine with uclibc.
Quoted 1 line
Quoted 1 line
+ select
BR2_PACKAGE_LIBGLIB2This dependency is not mandatory, so I dropped it. It should be easy to
Quoted 1 line
re-add it with a follow-up patch.
Ok, I did not see the configure script had options to disable them, it's better to have a default package compatible with everyone
(2) Passing the appropriate
install_prefixvalue at install time,since the hand-written Makefile.in use
install_prefixand not DESTDIRit's cleaner to override at the given step (I'll keep that!)
if you need the libglib and libnet optional dependencies, don't
Quoted 1 line
hesitate to send follow-up patches to add support for them.
I need to check whether I need libglib because it's not obvious. But I certainly need libnet.
Let's say I introduce a "
BR2_PACKAGE_LIBNIDS_WITH_LIBNET" option, if I add a 0002-patch to also have libnet checked with pkg-config, Is it fine with you having a patch always applied, even though we are in the --disable-libnet context?Guillaume W. Bres
Software engineer
<[email protected]>Le lun. 22 juin 2020 ? 22:27, Thomas Petazzoni <
thomas.petazzoni at bootlin.com> a ?crit :Quoted 72 lines
Hello Guillaume,
Quoted 5 lines · On Mon, 22 Jun 2020 12:53:59 +0200 "Guillaume W. Bres"…
Libnids is a C based networking library, part of networking intrusion detection tools. It can watch network traffic & provide informations.
Signed-off-by Guillaume W. Bres <[email protected]>I have applied your patch, with a number of changes. See below for comments, and see the final commit at:
https://git.buildroot.org/buildroot/commit/?id=b6ce06cd64b0d85c9065c60fad933c8585730320
package/libnids/Config.in line 6
Quoted 3 lines
package/libnids/Config.in new file +3
-0+config BR2_PACKAGE_LIBNIDS + bool "libnids" + depends on BR2_TOOLCHAIN_USES_GLIBCglibc is not required: it builds fine with uclibc.
Quoted 1 line
+ select
BR2_PACKAGE_LIBGLIB2This dependency is not mandatory, so I dropped it. It should be easy to re-add it with a follow-up patch.
Quoted 1 line
+ select
BR2_PACKAGE_LIBNETThis dependency is not mandatory, so I dropped it. Re-adding it is possible, but will need some tweaks in the configure.in script.
Quoted 1 line
+ select
BR2_PACKAGE_LIBPCAPThis dependency is indeed mandatory.
Review
Quoted 2 lines
(quoted diff) +2
-0+LIBNIDS_VERSION = 1.24 +LIBNIDS_SITE =https://sourceforge.net/projects/libnids/files/libnids/$(LIBNIDS_VERSION)
package/libnids/libnids.mk line 11
Quoted 3 lines
package/libnids/libnids.mk new file +3
-0+LIBNIDS_LICENSE = GPL-2.0 +LIBNIDS_LICENSE_FILES = COPYING +LIBNIDS_INSTALL_STAGING = YESYou forgot the
_DEPENDENCIESvariable, so nothing ensured that your dependencies are built before this package.package/libnids/libnids.mk line 15
Quoted 3 lines
package/libnids/libnids.mk new file +3
-0+LIBNIDS_CONF_OPTS += \ + prefix="$(STAGING_DIR)/usr" \ + exec_prefix="$(STAGING_DIR)/usr"So, I instead fixed this by:
(1) Adding a patch for the configure.in script that changes the detection of libpcap to use pkg-config
(2) Passing the appropriate
install_prefixvalue at install time, since the hand-written Makefile.in useinstall_prefixand not DESTDIRIf you need the libglib and libnet optional dependencies, don't hesitate to send follow-up patches to add support for them.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20200623/b4bbaaf5/attachment.html>
PATCH 1/1 package/libnids: new package
Quoted 4 lines · On Tue, 23 Jun 2020 14:14:20 +0200 Guillaume Bres…
Trying to build libnids with libnet:
- libnet does not have a pkg-config description file, so what I previously said/thought cannot apply
Gah.
Quoted 2 lines
- unfortunately because of that, removing --disable-libnet option from configure, has LNETLIB &
LNET_CFLAGSpointing to/usr/include
Right.
Quoted 5 lines
- they have a --with-libnet option, I tried something like --with-libnet=$(STAGING_DIR), but they look for a very specific combination
if test -f
$withval/include/libnet.h-a -f $withval/lib/libnet.a -a -fQuoted 1 line
$withval/libnet-config ; then (line 133 in $libnids/configure.in)
Their handling of the --with-libXXX value is completely non-standard. They expect it to be pointed to the *build* directory of the library, and not to a sysroot where it has been installed. I had the same issue with libpcap, which is why I switched to using pkg-config.
Quoted 6 lines
-
$withval/include/libnet.hexists, we have a $withval/lib/libnet.la but that is not exactly what they want, $withval/libnet-config does not exist
- so at the moment I am not able to submit anything further about this topic, because of the combination of files they look for. I don't think messing with $libnids/configure.in is an option either, that would be too dirty
Well, we already mess with the configure.in script: see my patch 0001 that changes the configure.in script to add support for using pkg-config to check for libpcap's availability.
Quoted 2 lines
- I am not familiar with pkg-config at the moment, I don't know if we can "activate libnet.pc" and have pkg-config look for it
If you don't need libnet support as you're saying at the beginning of this e-mail, then we can simply keep the --disable-libnet and that's it.
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
PATCH 1/1 package/libnids: new package
In reply to Guillaume BresHello,
Quoted 1 line · On Tue, 23 Jun 2020 11:01:30 +0200 Guillaume Bres…
Let's say I introduce a "
BR2_PACKAGE_LIBNIDS_WITH_LIBNET" option,
As you discovered and replied later in the thread, don't add a
sub-option: simply check in the .mk file if BR2_PACKAGE_LIBDNET is enabled.
Quoted 3 lines
if I add a 0002-patch to also have libnet checked with pkg-config, Is it fine with you having a patch always applied, even though we are in the --disable-libnet context?
The patches should always all be applied. In theory, all patches are supposed to be submitted to the upstream project, and the upstream project will not conditionally apply the patch depending on whether libnet support is enabled or not.
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com