VRR capable attach prop in i915, VRR debugfs
Subsystems (6)
v6 cover VRR capable attach prop in i915, VRR debugfs
This is an initial set of patches for enabling VRR support in i915. This series has patches for:
1. Attach and set VRR capable connector prop for Intel DP conn
2. Expose VRR min and max through debugfs
3. Remove AMD specific logic to create debugfs
Aditya Swarup (1):
drm/i915/dp: Attach and set drm connector VRR property
Bhanuprakash Modem (2):
drm/debug: Expose connector VRR monitor range via debugfs Revert "drm/amd/display: Expose connector VRR range via debugfs"
.../amd/display/amdgpu_dm/amdgpu_dm_debugfs.c | 20 -------------- drivers/gpu/drm/drm_debugfs.c | 22 +++++++++++++++ drivers/gpu/drm/i915/display/intel_dp.c | 27 +++++++++++++++++++ drivers/gpu/drm/i915/display/intel_dp.h | 2 ++ 4 files changed, 51 insertions(+), 20 deletions(-)
Signature · 6 lines
2.20.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v6 1/3 drm/i915/dp: Attach and set drm connector VRR property
From: Aditya Swarup <[email protected]>
This function sets the VRR property for connector based on the platform support, EDID monitor range and DP sink DPCD capability of outputing video without msa timing information.
v5:
* Fix the vrr prop not being set in kernel (Manasi)
* Unset the prop on connector disconnect (Manasi)
v4:
* Rebase (Mansi)
v3:
* intel_dp_is_vrr_capable can be used for debugfs, make it non static (Manasi)
v2:
* Just set this in intel_dp_get_modes instead of new hook (Jani)
--- drivers/gpu/drm/i915/display/intel_dp.c | 27 +++++++++++++++++++++++++ drivers/gpu/drm/i915/display/intel_dp.h | 2 ++ 2 files changed, 29 insertions(+)
drivers/gpu/drm/i915/display/intel_dp.c +27 -0
@@ -6149,6 +6149,9 @@ intel_dp_detect(struct drm_connector *connector,if (status == connector_status_disconnected) {memset (&intel_dp->compliance,0 ,sizeof (intel_dp->compliance));memset (intel_dp->dsc_dpcd,0 ,sizeof (intel_dp->dsc_dpcd)); +/*Reset the immutable VRR Capable property */ +drm_connector_set_vrr_capable_property (connector, + false);if (intel_dp->is_mst) { drm_dbg_kms(&dev_priv->drm,
@@ -6256,6 +6259,23 @@ intel_dp_force(struct drm_connector *connector)intel_display_power_put (dev_priv, aux_domain, wakeref); } +bool intel_dp_is_vrr_capable (struct drm_connector *connector) +{ +struct intel_dp *intel_dp =intel_attached_dp (to_intel_connector (connector)); +const struct drm_display_info *info = &connector->display_info; +struct drm_i915_private *dev_priv =to_i915 (connector->dev); + +/* +* DP Sink is capable of Variable refresh video timings if +* Ignore MSA bit is set in DPCD. +* EDID monitor range also should be atleast 10 for reasonable +* Adaptive sync/ VRR end user experience. +*/ +return INTEL_GEN (dev_priv) >=12 && +drm_dp_sink_can_do_video_without_timing_msa (intel_dp->dpcd) && + info->monitor_range.max_vfreq - info->monitor_range.min_vfreq >10 ; +} +static int intel_dp_get_modes (struct drm_connector *connector) {struct intel_connector *intel_connector =to_intel_connector (connector);
@@ -6264,6 +6284,10 @@ static int intel_dp_get_modes(struct drm_connector *connector) edid = intel_connector->detect_edid;if (edid) {int ret =intel_connector_update_modes (connector, edid); + +if (intel_dp_is_vrr_capable (connector)) +drm_connector_set_vrr_capable_property (connector, + true);if (ret)return ret; }
@@ -7325,6 +7349,9 @@ intel_dp_add_properties(struct intel_dp *intel_dp, struct drm_connector *connect connector->state->scaling_mode =DRM_MODE_SCALE_ASPECT ; } + +if (INTEL_GEN (dev_priv) >=12 ) +drm_connector_attach_vrr_capable_property (connector); }static void intel_dp_init_panel_power_timestamps (struct intel_dp *intel_dp)
drivers/gpu/drm/i915/display/intel_dp.h +2 -0
@@ -14,6 +14,7 @@ enum pipe;enum port ;struct drm_connector_state ;struct drm_encoder ; +struct drm_connector ;struct drm_i915_private ;struct drm_modeset_acquire_ctx ;struct drm_dp_vsc_sdp ;
@@ -120,6 +121,7 @@ void intel_read_dp_sdp(struct intel_encoder *encoder, unsigned int type);bool intel_digital_port_connected (struct intel_encoder *encoder);void intel_dp_process_phy_request (struct intel_dp *intel_dp); +bool intel_dp_is_vrr_capable (struct drm_connector *connector);static inline unsigned int intel_dp_unused_lane_mask (int lane_count) {
Signature · 6 lines
2.20.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v9 2/3 drm/debug: Expose connector VRR monitor range via debugfs
In reply to Bhanuprakash Modem[Why]
It's useful to know the min and max vrr range for IGT testing.
[How]
Expose the min and max vfreq for the connector via a debugfs file on the connector, "vrr_range".
Example usage: cat /sys/kernel/debug/dri/0/DP-1/vrr_range
v2:
* Fix the typo in max_vfreq (Manasi)
* Change the name of node to i915_vrr_info so we can add other vrr info for more debug info (Manasi)
* Change the VRR capable to display Yes or No (Manasi)
* Fix indentation checkpatch errors (Manasi)
v3:
* Remove the unnecessary debug print (Manasi)
v4:
* Rebase
v5:
* Rename to vrr_range to match AMD debugfs
v6:
* Rebase (manasi)
v7:
* Fix cmpilation due to rebase
v8:
* Move debugfs node creation logic to DRM (Emil)
* Remove AMD specific logic (Emil)
v9:
* Seperate patch for removal of AMD specific logic (Manasi)
--- drivers/gpu/drm/drm_debugfs.c | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+)
drivers/gpu/drm/drm_debugfs.c +22 -0
@@ -376,6 +376,24 @@ static ssize_t edid_write(struct file *file, const char __user *ubuf,return (ret) ? ret : len; } +/* +* Returns the min and max vrr vfreq through the connector's debugfs file. +* Example usage: cat /sys/kernel/debug/dri/0/DP-1/vrr_range +*/ +static int vrr_range_show (struct seq_file *m,void *data) +{ +struct drm_connector *connector = m->private; + +if (connector->status != connector_status_connected) +return -ENODEV ; + +seq_printf (m,"Min: %u\n" , (u8 )connector->display_info.monitor_range.min_vfreq); +seq_printf (m,"Max: %u\n" , (u8 )connector->display_info.monitor_range.max_vfreq); + +return 0 ; +} +DEFINE_SHOW_ATTRIBUTE (vrr_range); +static const struct file_operations drm_edid_fops = { .owner =THIS_MODULE , .open = edid_open,
@@ -413,6 +431,10 @@ void drm_debugfs_connector_add(struct drm_connector *connector)/* edid */ debugfs_create_file ("edid_override" ,S_IRUGO |S_IWUSR , root, connector, &drm_edid_fops); + +/* vrr range */ +debugfs_create_file ("vrr_range" ,S_IRUGO , root, connector, + &vrr_range_fops); }void drm_debugfs_connector_remove (struct drm_connector *connector)
Signature · 6 lines
2.20.1 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [v9 2/3] drm/debug: Expose connector VRR monitor range via debugfs
Quoted 31 lines · Bhanuprakash Modem
[Why]
It's useful to know the min and max vrr range for IGT testing.[How]
Expose the min and max vfreq for the connector via a debugfs file on the connector, "vrr_range".Example usage: cat
/sys/kernel/debug/dri/0/DP-1/vrr_rangev2:
* Fix the typo inmax_vfreq(Manasi)
* Change the name of node toi915_vrr_infoso we can add other vrr info for more debug info (Manasi)
* Change the VRR capable to display Yes or No (Manasi)
* Fix indentation checkpatch errors (Manasi)
v3:
* Remove the unnecessary debug print (Manasi)
v4:
* Rebase
v5:
* Rename tovrr_rangeto match AMD debugfs
v6:
* Rebase (manasi)
v7:
* Fix cmpilation due to rebase
v8:
* Move debugfs node creation logic to DRM (Emil)
* Remove AMD specific logic (Emil)
v9:
* Seperate patch for removal of AMD specific logic (Manasi)
Quoted 6 lines
Signed-off-by Bhanuprakash Modem <[email protected]>Signed-off-by Manasi Navare <[email protected]>Cc Jani Nikula <[email protected]>Cc Ville Syrjälä <[email protected]>Cc Harry Wentland <[email protected]>CC Emil Velikov <[email protected]>
Looks good to me,
Manasi
Quoted 51 lines
--- drivers/gpu/drm/drm_debugfs.c | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+)drivers/gpu/drm/drm_debugfs.c +22
-0@@ -376,6 +376,24 @@ static ssize_t edid_write(struct file *file, const char __user *ubuf,return (ret) ? ret : len; } +/* +* Returns the min and max vrr vfreq through the connector's debugfs file. +* Example usage: cat /sys/kernel/debug/dri/0/DP-1/vrr_range +*/ +static int vrr_range_show (struct seq_file *m,void *data) +{ +struct drm_connector *connector = m->private; + +if (connector->status != connector_status_connected) +return -ENODEV ; + +seq_printf (m,"Min: %u\n" , (u8 )connector->display_info.monitor_range.min_vfreq); +seq_printf (m,"Max: %u\n" , (u8 )connector->display_info.monitor_range.max_vfreq); + +return 0 ; +} +DEFINE_SHOW_ATTRIBUTE (vrr_range); +static const struct file_operations drm_edid_fops = { .owner =THIS_MODULE , .open = edid_open,@@ -413,6 +431,10 @@ void drm_debugfs_connector_add(struct drm_connector *connector)/* edid */ debugfs_create_file ("edid_override" ,S_IRUGO |S_IWUSR , root, connector, &drm_edid_fops); + +/* vrr range */ +debugfs_create_file ("vrr_range" ,S_IRUGO , root, connector, + &vrr_range_fops); }void drm_debugfs_connector_remove (struct drm_connector *connector)Signature · 6 lines
2.20.1 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [v9 2/3] drm/debug: Expose connector VRR monitor range via debugfs
In reply to Bhanuprakash ModemThanks Bhanu for the patch, merged to drm-misc
Manasi
Quoted 88 lines · Bhanuprakash Modem
[Why]
It's useful to know the min and max vrr range for IGT testing.[How]
Expose the min and max vfreq for the connector via a debugfs file on the connector, "vrr_range".Example usage: cat
/sys/kernel/debug/dri/0/DP-1/vrr_rangev2:
* Fix the typo inmax_vfreq(Manasi)
* Change the name of node toi915_vrr_infoso we can add other vrr info for more debug info (Manasi)
* Change the VRR capable to display Yes or No (Manasi)
* Fix indentation checkpatch errors (Manasi)
v3:
* Remove the unnecessary debug print (Manasi)
v4:
* Rebase
v5:
* Rename tovrr_rangeto match AMD debugfs
v6:
* Rebase (manasi)
v7:
* Fix cmpilation due to rebase
v8:
* Move debugfs node creation logic to DRM (Emil)
* Remove AMD specific logic (Emil)
v9:
* Seperate patch for removal of AMD specific logic (Manasi)Signed-off-by Bhanuprakash Modem <[email protected]>Signed-off-by Manasi Navare <[email protected]>Cc Jani Nikula <[email protected]>Cc Ville Syrjälä <[email protected]>Cc Harry Wentland <[email protected]>CC Emil Velikov <[email protected]>--- drivers/gpu/drm/drm_debugfs.c | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+)drivers/gpu/drm/drm_debugfs.c +22
-0@@ -376,6 +376,24 @@ static ssize_t edid_write(struct file *file, const char __user *ubuf,return (ret) ? ret : len; } +/* +* Returns the min and max vrr vfreq through the connector's debugfs file. +* Example usage: cat /sys/kernel/debug/dri/0/DP-1/vrr_range +*/ +static int vrr_range_show (struct seq_file *m,void *data) +{ +struct drm_connector *connector = m->private; + +if (connector->status != connector_status_connected) +return -ENODEV ; + +seq_printf (m,"Min: %u\n" , (u8 )connector->display_info.monitor_range.min_vfreq); +seq_printf (m,"Max: %u\n" , (u8 )connector->display_info.monitor_range.max_vfreq); + +return 0 ; +} +DEFINE_SHOW_ATTRIBUTE (vrr_range); +static const struct file_operations drm_edid_fops = { .owner =THIS_MODULE , .open = edid_open,@@ -413,6 +431,10 @@ void drm_debugfs_connector_add(struct drm_connector *connector)/* edid */ debugfs_create_file ("edid_override" ,S_IRUGO |S_IWUSR , root, connector, &drm_edid_fops); + +/* vrr range */ +debugfs_create_file ("vrr_range" ,S_IRUGO , root, connector, + &vrr_range_fops); }void drm_debugfs_connector_remove (struct drm_connector *connector)Signature · 6 lines
2.20.1 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
PATCH 3/3 Revert "drm/amd/display: Expose connector VRR range via debugfs"
In reply to Bhanuprakash ModemAs both VRR min and max are already part of drm_display_info, drm can expose this VRR range for each connector.
Hence this logic should move to core DRM.
This reverts commit 727962f030c23422a01e8b22d0f463815fb15ec4.
--- .../amd/display/amdgpu_dm/amdgpu_dm_debugfs.c | 20 ------------------- 1 file changed, 20 deletions(-)
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c +0 -20
@@ -820,24 +820,6 @@ static int output_bpc_show(struct seq_file *m, void *data)return res; } -/* -* Returns the min and max vrr vfreq through the connector's debugfs file. -* Example usage: cat /sys/kernel/debug/dri/0/DP-1/vrr_range -*/ -static int vrr_range_show (struct seq_file *m,void *data) -{ -struct drm_connector *connector = m->private; -struct amdgpu_dm_connector *aconnector =to_amdgpu_dm_connector (connector); - -if (connector->status != connector_status_connected) -return -ENODEV ; - -seq_printf (m,"Min: %u\n" , (unsigned int )aconnector->min_vfreq); -seq_printf (m,"Max: %u\n" , (unsigned int )aconnector->max_vfreq); - -return 0 ; -} -#ifdef CONFIG_DRM_AMD_DC_HDCP /* * Returns the HDCP capability of the Display (1.4 for now).
@@ -1001,7 +983,6 @@ static ssize_t dp_dpcd_data_read(struct file *f, char __user *buf,DEFINE_SHOW_ATTRIBUTE (dmub_fw_state);DEFINE_SHOW_ATTRIBUTE (dmub_tracebuffer);DEFINE_SHOW_ATTRIBUTE (output_bpc); -DEFINE_SHOW_ATTRIBUTE (vrr_range);#ifdef CONFIG_DRM_AMD_DC_HDCP DEFINE_SHOW_ATTRIBUTE (hdcp_sink_capability);#endif
@@ -1059,7 +1040,6 @@ static const struct { {"phy_settings", &dp_phy_settings_debugfs_fop}, {"test_pattern", &dp_phy_test_pattern_fops}, {"output_bpc", &output_bpc_fops}, - {"vrr_range", &vrr_range_fops}, #ifdef CONFIG_DRM_AMD_DC_HDCP {"hdcp_sink_capability", &hdcp_sink_capability_fops}, #endif
Signature · 6 lines
2.20.1 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [v1 3/3] Revert "drm/amd/display: Expose connector VRR range via debugfs"
Quoted 5 lines · Bhanuprakash Modem
As both VRR min and max are already part of
drm_display_info, drm can expose this VRR range for each connector.Hence this logic should move to core DRM.
Quoted 8 lines
This reverts commit
727962f030c23422a01e8b22d0f463815fb15ec4.Signed-off-by Bhanuprakash Modem <[email protected]>Cc Nicholas Kazlauskas <[email protected]>Cc Harry Wentland <[email protected]>Cc Alex Deucher <[email protected]>Cc Manasi Navare <[email protected]>Cc AMD gfx <[email protected]>
Looks good to me with Patch 2 part of the series.
Thanks,
Nicholas Kazlauskas
Quoted 43 lines
--- .../amd/display/amdgpu_dm/amdgpu_dm_debugfs.c | 20 ------------------- 1 file changed, 20 deletions(-)drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c +0
-19@@ -820,24 +820,6 @@ static int output_bpc_show(struct seq_file *m, void *data)return res; } -/* -* Returns the min and max vrr vfreq through the connector's debugfs file. -* Example usage: cat /sys/kernel/debug/dri/0/DP-1/vrr_range -*/ -static int vrr_range_show (struct seq_file *m,void *data) -{ -struct drm_connector *connector = m->private; -struct amdgpu_dm_connector *aconnector =to_amdgpu_dm_connector (connector); - -if (connector->status != connector_status_connected) -return -ENODEV ; - -seq_printf (m,"Min: %u\n" , (unsigned int )aconnector->min_vfreq); -seq_printf (m,"Max: %u\n" , (unsigned int )aconnector->max_vfreq); - -return 0 ; -} -#ifdef CONFIG_DRM_AMD_DC_HDCP /* * Returns the HDCP capability of the Display (1.4 for now). @@ -1001,7 +983,6 @@ static ssize_t dp_dpcd_data_read(struct file *f, char __user *buf,DEFINE_SHOW_ATTRIBUTE (dmub_fw_state);DEFINE_SHOW_ATTRIBUTE (dmub_tracebuffer);DEFINE_SHOW_ATTRIBUTE (output_bpc); -DEFINE_SHOW_ATTRIBUTE (vrr_range);#ifdef CONFIG_DRM_AMD_DC_HDCP DEFINE_SHOW_ATTRIBUTE (hdcp_sink_capability);#endif
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c static const struct { · line 1045
Quoted 7 lines
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c +0
-1@@ -1059,7 +1040,6 @@ static const struct { {"phy_settings", &dp_phy_settings_debugfs_fop}, {"test_pattern", &dp_phy_test_pattern_fops}, {"output_bpc", &output_bpc_fops}, - {"vrr_range", &vrr_range_fops}, #ifdef CONFIG_DRM_AMD_DC_HDCP {"hdcp_sink_capability", &hdcp_sink_capability_fops}, #endif
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [v1 3/3] Revert "drm/amd/display: Expose connector VRR range via debugfs"
Quoted 16 lines · Nicholas
Quoted 5 lines · Bhanuprakash Modem
As both VRR min and max are already part of
drm_display_info, drm can expose this VRR range for each connector.Hence this logic should move to core DRM.
Quoted 8 lines
This reverts commit
727962f030c23422a01e8b22d0f463815fb15ec4.Signed-off-by Bhanuprakash Modem <[email protected]>Cc Nicholas Kazlauskas <[email protected]>Cc Harry Wentland <[email protected]>Cc Alex Deucher <[email protected]>Cc Manasi Navare <[email protected]>Cc AMD gfx <[email protected]>
Quoted 4 lines
Looks good to me with Patch 2 part of the series.
Reviewed-by Nicholas Kazlauskas <[email protected]>
Thanks for your review, do we have your r-b on patch 2/3 also? In that case, how do you think we should merge the patches? Patch 2/3 will be merged through drm-misc, how about this one?
Manasi
Quoted 49 lines
Thanks,
Nicholas KazlauskasQuoted 46 lines
--- .../amd/display/amdgpu_dm/amdgpu_dm_debugfs.c | 20 ------------------- 1 file changed, 20 deletions(-)drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c +0
-20@@ -820,24 +820,6 @@ static int output_bpc_show(struct seq_file *m, void *data)return res; } -/* -* Returns the min and max vrr vfreq through the connector's debugfs file. -* Example usage: cat /sys/kernel/debug/dri/0/DP-1/vrr_range -*/ -static int vrr_range_show (struct seq_file *m,void *data) -{ -struct drm_connector *connector = m->private; -struct amdgpu_dm_connector *aconnector =to_amdgpu_dm_connector (connector); - -if (connector->status != connector_status_connected) -return -ENODEV ; - -seq_printf (m,"Min: %u\n" , (unsigned int )aconnector->min_vfreq); -seq_printf (m,"Max: %u\n" , (unsigned int )aconnector->max_vfreq); - -return 0 ; -} -#ifdef CONFIG_DRM_AMD_DC_HDCP /* * Returns the HDCP capability of the Display (1.4 for now). @@ -1001,7 +983,6 @@ static ssize_t dp_dpcd_data_read(struct file *f, char __user *buf,DEFINE_SHOW_ATTRIBUTE (dmub_fw_state);DEFINE_SHOW_ATTRIBUTE (dmub_tracebuffer);DEFINE_SHOW_ATTRIBUTE (output_bpc); -DEFINE_SHOW_ATTRIBUTE (vrr_range);#ifdef CONFIG_DRM_AMD_DC_HDCP DEFINE_SHOW_ATTRIBUTE (hdcp_sink_capability);#endif @@ -1059,7 +1040,6 @@ static const struct { {"phy_settings", &dp_phy_settings_debugfs_fop}, {"test_pattern", &dp_phy_test_pattern_fops}, {"output_bpc", &output_bpc_fops}, - {"vrr_range", &vrr_range_fops}, #ifdef CONFIG_DRM_AMD_DC_HDCP
Quoted 8 lines
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c static const struct { · line 1045
Quoted 3 lines
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c +0
-0{"hdcp_sink_capability", &hdcp_sink_capability_fops}, #endif_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
PATCH v2 3/3 Revert "drm/amd/display: Expose connector VRR range via debugfs"
In reply to Bhanuprakash ModemFrom: Bhanuprakash Modem <[email protected]>
v2:
* Rebase (Manasi)
As both VRR min and max are already part of drm_display_info, drm can expose this VRR range for each connector.
Hence this logic should move to core DRM.
This reverts commit 727962f030c23422a01e8b22d0f463815fb15ec4.
--- .../amd/display/amdgpu_dm/amdgpu_dm_debugfs.c | 20 ------------------- 1 file changed, 20 deletions(-)
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c +0 -20
@@ -820,24 +820,6 @@ static int output_bpc_show(struct seq_file *m, void *data)return res; } -/* -* Returns the min and max vrr vfreq through the connector's debugfs file. -* Example usage: cat /sys/kernel/debug/dri/0/DP-1/vrr_range -*/ -static int vrr_range_show (struct seq_file *m,void *data) -{ -struct drm_connector *connector = m->private; -struct amdgpu_dm_connector *aconnector =to_amdgpu_dm_connector (connector); - -if (connector->status != connector_status_connected) -return -ENODEV ; - -seq_printf (m,"Min: %u\n" , (unsigned int )aconnector->min_vfreq); -seq_printf (m,"Max: %u\n" , (unsigned int )aconnector->max_vfreq); - -return 0 ; -} -#ifdef CONFIG_DRM_AMD_DC_HDCP /* * Returns the HDCP capability of the Display (1.4 for now).
@@ -1001,7 +983,6 @@ static ssize_t dp_dpcd_data_read(struct file *f, char __user *buf,DEFINE_SHOW_ATTRIBUTE (dmub_fw_state);DEFINE_SHOW_ATTRIBUTE (dmub_tracebuffer);DEFINE_SHOW_ATTRIBUTE (output_bpc); -DEFINE_SHOW_ATTRIBUTE (vrr_range);#ifdef CONFIG_DRM_AMD_DC_HDCP DEFINE_SHOW_ATTRIBUTE (hdcp_sink_capability);#endif
@@ -1059,7 +1040,6 @@ static const struct { {"phy_settings", &dp_phy_settings_debugfs_fop}, {"test_pattern", &dp_phy_test_pattern_fops}, {"output_bpc", &output_bpc_fops}, - {"vrr_range", &vrr_range_fops}, #ifdef CONFIG_DRM_AMD_DC_HDCP {"hdcp_sink_capability", &hdcp_sink_capability_fops}, #endif
Signature · 6 lines
2.19.1 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Patchwork
CI[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for VRR capable attach prop in i915, VRR debugfs
In reply to Bhanuprakash Modem== Series Details ==
== Series Details ==
Series: VRR capable attach prop in i915, VRR debugfs
URL : https://patchwork.freedesktop.org/series/78670/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip 383b031f7157 drm/i915/dp: Attach and set drm connector VRR property 5d20cfadedc4 drm/debug: Expose connector VRR monitor range via debugfs -:38: WARNING:TYPO_SPELLING: 'Seperate' may be misspelled - perhaps 'Separate'? #38: * Seperate patch for removal of AMD specific logic (Manasi)
-:82: WARNING:SYMBOLIC_PERMS: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. #82: FILE: drivers/gpu/drm/drm_debugfs.c:436:
+ debugfs_create_file("vrr_range", S_IRUGO, root, connector,
total: 0 errors, 2 warnings, 0 checks, 34 lines checked 6206d3194afb Revert "drm/amd/display: Expose connector VRR range via debugfs"
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✗ Fi.CI.SPARSE: warning for VRR capable attach prop in i915, VRR debugfs
In reply to Bhanuprakash Modem== Series Details ==
== Series Details ==
Series: VRR capable attach prop in i915, VRR debugfs
URL : https://patchwork.freedesktop.org/series/78670/
State : warning
== Summary ==
$ dim sparse --fast origin/drm-tip Sparse version: v0.6.0 Fast mode used, each commit won't be checked separately. -drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_debugfs.c:1171:46: warning: Using plain integer as NULL pointer +drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_debugfs.c:1151:46: warning: Using plain integer as NULL pointer +drivers/gpu/drm/i915/display/intel_display.c:1222:22: error: Expected constant expression in case statement +drivers/gpu/drm/i915/display/intel_display.c:1225:22: error: Expected constant expression in case statement +drivers/gpu/drm/i915/display/intel_display.c:1228:22: error: Expected constant expression in case statement +drivers/gpu/drm/i915/display/intel_display.c:1231:22: error: Expected constant expression in case statement
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✗ Fi.CI.BAT: failure for VRR capable attach prop in i915, VRR debugfs
In reply to Bhanuprakash Modem== Series Details ==
== Series Details ==
Series: VRR capable attach prop in i915, VRR debugfs
URL : https://patchwork.freedesktop.org/series/78670/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_8650 -> Patchwork_18002
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_18002 absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in Patchwork_18002, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18002/index.html
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_18002:
### IGT changes ###
#### Possible regressions ####
* igt@kms_chamelium@dp-hpd-fast:
- fi-cml-u2: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8650/fi-cml-u2/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18002/fi-cml-u2/igt@[email protected]
Known issues
------------
Here are the changes found in Patchwork_18002 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_suspend@basic-s3:
- fi-tgl-u2: [PASS][3] -> [FAIL][4] ([i915#1888])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8650/fi-tgl-u2/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18002/fi-tgl-u2/igt@[email protected]
* igt@i915_module_load@reload:
- fi-tgl-u2: [PASS][5] -> [DMESG-WARN][6] ([i915#402])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8650/fi-tgl-u2/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18002/fi-tgl-u2/igt@[email protected]
#### Possible fixes ####
* igt@i915_selftest@live@gem_contexts:
- fi-tgl-u2: [INCOMPLETE][7] ([i915#1932]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8650/fi-tgl-u2/igt@i915_selftest@live@gem_contexts.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18002/fi-tgl-u2/igt@i915_selftest@live@gem_contexts.html
* igt@kms_pipe_crc_basic@read-crc-pipe-a-frame-sequence:
- fi-tgl-u2: [DMESG-WARN][9] ([i915#402]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8650/fi-tgl-u2/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18002/fi-tgl-u2/igt@[email protected]
[i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888
[i915#1932]: https://gitlab.freedesktop.org/drm/intel/issues/1932
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
Participating hosts (44 -> 10)
------------------------------
ERROR: It appears as if the changes made in Patchwork_18002 prevented too many machines from booting.
Additional (1): fi-pnv-d510
Missing (35): fi-bdw-gvtdvm fi-icl-u2 fi-apl-guc fi-snb-2520m fi-icl-y fi-byt-n2820 fi-icl-dsi fi-icl-guc fi-skl-6600u fi-snb-2600 fi-bxt-dsi fi-cml-s fi-bsw-n3050 fi-byt-j1900 fi-glk-dsi fi-ctg-p8600 fi-hsw-4770 fi-ivb-3770 fi-elk-e7500 fi-kbl-7560u fi-bsw-nick fi-ilk-m540 fi-ehl-1 fi-skl-guc fi-cfl-8700k fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-cfl-guc fi-kbl-guc fi-whl-u fi-kbl-x1275 fi-bsw-kefka fi-byt-clapper fi-bdw-samus
Build changes
-------------
* Linux: CI_DRM_8650 -> Patchwork_18002
CI-20190529: 20190529
CI_DRM_8650: 24b806b0a1dd38c734e771ece9dd1ab6492bbb96 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5714: f0ade50caf38574592886f55bb03cf80c574bb83 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_18002: 6206d3194afbfc3b06d9b9436c799126ece2cdb0 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
6206d3194afb Revert "drm/amd/display: Expose connector VRR range via debugfs" 5d20cfadedc4 drm/debug: Expose connector VRR monitor range via debugfs 383b031f7157 drm/i915/dp: Attach and set drm connector VRR property
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18002/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for VRR capable attach prop in i915, VRR debugfs (rev2)
In reply to Bhanuprakash Modem== Series Details ==
== Series Details ==
Series: VRR capable attach prop in i915, VRR debugfs (rev2)
URL : https://patchwork.freedesktop.org/series/78670/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip 2ee51bf6e884 drm/i915/dp: Attach and set drm connector VRR property 377c60b4f795 drm/debug: Expose connector VRR monitor range via debugfs -:38: WARNING:TYPO_SPELLING: 'Seperate' may be misspelled - perhaps 'Separate'? #38: * Seperate patch for removal of AMD specific logic (Manasi)
-:83: WARNING:SYMBOLIC_PERMS: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. #83: FILE: drivers/gpu/drm/drm_debugfs.c:436:
+ debugfs_create_file("vrr_range", S_IRUGO, root, connector,
total: 0 errors, 2 warnings, 0 checks, 34 lines checked 5e027171f0c0 Revert "drm/amd/display: Expose connector VRR range via debugfs"
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✗ Fi.CI.SPARSE: warning for VRR capable attach prop in i915, VRR debugfs (rev2)
In reply to Bhanuprakash Modem== Series Details ==
== Series Details ==
Series: VRR capable attach prop in i915, VRR debugfs (rev2)
URL : https://patchwork.freedesktop.org/series/78670/
State : warning
== Summary ==
$ dim sparse --fast origin/drm-tip Sparse version: v0.6.0 Fast mode used, each commit won't be checked separately. -drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_debugfs.c:1171:46: warning: Using plain integer as NULL pointer +drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_debugfs.c:1151:46: warning: Using plain integer as NULL pointer +drivers/gpu/drm/i915/display/intel_display.c:1222:22: error: Expected constant expression in case statement +drivers/gpu/drm/i915/display/intel_display.c:1225:22: error: Expected constant expression in case statement +drivers/gpu/drm/i915/display/intel_display.c:1228:22: error: Expected constant expression in case statement +drivers/gpu/drm/i915/display/intel_display.c:1231:22: error: Expected constant expression in case statement
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✗ Fi.CI.BAT: failure for VRR capable attach prop in i915, VRR debugfs (rev2)
In reply to Bhanuprakash Modem== Series Details ==
== Series Details ==
Series: VRR capable attach prop in i915, VRR debugfs (rev2)
URL : https://patchwork.freedesktop.org/series/78670/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_8655 -> Patchwork_18010
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_18010 absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in Patchwork_18010, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18010/index.html
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_18010:
### IGT changes ###
#### Possible regressions ####
* igt@kms_chamelium@dp-hpd-fast:
- fi-cml-u2: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8655/fi-cml-u2/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18010/fi-cml-u2/igt@[email protected]
Known issues
------------
Here are the changes found in Patchwork_18010 that come from known issues:
### IGT changes ###
#### Possible fixes ####
* igt@gem_exec_suspend@basic-s0:
- fi-tgl-u2: [FAIL][3] ([i915#1888]) -> [PASS][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8655/fi-tgl-u2/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18010/fi-tgl-u2/igt@[email protected]
* igt@i915_selftest@live@gem_contexts:
- fi-tgl-u2: [INCOMPLETE][5] ([i915#1932]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8655/fi-tgl-u2/igt@i915_selftest@live@gem_contexts.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18010/fi-tgl-u2/igt@i915_selftest@live@gem_contexts.html
* igt@kms_pipe_crc_basic@read-crc-pipe-a-frame-sequence:
- fi-tgl-u2: [DMESG-WARN][7] ([i915#402]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8655/fi-tgl-u2/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18010/fi-tgl-u2/igt@[email protected]
[i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888
[i915#1932]: https://gitlab.freedesktop.org/drm/intel/issues/1932
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
Participating hosts (44 -> 11)
------------------------------
ERROR: It appears as if the changes made in Patchwork_18010 prevented too many machines from booting.
Missing (33): fi-kbl-soraka fi-bdw-gvtdvm fi-icl-u2 fi-apl-guc fi-snb-2520m fi-icl-y fi-byt-n2820 fi-icl-dsi fi-skl-6600u fi-snb-2600 fi-bxt-dsi fi-cml-s fi-bsw-n3050 fi-byt-j1900 fi-glk-dsi fi-hsw-4770 fi-ivb-3770 fi-elk-e7500 fi-bsw-nick fi-ilk-m540 fi-ehl-1 fi-skl-guc fi-cfl-8700k fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-cfl-guc fi-kbl-guc fi-whl-u fi-kbl-x1275 fi-bsw-kefka fi-byt-clapper fi-bdw-samus
Build changes
-------------
* Linux: CI_DRM_8655 -> Patchwork_18010
CI-20190529: 20190529
CI_DRM_8655: 25d43cec6c2200a9ebe8a8b0923b27b164a6f424 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5716: 71a22c37ae6541f9d991d81f15cbade1da402b75 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_18010: 5e027171f0c0028d9cc34be622d2e34b44a62c3a @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
5e027171f0c0 Revert "drm/amd/display: Expose connector VRR range via debugfs" 377c60b4f795 drm/debug: Expose connector VRR monitor range via debugfs 2ee51bf6e884 drm/i915/dp: Attach and set drm connector VRR property
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18010/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✗ Fi.CI.BUILD: failure for VRR capable attach prop in i915, VRR debugfs (rev3)
In reply to Bhanuprakash Modem== Series Details ==
== Series Details ==
Series: VRR capable attach prop in i915, VRR debugfs (rev3)
URL : https://patchwork.freedesktop.org/series/78670/
State : failure
== Summary ==
Applying: drm/i915/dp: Attach and set drm connector VRR property
Applying: drm/debug: Expose connector VRR monitor range via debugfs
Using index info to reconstruct a base tree...
M drivers/gpu/drm/drm_debugfs.c
Falling back to patching base and 3-way merge...
No changes -- Patch already applied.
Applying: Revert "drm/amd/display: Expose connector VRR range via debugfs"
Using index info to reconstruct a base tree...
M drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c
Falling back to patching base and 3-way merge...
Auto-merging drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c
CONFLICT (content): Merge conflict in drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0003 Revert "drm/amd/display: Expose connector VRR range via debugfs" When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx