Skip to contentSkip to conversation

docs: Don't push Sphinx upgrades quite so readily

PATCH New Jonathan Corbet 1 participant 1 message Jun 22, 2020 Documentation

lore
Share & tools
lore

Jonathan Corbet

author maintainer
#0 lore raw

PATCH 1/1 docs: Don't push Sphinx upgrades quite so readily

The sphinx-pre-install script will put out a verbose message recommending an upgrade for anybody running less than 2.4.4 - which was only released in March. So *everybody* will see that warning at this point. Let's only warn if the user is below our generally recommended version (1.7.9 currently).

It might be good to put out a warning if people are explicitly making PDF files, but would need to be done in a different place and relatively few people do that.

---
 scripts/sphinx-pre-install | 4 ----
 1 file changed, 4 deletions(-)
scripts/sphinx-pre-install +0 -4
index c680c3efb176e..40fa6923e80ae 100755
@@ -323,10 +323,6 @@ sub check_sphinx()
 		$rec_sphinx_upgrade = 1;
 		return;
 	}
-	if ($cur_version lt $min_pdf_version) {
-		$rec_sphinx_upgrade = 1;
-		return;
-	}
 
 	# On version check mode, just assume Sphinx has all mandatory deps
 	exit (0) if ($version_check);
Signature · 1 line
2.26.2