Skip to contentSkip to conversation

toolchain/wrapper: extend the list of unsafe paths

PATCH New Yann E. MORIN 2 participants 3 messages Jun 21, 2020 – Jun 22, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 toolchain/wrapper: extend the list of unsafe paths

On some legacy systems, the X11 headers and libs are in /usr/X11R66/include and /usr/X11R66/lib, and of course, some packages are trying to be smart and use those paths (even when they do not exist).

Add those to the list of unsafe paths to check in the toolchain wrapper.

---
 toolchain/toolchain-wrapper.c | 2 ++
 1 file changed, 2 insertions(+)
toolchain/toolchain-wrapper.c +2 -0
index 8cfc963ccd..39e9f0850f 100644
@@ -129,6 +129,8 @@ static const struct str_len_s unsafe_paths[] = {
 	STR_LEN(/usr/lib),
 	STR_LEN(/usr/local/include),
 	STR_LEN(/usr/local/lib),
+	STR_LEN(/usr/X11R6/include),
+	STR_LEN(/usr/X11R6/lib),
 	{ NULL, 0 },
 };
 
Signature · 1 line
2.20.1
#1 lore raw

PATCH 1/1 toolchain/wrapper: extend the list of unsafe paths

Quoted 10 lines · On Sun, 21 Jun 2020 22:31:58 +0200 "Yann E. MORIN" <[email protected]>…

On some legacy systems, the X11 headers and libs are in /usr/X11R66/include and /usr/X11R66/lib, and of course, some packages are trying to be smart and use those paths (even when they do not exist).

Add those to the list of unsafe paths to check in the toolchain wrapper.

---
 toolchain/toolchain-wrapper.c | 2 ++
 1 file changed, 2 insertions(+)

Applied to master, thanks. Do you remember why we don't simply blacklist /usr entirely ?

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#2 lore raw

PATCH 1/1 toolchain/wrapper: extend the list of unsafe paths

Thomas, All,

On 2020-06-22 22:40 +0200, Thomas Petazzoni spake thusly:

Quoted 6 lines
Quoted 4 lines · On Sun, 21 Jun 2020 22:31:58 +0200 "Yann E. MORIN" <[email protected]>…

On some legacy systems, the X11 headers and libs are in /usr/X11R66/include and /usr/X11R66/lib, and of course, some packages are trying to be smart and use those paths (even when they do not exist).

Quoted 8 lines
Quoted 6 lines

Add those to the list of unsafe paths to check in the toolchain wrapper.

---
 toolchain/toolchain-wrapper.c | 2 ++
 1 file changed, 2 insertions(+)

Applied to master, thanks. Do you remember why we don't simply blacklist /usr entirely ?

Becuase that would be too easy? ;-)

No, but same reason we are (trying to be smart when fixing the .la files, see 7701fc53d1 (infra: support buildroot being located in /usr).

Regards,
Yann E. MORIN.

Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'