crypto, x86: aesni: add compatibility with IAS
Subsystems (2)
PATCH 1/1 crypto, x86: aesni: add compatibility with IAS
Clang's integrated assembler complains "invalid reassignment of non-absolute variable 'var_ddq_add'" while assembling arch/x86/crypto/aes_ctrby8_avx-x86_64.S. It was because var_ddq_add was reassigned with non-absolute values several times, which IAS did not support. We can avoid the reassignment by replacing the uses of var_ddq_add with its definitions accordingly to have compatilibility with IAS.
--- arch/x86/crypto/aes_ctrby8_avx-x86_64.S | 14 +++----------- 1 file changed, 3 insertions(+), 11 deletions(-)
arch/x86/crypto/aes_ctrby8_avx-x86_64.S +3 -11
@@ -127,10 +127,6 @@ ddq_add_8: /* generate a unique variable for ddq_add_x */ -.macro setddq n - var_ddq_add = ddq_add_\n -.endm - /* generate a unique variable for xmm register */ .macro setxdata n var_xdata = %xmm\n
@@ -140,9 +136,7 @@ ddq_add_8: .macro club name, id .altmacro - .if \name == DDQ_DATA - setddq %\id - .elseif \name == XDATA + .if \name == XDATA setxdata %\id .endif .noaltmacro
@@ -165,9 +159,8 @@ ddq_add_8: .set i, 1 .rept (by - 1) - club DDQ_DATA, i club XDATA, i - vpaddq var_ddq_add(%rip), xcounter, var_xdata + vpaddq (ddq_add_1 + 16 * (i - 1))(%rip), xcounter, var_xdata vptest ddq_low_msk(%rip), var_xdata jnz 1f vpaddq ddq_high_add_1(%rip), var_xdata, var_xdata
@@ -180,8 +173,7 @@ ddq_add_8: vmovdqa 1*16(p_keys), xkeyA vpxor xkey0, xdata0, xdata0 - club DDQ_DATA, by - vpaddq var_ddq_add(%rip), xcounter, xcounter + vpaddq (ddq_add_1 + 16 * (by - 1))(%rip), xcounter, xcounter vptest ddq_low_msk(%rip), xcounter jnz 1f vpaddq ddq_high_add_1(%rip), xcounter, xcounter
Signature · 1 line
2.27.0.111.gc72c7da667-goog
Herbert Xu
maintainerQuoted 8 lines · Jian Cai
Clang's integrated assembler complains "invalid reassignment of non-absolute variable '
var_ddq_add'" while assemblingarch/x86/crypto/aes_ctrby8_avx-x86_64.S. It was becausevar_ddq_addwas reassigned with non-absolute values several times, which IAS did not support. We can avoid the reassignment by replacing the uses ofvar_ddq_addwith its definitions accordingly to have compatilibility with IAS.
Quoted 8 lines
Reported-by Sedat Dilek <[email protected]>Reported-by Fangrui Song <[email protected]>Signed-off-by Jian Cai <[email protected]>--- arch/x86/crypto/aes_ctrby8_avx-x86_64.S | 14 +++----------- 1 file changed, 3 insertions(+), 11 deletions(-)
Patch applied. Thanks.
Signature · 3 lines
Email: Herbert Xu <[email protected]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Quoted 19 lines · Herbert Xu
Quoted 8 lines · Jian Cai
Clang's integrated assembler complains "invalid reassignment of non-absolute variable '
var_ddq_add'" while assemblingarch/x86/crypto/aes_ctrby8_avx-x86_64.S. It was becausevar_ddq_addwas reassigned with non-absolute values several times, which IAS did not support. We can avoid the reassignment by replacing the uses ofvar_ddq_addwith its definitions accordingly to have compatilibility with IAS.Quoted 8 lines
Reported-by Sedat Dilek <[email protected]>Reported-by Fangrui Song <[email protected]>Signed-off-by Jian Cai <[email protected]>--- arch/x86/crypto/aes_ctrby8_avx-x86_64.S | 14 +++----------- 1 file changed, 3 insertions(+), 11 deletions(-)
Quoted 1 line
Patch applied. Thanks.
Hi Herbert,
Can you please apply my patch, too?
For being able to compile/assemble with LLVM_IAS=1 *both* patches are needed with CONFIG_CRYPTO_AES_NI_INTEL={m,y}.
If you do pick this up, please add a...
Thanks.
Regards,
- Sedat -
[0] https://lore.kernel.org/patchwork/patch/1263102/
[1] https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git/commit/?id=44069737ac9625a0f02f0f7f5ab96aae4cd819bc
[2] https://bugs.llvm.org/show_bug.cgi?id=24494
Quoted 4 lines
--
Email: Herbert Xu <[email protected]> Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Herbert Xu
maintainerQuoted 2 lines · Sedat Dilek
Can you please apply my patch, too?
Please repost your patch without the 5.7 tag.
Thanks,
Signature · 3 lines
Email: Herbert Xu <[email protected]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Quoted 7 lines · Herbert Xu
Quoted 2 lines · Sedat Dilek
Can you please apply my patch, too?
Please repost your patch without the 5.7 tag.
Sent out a v5:
Changes v4->v5:
- Drop "5.7" tag from subject line as requested by Herbert Xu
- Add Link to LLVM bug #24494 (thanks Nick)
Thanks.
- Sedat -
Quoted 10 lines
Thanks,
--
Email: Herbert Xu <[email protected]> Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt--
You received this message because you are subscribed to the Google Groups "Clang Built Linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/clang-built-linux/20200703125949.GA28373%40gondor.apana.org.au.