Skip to contentSkip to conversation

mailbox: imx: Mark PM functions as __maybe_unused

PATCH In review Nathan Chancellor 2 participants 3 messages Jun 23, 2020 – Jun 30, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mailbox: imx: Mark PM functions as __maybe_unused

When CONFIG_PM and CONFIG_PM_SLEEP are unset, the following warnings occur:

drivers/mailbox/imx-mailbox.c:638:12: warning: 'imx_mu_runtime_resume' defined but not used [-Wunused-function]
638 | static int imx_mu_runtime_resume(struct device *dev)

      |            ^~~~~~~~~~~~~~~~~~~~~
drivers/mailbox/imx-mailbox.c:629:12: warning: 'imx_mu_runtime_suspend'
defined but not used [-Wunused-function]
  629 | static int imx_mu_runtime_suspend(struct device *dev)
      |            ^~~~~~~~~~~~~~~~~~~~~~
drivers/mailbox/imx-mailbox.c:611:12: warning: 'imx_mu_resume_noirq'
defined but not used [-Wunused-function]
  611 | static int imx_mu_resume_noirq(struct device *dev)
      |            ^~~~~~~~~~~~~~~~~~~
drivers/mailbox/imx-mailbox.c:601:12: warning: 'imx_mu_suspend_noirq'
defined but not used [-Wunused-function]
  601 | static int imx_mu_suspend_noirq(struct device *dev)
      |            ^~~~~~~~~~~~~~~~~~~~

Mark these functions as __maybe_unused, which is the standard procedure for PM functions.

Fixes bb2b2624dbe2 ("mailbox: imx: Add runtime PM callback to handle MU clocks")
---
 drivers/mailbox/imx-mailbox.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/mailbox/imx-mailbox.c +4 -4
index 7205b825c8b5..2543c7b6948b 100644
@@ -598,7 +598,7 @@ static const struct of_device_id imx_mu_dt_ids[] = {
 };
 MODULE_DEVICE_TABLE(of, imx_mu_dt_ids);
 
-static int imx_mu_suspend_noirq(struct device *dev)
+static int __maybe_unused imx_mu_suspend_noirq(struct device *dev)
 {
 	struct imx_mu_priv *priv = dev_get_drvdata(dev);
 
@@ -608,7 +608,7 @@ static int imx_mu_suspend_noirq(struct device *dev)
 	return 0;
 }
 
-static int imx_mu_resume_noirq(struct device *dev)
+static int __maybe_unused imx_mu_resume_noirq(struct device *dev)
 {
 	struct imx_mu_priv *priv = dev_get_drvdata(dev);
 
@@ -626,7 +626,7 @@ static int imx_mu_resume_noirq(struct device *dev)
 	return 0;
 }
 
-static int imx_mu_runtime_suspend(struct device *dev)
+static int __maybe_unused imx_mu_runtime_suspend(struct device *dev)
 {
 	struct imx_mu_priv *priv = dev_get_drvdata(dev);
 
@@ -635,7 +635,7 @@ static int imx_mu_runtime_suspend(struct device *dev)
 	return 0;
 }
 
-static int imx_mu_runtime_resume(struct device *dev)
+static int __maybe_unused imx_mu_runtime_resume(struct device *dev)
 {
 	struct imx_mu_priv *priv = dev_get_drvdata(dev);
 	int ret;

base-commit: 27f11fea33608cbd321a97cbecfa2ef97dcc1821

Signature · 1 line
2.27.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 23 lines

From: Nathan Chancellor <[email protected]>
Sent: Tuesday, June 23, 2020 9:04 AM

When CONFIG_PM and CONFIG_PM_SLEEP are unset, the following warnings occur:

drivers/mailbox/imx-mailbox.c:638:12: warning: 'imx_mu_runtime_resume' defined but not used [-Wunused-function]
638 | static int imx_mu_runtime_resume(struct device *dev)

      |            ^~~~~~~~~~~~~~~~~~~~~
drivers/mailbox/imx-mailbox.c:629:12: warning: 'imx_mu_runtime_suspend'
defined but not used [-Wunused-function]
  629 | static int imx_mu_runtime_suspend(struct device *dev)
      |            ^~~~~~~~~~~~~~~~~~~~~~
drivers/mailbox/imx-mailbox.c:611:12: warning: 'imx_mu_resume_noirq'
defined but not used [-Wunused-function]
  611 | static int imx_mu_resume_noirq(struct device *dev)
      |            ^~~~~~~~~~~~~~~~~~~
drivers/mailbox/imx-mailbox.c:601:12: warning: 'imx_mu_suspend_noirq'
defined but not used [-Wunused-function]
  601 | static int imx_mu_suspend_noirq(struct device *dev)
      |            ^~~~~~~~~~~~~~~~~~~~
Quoted 6 lines

Mark these functions as __maybe_unused, which is the standard procedure for PM functions.

Fixes bb2b2624dbe2 ("mailbox: imx: Add runtime PM callback to handle MU

clocks")

Thanks for catching this.

Regards
Aisheng

#2 lore raw
Quoted 30 lines · Aisheng Dong
Quoted 23 lines

From: Nathan Chancellor <[email protected]>
Sent: Tuesday, June 23, 2020 9:04 AM

When CONFIG_PM and CONFIG_PM_SLEEP are unset, the following warnings occur:

drivers/mailbox/imx-mailbox.c:638:12: warning: 'imx_mu_runtime_resume' defined but not used [-Wunused-function]
638 | static int imx_mu_runtime_resume(struct device *dev)

      |            ^~~~~~~~~~~~~~~~~~~~~
drivers/mailbox/imx-mailbox.c:629:12: warning: 'imx_mu_runtime_suspend'
defined but not used [-Wunused-function]
  629 | static int imx_mu_runtime_suspend(struct device *dev)
      |            ^~~~~~~~~~~~~~~~~~~~~~
drivers/mailbox/imx-mailbox.c:611:12: warning: 'imx_mu_resume_noirq'
defined but not used [-Wunused-function]
  611 | static int imx_mu_resume_noirq(struct device *dev)
      |            ^~~~~~~~~~~~~~~~~~~
drivers/mailbox/imx-mailbox.c:601:12: warning: 'imx_mu_suspend_noirq'
defined but not used [-Wunused-function]
  601 | static int imx_mu_suspend_noirq(struct device *dev)
      |            ^~~~~~~~~~~~~~~~~~~~
Quoted 6 lines

Mark these functions as __maybe_unused, which is the standard procedure for PM functions.

Fixes bb2b2624dbe2 ("mailbox: imx: Add runtime PM callback to handle MU

clocks")

Quoted 6 lines

Thanks for catching this.

Regards
Aisheng

Thank you for the review :)

These warnings were introduced by a patch in this merge window, it would be nice if this patch could be fixed up as a fix for that but I understand if it is too late for that.

Cheers,
Nathan