ARM: imx: ddr: Fill in missing DDRC ZQCTLx on i.MX7
Subsystems (3)
PATCH 1/1 ARM: imx: ddr: Fill in missing DDRC ZQCTLx on i.MX7
The iMX7 defines further DDRC ZQCTLx registers, however those were thus far missing from the list of registers and not programmed. On systems with LPDDR2 or DDR3, those registers must be programmed with correct values, otherwise the DRAM may not work. However, existing systems which worked without programming these registers before are now setting those registers to 0, which is the default value, so no functional change there.
--- arch/arm/include/asm/arch-mx7/mx7-ddr.h | 4 +++- arch/arm/mach-imx/mx7/ddr.c | 1 + 2 files changed, 4 insertions(+), 1 deletion(-)
arch/arm/include/asm/arch-mx7/mx7-ddr.h +3 -1
@@ -39,7 +39,9 @@ struct ddrc {u32 dramtmg8;/* 0x0120 */ u32 reserved7[0x17 ];u32 zqctl0;/* 0x0180 */ -u32 reserved8[0x03 ]; +u32 zqctl1;/* 0x0184 */ +u32 zqctl2;/* 0x0188 */ +u32 zqstat;/* 0x018c */ u32 dfitmg0;/* 0x0190 */ u32 dfitmg1;/* 0x0194 */ u32 reserved9[0x02 ];
arch/arm/mach-imx/mx7/ddr.c +1 -0
@@ -58,6 +58,7 @@ void mx7_dram_cfg(struct ddrc *ddrc_regs_val, struct ddrc_mp *ddrc_mp_val,writel (ddrc_regs_val->dramtmg5, &ddrc_regs->dramtmg5);writel (ddrc_regs_val->dramtmg8, &ddrc_regs->dramtmg8);writel (ddrc_regs_val->zqctl0, &ddrc_regs->zqctl0); +writel (ddrc_regs_val->zqctl1, &ddrc_regs->zqctl1);writel (ddrc_regs_val->dfitmg0, &ddrc_regs->dfitmg0);writel (ddrc_regs_val->dfitmg1, &ddrc_regs->dfitmg1);writel (ddrc_regs_val->dfiupd0, &ddrc_regs->dfiupd0);
Signature · 1 line
2.25.1
PATCH 1/1 ARM: imx: ddr: Fill in missing DDRC ZQCTLx on i.MX7
Quoted 7 lines
The iMX7 defines further DDRC ZQCTLx registers, however those were thus far missing from the list of registers and not programmed. On systems with LPDDR2 or DDR3, those registers must be programmed with correct values, otherwise the DRAM may not work. However, existing systems which worked without programming these registers before are now setting those registers to 0, which is the default value, so no functional change there.
Quoted 5 lines
Signed-off-by Marek Vasut <[email protected]>Cc Fabio Estevam <[email protected]>Cc NXP i.MX U-Boot Team <[email protected]>Cc Peng Fan <[email protected]>Cc Stefano Babic <[email protected]>
Applied to u-boot-imx, master, thanks !
Best regards,
Stefano Babic
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================