RAW format dumps through RDMAtool
Subsystems (7)
v3 cover RAW format dumps through RDMAtool
From: Leon Romanovsky <[email protected]>
Changelog:
v3:
* Rewrote query interface in patch "RDMA: Add support to dump resource tracker in RAW format"
v2:
https://lore.kernel.org/linux-rdma/[email protected]
* Converted to specific nldev ops for RAW.
* Rebased on top of v5.8-rc1.
v1:
https://lore.kernel.org/linux-rdma/[email protected]
* Maor dropped controversial change to dummy interface.
v0:
https://lore.kernel.org/linux-rdma/[email protected]
------------------------------------------------------------------------------
Hi,
The following series adds support to get the RDMA resource data in RAW format. The main motivation for doing this is to enable vendors to return the entire QP/CQ/MR data without a need from the vendor to set each field separately.
Thanks
Maor Gottlieb (11):
net/mlx5: Export resource dump interface net/mlx5: Add support in query QP, CQ and MKEY segments RDMA/core: Don't call fill_res_entry for PD
RDMA: Add dedicated MR resource tracker function
RDMA: Add a dedicated CQ resource tracker function
RDMA: Add dedicated QP resource tracker function
RDMA: Add dedicated CM_ID resource tracker function
RDMA: Add support to dump resource tracker in RAW format RDMA/mlx5: Add support to get QP resource in RAW format RDMA/mlx5: Add support to get CQ resource in RAW format RDMA/mlx5: Add support to get MR resource in RAW format
drivers/infiniband/core/device.c | 10 +-
drivers/infiniband/core/nldev.c | 214 ++++++++++--------
drivers/infiniband/hw/cxgb4/iw_cxgb4.h | 7 +-
drivers/infiniband/hw/cxgb4/provider.c | 11 +-
drivers/infiniband/hw/cxgb4/restrack.c | 24 +-
drivers/infiniband/hw/hns/hns_roce_device.h | 4 +-
drivers/infiniband/hw/hns/hns_roce_main.c | 2 +-
drivers/infiniband/hw/hns/hns_roce_restrack.c | 14 +-
drivers/infiniband/hw/mlx5/main.c | 7 +-
drivers/infiniband/hw/mlx5/mlx5_ib.h | 9 +-
drivers/infiniband/hw/mlx5/restrack.c | 105 +++++++--
.../mellanox/mlx5/core/diag/rsc_dump.c | 6 +
.../mellanox/mlx5/core/diag/rsc_dump.h | 33 +--
.../diag => include/linux/mlx5}/rsc_dump.h | 25 +-
include/rdma/ib_verbs.h | 13 +-
include/uapi/rdma/rdma_netlink.h | 8 +
16 files changed, 279 insertions(+), 213 deletions(-)
copy {drivers/net/ethernet/mellanox/mlx5/core/diag => include/linux/mlx5}/rsc_dump.h (68%)--
2.26.2
PATCH v3 1/11 net/mlx5: Export resource dump interface
From: Maor Gottlieb <[email protected]>
Export some of the resource dump API. mlx5_ib driver will use it in downstream patches.
---
.../mellanox/mlx5/core/diag/rsc_dump.c | 3 ++
.../mellanox/mlx5/core/diag/rsc_dump.h | 33 +------------------
.../diag => include/linux/mlx5}/rsc_dump.h | 22 ++++---------
3 files changed, 10 insertions(+), 48 deletions(-)
copy {drivers/net/ethernet/mellanox/mlx5/core/diag => include/linux/mlx5}/rsc_dump.h (68%)drivers/net/ethernet/mellanox/mlx5/core/diag/rsc_dump.c +3 -0
@@ -130,11 +130,13 @@ struct mlx5_rsc_dump_cmd *mlx5_rsc_dump_cmd_create(struct mlx5_core_dev *dev, cmd->mem_size = key->size;return cmd; } +EXPORT_SYMBOL (mlx5_rsc_dump_cmd_create);void mlx5_rsc_dump_cmd_destroy (struct mlx5_rsc_dump_cmd *cmd) {kfree (cmd); } +EXPORT_SYMBOL (mlx5_rsc_dump_cmd_destroy);int mlx5_rsc_dump_next (struct mlx5_core_dev *dev,struct mlx5_rsc_dump_cmd *cmd,struct page *page,int *size)
@@ -155,6 +157,7 @@ int mlx5_rsc_dump_next(struct mlx5_core_dev *dev, struct mlx5_rsc_dump_cmd *cmd,return more_dump; } +EXPORT_SYMBOL (mlx5_rsc_dump_next);#define MLX5_RSC_DUMP_MENU_SEGMENT 0xffffstatic int mlx5_rsc_dump_menu (struct mlx5_core_dev *dev)
drivers/net/ethernet/mellanox/mlx5/core/diag/rsc_dump.h +1 -32
@@ -4,41 +4,10 @@#ifndef __MLX5_RSC_DUMP_H#define __MLX5_RSC_DUMP_H +#include <linux/mlx5/rsc_dump.h> #include <linux/mlx5/driver.h> #include "mlx5_core.h" -enum mlx5_sgmt_type { -MLX5_SGMT_TYPE_HW_CQPC , -MLX5_SGMT_TYPE_HW_SQPC , -MLX5_SGMT_TYPE_HW_RQPC , -MLX5_SGMT_TYPE_FULL_SRQC , -MLX5_SGMT_TYPE_FULL_CQC , -MLX5_SGMT_TYPE_FULL_EQC , -MLX5_SGMT_TYPE_FULL_QPC , -MLX5_SGMT_TYPE_SND_BUFF , -MLX5_SGMT_TYPE_RCV_BUFF , -MLX5_SGMT_TYPE_SRQ_BUFF , -MLX5_SGMT_TYPE_CQ_BUFF , -MLX5_SGMT_TYPE_EQ_BUFF , -MLX5_SGMT_TYPE_SX_SLICE , -MLX5_SGMT_TYPE_SX_SLICE_ALL , -MLX5_SGMT_TYPE_RDB , -MLX5_SGMT_TYPE_RX_SLICE_ALL , -MLX5_SGMT_TYPE_MENU , -MLX5_SGMT_TYPE_TERMINATE , - -MLX5_SGMT_TYPE_NUM ,/* Keep last */ -}; - -struct mlx5_rsc_key { -enum mlx5_sgmt_type rsc; -int index1; -int index2; -int num_of_obj1; -int num_of_obj2; -int size; -}; -#define MLX5_RSC_DUMP_ALL 0xFFFFstruct mlx5_rsc_dump_cmd ;struct mlx5_rsc_dump ;
include/linux/mlx5/rsc_dump.h renamed from drivers/net/ethernet/mellanox/mlx5/core/diag/rsc_dump.h +6 -16
@@ -1,11 +1,10 @@ -/* SPDX-License-Identifier: GPL-2.0 */ -/* Copyright (c) 2019 Mellanox Technologies. */ - -#ifndef __MLX5_RSC_DUMP_H -#define __MLX5_RSC_DUMP_H +/* SPDX-License-Identifier: GPL-2.0 OR Linux-OpenIB */ +/* Copyright (c) 2020 Mellanox Technologies inc. */ #include <linux/mlx5/driver.h> -#include "mlx5_core.h" + +#ifndef __MLX5_RSC_DUMP +#define __MLX5_RSC_DUMPenum mlx5_sgmt_type { MLX5_SGMT_TYPE_HW_CQPC,
@@ -39,20 +38,11 @@ struct mlx5_rsc_key { int size; }; -#define MLX5_RSC_DUMP_ALL 0xFFFFstruct mlx5_rsc_dump_cmd ; -struct mlx5_rsc_dump ; - -struct mlx5_rsc_dump *mlx5_rsc_dump_create (struct mlx5_core_dev *dev); -void mlx5_rsc_dump_destroy (struct mlx5_core_dev *dev); - -int mlx5_rsc_dump_init (struct mlx5_core_dev *dev); -void mlx5_rsc_dump_cleanup (struct mlx5_core_dev *dev);struct mlx5_rsc_dump_cmd *mlx5_rsc_dump_cmd_create (struct mlx5_core_dev *dev,struct mlx5_rsc_key *key);void mlx5_rsc_dump_cmd_destroy (struct mlx5_rsc_dump_cmd *cmd); -int mlx5_rsc_dump_next (struct mlx5_core_dev *dev,struct mlx5_rsc_dump_cmd *cmd,struct page *page,int *size); -#endif +#endif /* __MLX5_RSC_DUMP */
Signature · 1 line
2.26.2
PATCH v3 2/11 net/mlx5: Add support in query QP, CQ and MKEY segments
In reply to Leon RomanovskyFrom: Maor Gottlieb <[email protected]>
Introduce new resource dump segments - PRM_QUERY_QP, PRM_QUERY_CQ and PRM_QUERY_MKEY. These segments contains the resource dump in PRM query format.
--- drivers/net/ethernet/mellanox/mlx5/core/diag/rsc_dump.c | 3 +++ include/linux/mlx5/rsc_dump.h | 3 +++ 2 files changed, 6 insertions(+)
drivers/net/ethernet/mellanox/mlx5/core/diag/rsc_dump.c +3 -0
@@ -23,6 +23,9 @@ static const char *const mlx5_rsc_sgmt_name[] = {MLX5_SGMT_STR_ASSING (SX_SLICE_ALL ),MLX5_SGMT_STR_ASSING (RDB ),MLX5_SGMT_STR_ASSING (RX_SLICE_ALL ), +MLX5_SGMT_STR_ASSING (PRM_QUERY_QP ), +MLX5_SGMT_STR_ASSING (PRM_QUERY_CQ ), + MLX5_SGMT_STR_ASSING(PRM_QUERY_MKEY), };struct mlx5_rsc_dump {
include/linux/mlx5/rsc_dump.h +3 -0
@@ -23,6 +23,9 @@ enum mlx5_sgmt_type {MLX5_SGMT_TYPE_SX_SLICE_ALL ,MLX5_SGMT_TYPE_RDB ,MLX5_SGMT_TYPE_RX_SLICE_ALL , +MLX5_SGMT_TYPE_PRM_QUERY_QP , +MLX5_SGMT_TYPE_PRM_QUERY_CQ , +MLX5_SGMT_TYPE_PRM_QUERY_MKEY ,MLX5_SGMT_TYPE_MENU , MLX5_SGMT_TYPE_TERMINATE,
Signature · 1 line
2.26.2
PATCH v3 3/11 RDMA/core: Don't call fill_res_entry for PD
In reply to Leon RomanovskyFrom: Maor Gottlieb <[email protected]>
None of the vendor implement it, remove it.
--- drivers/infiniband/core/nldev.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-)
drivers/infiniband/core/nldev.c +1 -8
@@ -653,7 +653,6 @@ static int fill_res_pd_entry(struct sk_buff *msg, bool has_cap_net_admin, struct rdma_restrack_entry *res, uint32_t port) { struct ib_pd *pd = container_of(res, struct ib_pd, res); -struct ib_device *dev = pd->device;if (has_cap_net_admin) { if (nla_put_u32(msg, RDMA_NLDEV_ATTR_RES_LOCAL_DMA_LKEY,
@@ -676,13 +675,7 @@ static int fill_res_pd_entry(struct sk_buff *msg, bool has_cap_net_admin, pd->uobject->context->res.id)) goto err; -if (fill_res_name_pid (msg, res)) - goto err; - -if (fill_res_entry (dev, msg, res)) - goto err; - -return 0 ; +return fill_res_name_pid (msg, res); err:return -EMSGSIZE ; }
Signature · 1 line
2.26.2
PATCH v3 4/11 RDMA: Add dedicated MR resource tracker function
In reply to Leon RomanovskyFrom: Maor Gottlieb <[email protected]>
In order to avoid double multiplexing of the resource when it's MR, add a dedicated callback function.
--- drivers/infiniband/core/device.c | 3 ++- drivers/infiniband/core/nldev.c | 18 ++++------------- drivers/infiniband/hw/cxgb4/iw_cxgb4.h | 1 + drivers/infiniband/hw/cxgb4/provider.c | 1 + drivers/infiniband/hw/cxgb4/restrack.c | 5 +---- drivers/infiniband/hw/mlx5/main.c | 4 ++-- drivers/infiniband/hw/mlx5/mlx5_ib.h | 6 ++---- drivers/infiniband/hw/mlx5/restrack.c | 28 ++++---------------------- include/rdma/ib_verbs.h | 4 ++-- 9 files changed, 19 insertions(+), 51 deletions(-)
drivers/infiniband/core/device.c +2 -1
@@ -2618,7 +2618,8 @@ void ib_set_device_ops(struct ib_device *dev, const struct ib_device_ops *ops)SET_DEVICE_OP (dev_ops, drain_sq);SET_DEVICE_OP (dev_ops, enable_driver);SET_DEVICE_OP (dev_ops, fill_res_entry); -SET_DEVICE_OP (dev_ops, fill_stat_entry); +SET_DEVICE_OP (dev_ops, fill_res_mr_entry); +SET_DEVICE_OP (dev_ops, fill_stat_mr_entry);SET_DEVICE_OP (dev_ops, get_dev_fw_str);SET_DEVICE_OP (dev_ops, get_dma_mr);SET_DEVICE_OP (dev_ops, get_hw_stats);
drivers/infiniband/core/nldev.c +4 -14
@@ -454,14 +454,6 @@ static bool fill_res_entry(struct ib_device *dev, struct sk_buff *msg,return dev->ops.fill_res_entry (msg, res); } -static bool fill_stat_entry (struct ib_device *dev,struct sk_buff *msg, -struct rdma_restrack_entry *res) -{ -if (!dev->ops.fill_stat_entry) -return false; -return dev->ops.fill_stat_entry (msg, res); -} -static int fill_res_qp_entry (struct sk_buff *msg,bool has_cap_net_admin,struct rdma_restrack_entry *res,uint32_t port) {
@@ -641,9 +633,8 @@ static int fill_res_mr_entry(struct sk_buff *msg, bool has_cap_net_admin,if (fill_res_name_pid (msg, res)) goto err; -if (fill_res_entry (dev, msg, res)) - goto err; - +if (dev->ops.fill_res_mr_entry) +return dev->ops.fill_res_mr_entry (msg, mr);return 0 ; err:return -EMSGSIZE ;
@@ -786,9 +777,8 @@ static int fill_stat_mr_entry(struct sk_buff *msg, bool has_cap_net_admin,if (nla_put_u32 (msg,RDMA_NLDEV_ATTR_RES_MRN , res->id)) goto err; -if (fill_stat_entry (dev, msg, res)) - goto err; - +if (dev->ops.fill_stat_mr_entry) +return dev->ops.fill_stat_mr_entry (msg, mr);return 0 ; err:
drivers/infiniband/hw/cxgb4/iw_cxgb4.h +1 -0
@@ -1055,6 +1055,7 @@ struct c4iw_wr_wait *c4iw_alloc_wr_wait(gfp_t gfp);typedef int c4iw_restrack_func (struct sk_buff *msg,struct rdma_restrack_entry *res); +int c4iw_fill_res_mr_entry (struct sk_buff *msg,struct ib_mr *ibmr);extern c4iw_restrack_func *c4iw_restrack_funcs[RDMA_RESTRACK_MAX ];#endif
drivers/infiniband/hw/cxgb4/provider.c +1 -0
@@ -486,6 +486,7 @@ static const struct ib_device_ops c4iw_dev_ops = { .destroy_qp = c4iw_destroy_qp, .destroy_srq = c4iw_destroy_srq, .fill_res_entry = fill_res_entry, + .fill_res_mr_entry = c4iw_fill_res_mr_entry, .get_dev_fw_str = get_dev_fw_str, .get_dma_mr = c4iw_get_dma_mr, .get_hw_stats = c4iw_get_mib,
drivers/infiniband/hw/cxgb4/restrack.c +1 -4
@@ -433,10 +433,8 @@ static int fill_res_cq_entry(struct sk_buff *msg,return -EMSGSIZE ; } -static int fill_res_mr_entry (struct sk_buff *msg, -struct rdma_restrack_entry *res) +int c4iw_fill_res_mr_entry (struct sk_buff *msg,struct ib_mr *ibmr) { - struct ib_mr *ibmr = container_of(res, struct ib_mr, res);struct c4iw_mr *mhp =to_c4iw_mr (ibmr);struct c4iw_dev *dev = mhp->rhp;u32 stag = mhp->attr.stag;
@@ -497,5 +495,4 @@ c4iw_restrack_func *c4iw_restrack_funcs[RDMA_RESTRACK_MAX] = { [RDMA_RESTRACK_QP] = fill_res_qp_entry, [RDMA_RESTRACK_CM_ID] = fill_res_ep_entry, [RDMA_RESTRACK_CQ] = fill_res_cq_entry, - [RDMA_RESTRACK_MR] = fill_res_mr_entry, };
drivers/infiniband/hw/mlx5/main.c +2 -2
@@ -6598,8 +6598,8 @@ static const struct ib_device_ops mlx5_ib_dev_ops = { .drain_rq = mlx5_ib_drain_rq, .drain_sq = mlx5_ib_drain_sq, .enable_driver = mlx5_ib_enable_driver, - .fill_res_entry = mlx5_ib_fill_res_entry, - .fill_stat_entry = mlx5_ib_fill_stat_entry, + .fill_res_mr_entry = mlx5_ib_fill_res_mr_entry, + .fill_stat_mr_entry = mlx5_ib_fill_stat_mr_entry, .get_dev_fw_str = get_dev_fw_str, .get_dma_mr = mlx5_ib_get_dma_mr, .get_link_layer = mlx5_ib_port_link_layer,
drivers/infiniband/hw/mlx5/mlx5_ib.h +2 -4
@@ -1375,10 +1375,8 @@ struct mlx5_core_dev *mlx5_ib_get_native_port_mdev(struct mlx5_ib_dev *dev, u8 *native_port_num);void mlx5_ib_put_native_port_mdev (struct mlx5_ib_dev *dev,u8 port_num); -int mlx5_ib_fill_res_entry (struct sk_buff *msg, -struct rdma_restrack_entry *res); -int mlx5_ib_fill_stat_entry (struct sk_buff *msg, -struct rdma_restrack_entry *res); +int mlx5_ib_fill_res_mr_entry (struct sk_buff *msg,struct ib_mr *ib_mr); +int mlx5_ib_fill_stat_mr_entry (struct sk_buff *msg,struct ib_mr *ib_mr);extern const struct uapi_definition mlx5_ib_devx_defs[];extern const struct uapi_definition mlx5_ib_flow_defs[];
drivers/infiniband/hw/mlx5/restrack.c +4 -24
@@ -8,10 +8,9 @@#include <rdma/restrack.h> #include "mlx5_ib.h" -static int fill_stat_mr_entry (struct sk_buff *msg, -struct rdma_restrack_entry *res) +int mlx5_ib_fill_stat_mr_entry (struct sk_buff *msg, +struct ib_mr *ibmr) { - struct ib_mr *ibmr = container_of(res, struct ib_mr, res);struct mlx5_ib_mr *mr =to_mmr (ibmr);struct nlattr *table_attr;
@@ -41,10 +40,9 @@ static int fill_stat_mr_entry(struct sk_buff *msg,return -EMSGSIZE ; } -static int fill_res_mr_entry (struct sk_buff *msg, -struct rdma_restrack_entry *res) +int mlx5_ib_fill_res_mr_entry (struct sk_buff *msg, +struct ib_mr *ibmr) { - struct ib_mr *ibmr = container_of(res, struct ib_mr, res);struct mlx5_ib_mr *mr =to_mmr (ibmr);struct nlattr *table_attr;
@@ -70,21 +68,3 @@ static int fill_res_mr_entry(struct sk_buff *msg,nla_nest_cancel (msg, table_attr);return -EMSGSIZE ; } - -int mlx5_ib_fill_res_entry (struct sk_buff *msg, -struct rdma_restrack_entry *res) -{ -if (res->type ==RDMA_RESTRACK_MR ) -return fill_res_mr_entry (msg, res); - -return 0 ; -} - -int mlx5_ib_fill_stat_entry (struct sk_buff *msg, -struct rdma_restrack_entry *res) -{ -if (res->type ==RDMA_RESTRACK_MR ) -return fill_stat_mr_entry (msg, res); - -return 0 ; -}
include/rdma/ib_verbs.h +2 -2
@@ -2584,6 +2584,7 @@ struct ib_device_ops {*/ int (*fill_res_entry)(struct sk_buff *msg,struct rdma_restrack_entry *entry); +int (*fill_res_mr_entry)(struct sk_buff *msg,struct ib_mr *ibmr);/* Device lifecycle callbacks */ /*
@@ -2638,8 +2639,7 @@ struct ib_device_ops {* Allows rdma drivers to add their own restrack attributes * dumped via 'rdma stat' iproute2 command. */ -int (*fill_stat_entry)(struct sk_buff *msg, -struct rdma_restrack_entry *entry); +int (*fill_stat_mr_entry)(struct sk_buff *msg,struct ib_mr *ibmr);DECLARE_RDMA_OBJ_SIZE (ib_ah);DECLARE_RDMA_OBJ_SIZE (ib_cq);
Signature · 1 line
2.26.2
PATCH v3 5/11 RDMA: Add a dedicated CQ resource tracker function
In reply to Leon RomanovskyFrom: Maor Gottlieb <[email protected]>
In order to avoid double multiplexing of the resource when it's CQ, add a dedicated callback function.
--- drivers/infiniband/core/device.c | 1 + drivers/infiniband/core/nldev.c | 5 ++--- drivers/infiniband/hw/cxgb4/iw_cxgb4.h | 1 + drivers/infiniband/hw/cxgb4/provider.c | 1 + drivers/infiniband/hw/cxgb4/restrack.c | 5 +---- drivers/infiniband/hw/hns/hns_roce_device.h | 4 ++-- drivers/infiniband/hw/hns/hns_roce_main.c | 2 +- drivers/infiniband/hw/hns/hns_roce_restrack.c | 14 ++------------ include/rdma/ib_verbs.h | 1 + 9 files changed, 12 insertions(+), 22 deletions(-)
drivers/infiniband/core/device.c +1 -0
@@ -2617,6 +2617,7 @@ void ib_set_device_ops(struct ib_device *dev, const struct ib_device_ops *ops)SET_DEVICE_OP (dev_ops, drain_rq);SET_DEVICE_OP (dev_ops, drain_sq);SET_DEVICE_OP (dev_ops, enable_driver); +SET_DEVICE_OP (dev_ops, fill_res_cq_entry);SET_DEVICE_OP (dev_ops, fill_res_entry);SET_DEVICE_OP (dev_ops, fill_res_mr_entry);SET_DEVICE_OP (dev_ops, fill_stat_mr_entry);
drivers/infiniband/core/nldev.c +2 -3
@@ -598,9 +598,8 @@ static int fill_res_cq_entry(struct sk_buff *msg, bool has_cap_net_admin,if (fill_res_name_pid (msg, res)) goto err; -if (fill_res_entry (dev, msg, res)) - goto err; - +if (dev->ops.fill_res_cq_entry) +return dev->ops.fill_res_cq_entry (msg, cq);return 0 ; err:return -EMSGSIZE ;
drivers/infiniband/hw/cxgb4/iw_cxgb4.h +1 -0
@@ -1056,6 +1056,7 @@ struct c4iw_wr_wait *c4iw_alloc_wr_wait(gfp_t gfp);typedef int c4iw_restrack_func (struct sk_buff *msg,struct rdma_restrack_entry *res);int c4iw_fill_res_mr_entry (struct sk_buff *msg,struct ib_mr *ibmr); +int c4iw_fill_res_cq_entry (struct sk_buff *msg,struct ib_cq *ibcq);extern c4iw_restrack_func *c4iw_restrack_funcs[RDMA_RESTRACK_MAX ];#endif
drivers/infiniband/hw/cxgb4/provider.c +1 -0
@@ -485,6 +485,7 @@ static const struct ib_device_ops c4iw_dev_ops = { .destroy_cq = c4iw_destroy_cq, .destroy_qp = c4iw_destroy_qp, .destroy_srq = c4iw_destroy_srq, + .fill_res_cq_entry = c4iw_fill_res_cq_entry, .fill_res_entry = fill_res_entry, .fill_res_mr_entry = c4iw_fill_res_mr_entry, .get_dev_fw_str = get_dev_fw_str,
drivers/infiniband/hw/cxgb4/restrack.c +1 -4
@@ -372,10 +372,8 @@ static int fill_swcqes(struct sk_buff *msg, struct t4_cq *cq,return -EMSGSIZE ; } -static int fill_res_cq_entry (struct sk_buff *msg, -struct rdma_restrack_entry *res) +int c4iw_fill_res_cq_entry (struct sk_buff *msg,struct ib_cq *ibcq) { - struct ib_cq *ibcq = container_of(res, struct ib_cq, res);struct c4iw_cq *chp =to_c4iw_cq (ibcq);struct nlattr *table_attr;struct t4_cqe hwcqes[2 ];
@@ -494,5 +492,4 @@ int c4iw_fill_res_mr_entry(struct sk_buff *msg, struct ib_mr *ibmr)c4iw_restrack_func *c4iw_restrack_funcs[RDMA_RESTRACK_MAX ] = { [RDMA_RESTRACK_QP ] = fill_res_qp_entry, [RDMA_RESTRACK_CM_ID ] = fill_res_ep_entry, - [RDMA_RESTRACK_CQ ] = fill_res_cq_entry, };
drivers/infiniband/hw/hns/hns_roce_device.h +2 -2
@@ -1267,6 +1267,6 @@ void hns_roce_handle_device_err(struct hns_roce_dev *hr_dev);int hns_roce_init (struct hns_roce_dev *hr_dev);void hns_roce_exit (struct hns_roce_dev *hr_dev); -int hns_roce_fill_res_entry (struct sk_buff *msg, -struct rdma_restrack_entry *res); +int hns_roce_fill_res_cq_entry (struct sk_buff *msg, +struct ib_cq *ib_cq);#endif /* _HNS_ROCE_DEVICE_H */
drivers/infiniband/hw/hns/hns_roce_main.c +1 -1
@@ -428,7 +428,7 @@ static const struct ib_device_ops hns_roce_dev_ops = { .destroy_ah = hns_roce_destroy_ah, .destroy_cq = hns_roce_destroy_cq, .disassociate_ucontext = hns_roce_disassociate_ucontext, - .fill_res_entry = hns_roce_fill_res_entry, + .fill_res_cq_entry = hns_roce_fill_res_cq_entry, .get_dma_mr = hns_roce_get_dma_mr, .get_link_layer = hns_roce_get_link_layer, .get_port_immutable = hns_roce_port_immutable,
drivers/infiniband/hw/hns/hns_roce_restrack.c +2 -12
@@ -76,10 +76,9 @@ static int hns_roce_fill_cq(struct sk_buff *msg,return -EMSGSIZE ; } -static int hns_roce_fill_res_cq_entry (struct sk_buff *msg, -struct rdma_restrack_entry *res) +int hns_roce_fill_res_cq_entry (struct sk_buff *msg, +struct ib_cq *ib_cq) { - struct ib_cq *ib_cq = container_of(res, struct ib_cq, res);struct hns_roce_dev *hr_dev =to_hr_dev (ib_cq->device);struct hns_roce_cq *hr_cq =to_hr_cq (ib_cq);struct hns_roce_v2_cq_context *context;
@@ -119,12 +118,3 @@ static int hns_roce_fill_res_cq_entry(struct sk_buff *msg,kfree (context);return ret; } - -int hns_roce_fill_res_entry (struct sk_buff *msg, -struct rdma_restrack_entry *res) -{ -if (res->type ==RDMA_RESTRACK_CQ ) -return hns_roce_fill_res_cq_entry (msg, res); - -return 0 ; -}
include/rdma/ib_verbs.h +1 -0
@@ -2585,6 +2585,7 @@ struct ib_device_ops {int (*fill_res_entry)(struct sk_buff *msg,struct rdma_restrack_entry *entry);int (*fill_res_mr_entry)(struct sk_buff *msg,struct ib_mr *ibmr); +int (*fill_res_cq_entry)(struct sk_buff *msg,struct ib_cq *ibcq);/* Device lifecycle callbacks */ /*
Signature · 1 line
2.26.2
PATCH v3 6/11 RDMA: Add dedicated QP resource tracker function
In reply to Leon RomanovskyFrom: Maor Gottlieb <[email protected]>
In order to avoid double multiplexing of the resource when it's QP, add a dedicated callback function.
--- drivers/infiniband/core/device.c | 1 + drivers/infiniband/core/nldev.c | 5 ++--- drivers/infiniband/hw/cxgb4/iw_cxgb4.h | 1 + drivers/infiniband/hw/cxgb4/restrack.c | 5 +---- include/rdma/ib_verbs.h | 1 + 5 files changed, 6 insertions(+), 7 deletions(-)
drivers/infiniband/core/device.c +1 -0
@@ -2620,6 +2620,7 @@ void ib_set_device_ops(struct ib_device *dev, const struct ib_device_ops *ops)SET_DEVICE_OP (dev_ops, fill_res_cq_entry);SET_DEVICE_OP (dev_ops, fill_res_entry);SET_DEVICE_OP (dev_ops, fill_res_mr_entry); +SET_DEVICE_OP (dev_ops, fill_res_qp_entry);SET_DEVICE_OP (dev_ops, fill_stat_mr_entry);SET_DEVICE_OP (dev_ops, get_dev_fw_str);SET_DEVICE_OP (dev_ops, get_dma_mr);
drivers/infiniband/core/nldev.c +2 -3
@@ -507,9 +507,8 @@ static int fill_res_qp_entry(struct sk_buff *msg, bool has_cap_net_admin,if (fill_res_name_pid (msg, res)) goto err; -if (fill_res_entry (dev, msg, res)) - goto err; - +if (dev->ops.fill_res_qp_entry) +return dev->ops.fill_res_qp_entry (msg, qp);return 0 ; err:return -EMSGSIZE ;
drivers/infiniband/hw/cxgb4/iw_cxgb4.h +1 -0
@@ -1057,6 +1057,7 @@ typedef int c4iw_restrack_func(struct sk_buff *msg, struct rdma_restrack_entry *res);int c4iw_fill_res_mr_entry (struct sk_buff *msg,struct ib_mr *ibmr);int c4iw_fill_res_cq_entry (struct sk_buff *msg,struct ib_cq *ibcq); +int c4iw_fill_res_qp_entry (struct sk_buff *msg,struct ib_qp *ibqp);extern c4iw_restrack_func *c4iw_restrack_funcs[RDMA_RESTRACK_MAX ];#endif
drivers/infiniband/hw/cxgb4/restrack.c +1 -4
@@ -134,10 +134,8 @@ static int fill_swsqes(struct sk_buff *msg, struct t4_sq *sq,return -EMSGSIZE ; } -static int fill_res_qp_entry (struct sk_buff *msg, -struct rdma_restrack_entry *res) +int c4iw_fill_res_qp_entry (struct sk_buff *msg,struct ib_qp *ibqp) { - struct ib_qp *ibqp = container_of(res, struct ib_qp, res);struct t4_swsqe *fsp =NULL , *lsp =NULL ;struct c4iw_qp *qhp =to_c4iw_qp (ibqp);u16 first_sq_idx =0 , last_sq_idx =0 ;
@@ -490,6 +488,5 @@ int c4iw_fill_res_mr_entry(struct sk_buff *msg, struct ib_mr *ibmr) }c4iw_restrack_func *c4iw_restrack_funcs[RDMA_RESTRACK_MAX ] = { - [RDMA_RESTRACK_QP ] = fill_res_qp_entry, [RDMA_RESTRACK_CM_ID ] = fill_res_ep_entry, };
include/rdma/ib_verbs.h +1 -0
@@ -2586,6 +2586,7 @@ struct ib_device_ops { struct rdma_restrack_entry *entry);int (*fill_res_mr_entry)(struct sk_buff *msg,struct ib_mr *ibmr);int (*fill_res_cq_entry)(struct sk_buff *msg,struct ib_cq *ibcq); +int (*fill_res_qp_entry)(struct sk_buff *msg,struct ib_qp *ibqp);/* Device lifecycle callbacks */ /*
Signature · 1 line
2.26.2
PATCH v3 7/11 RDMA: Add dedicated CM_ID resource tracker function
In reply to Leon RomanovskyFrom: Maor Gottlieb <[email protected]>
In order to avoid double multiplexing of the resource when it's cm id, add a dedicated callback function.
In addition remove fill_res_entry which is not used anymore.
--- drivers/infiniband/core/device.c | 2 +- drivers/infiniband/core/nldev.c | 13 ++----------- drivers/infiniband/hw/cxgb4/iw_cxgb4.h | 4 +--- drivers/infiniband/hw/cxgb4/provider.c | 9 +-------- drivers/infiniband/hw/cxgb4/restrack.c | 9 ++------- include/rdma/ib_verbs.h | 4 ++-- 6 files changed, 9 insertions(+), 32 deletions(-)
drivers/infiniband/core/device.c +1 -1
@@ -2617,8 +2617,8 @@ void ib_set_device_ops(struct ib_device *dev, const struct ib_device_ops *ops)SET_DEVICE_OP (dev_ops, drain_rq);SET_DEVICE_OP (dev_ops, drain_sq);SET_DEVICE_OP (dev_ops, enable_driver); +SET_DEVICE_OP (dev_ops, fill_res_cm_id_entry);SET_DEVICE_OP (dev_ops, fill_res_cq_entry); -SET_DEVICE_OP (dev_ops, fill_res_entry);SET_DEVICE_OP (dev_ops, fill_res_mr_entry);SET_DEVICE_OP (dev_ops, fill_res_qp_entry);SET_DEVICE_OP (dev_ops, fill_stat_mr_entry);
drivers/infiniband/core/nldev.c +2 -11
@@ -446,14 +446,6 @@ static int fill_res_name_pid(struct sk_buff *msg,return err ? -EMSGSIZE :0 ; } -static bool fill_res_entry (struct ib_device *dev,struct sk_buff *msg, -struct rdma_restrack_entry *res) -{ -if (!dev->ops.fill_res_entry) -return false; -return dev->ops.fill_res_entry (msg, res); -} -static int fill_res_qp_entry (struct sk_buff *msg,bool has_cap_net_admin,struct rdma_restrack_entry *res,uint32_t port) {
@@ -559,9 +551,8 @@ static int fill_res_cm_id_entry(struct sk_buff *msg, bool has_cap_net_admin,if (fill_res_name_pid (msg, res)) goto err; -if (fill_res_entry (dev, msg, res)) - goto err; - +if (dev->ops.fill_res_cm_id_entry) +return dev->ops.fill_res_cm_id_entry (msg, cm_id);return 0 ; err:return -EMSGSIZE ;
drivers/infiniband/hw/cxgb4/iw_cxgb4.h +1 -3
@@ -1053,11 +1053,9 @@ int c4iw_post_srq_recv(struct ib_srq *ibsrq, const struct ib_recv_wr *wr, const struct ib_recv_wr **bad_wr);struct c4iw_wr_wait *c4iw_alloc_wr_wait (gfp_t gfp); -typedef int c4iw_restrack_func (struct sk_buff *msg, -struct rdma_restrack_entry *res);int c4iw_fill_res_mr_entry (struct sk_buff *msg,struct ib_mr *ibmr);int c4iw_fill_res_cq_entry (struct sk_buff *msg,struct ib_cq *ibcq);int c4iw_fill_res_qp_entry (struct sk_buff *msg,struct ib_qp *ibqp); -extern c4iw_restrack_func *c4iw_restrack_funcs[RDMA_RESTRACK_MAX ]; +int c4iw_fill_res_cm_id_entry (struct sk_buff *msg,struct rdma_cm_id *cm_id);#endif
drivers/infiniband/hw/cxgb4/provider.c +1 -8
@@ -458,13 +458,6 @@ static void get_dev_fw_str(struct ib_device *dev, char *str) FW_HDR_FW_VER_BUILD_G(c4iw_dev->rdev.lldi.fw_vers)); } -static int fill_res_entry (struct sk_buff *msg,struct rdma_restrack_entry *res) -{ -return (res->type <ARRAY_SIZE (c4iw_restrack_funcs) && - c4iw_restrack_funcs[res->type]) ? - c4iw_restrack_funcs[res->type](msg, res) :0 ; -} -static const struct ib_device_ops c4iw_dev_ops = { .owner =THIS_MODULE , .driver_id =RDMA_DRIVER_CXGB4 ,
@@ -486,7 +479,7 @@ static const struct ib_device_ops c4iw_dev_ops = { .destroy_qp = c4iw_destroy_qp, .destroy_srq = c4iw_destroy_srq, .fill_res_cq_entry = c4iw_fill_res_cq_entry, - .fill_res_entry = fill_res_entry, + .fill_res_cm_id_entry = c4iw_fill_res_cm_id_entry, .fill_res_mr_entry = c4iw_fill_res_mr_entry, .get_dev_fw_str = get_dev_fw_str, .get_dma_mr = c4iw_get_dma_mr,
drivers/infiniband/hw/cxgb4/restrack.c +2 -7
@@ -193,10 +193,9 @@ union union_ep {struct c4iw_ep ep; }; -static int fill_res_ep_entry (struct sk_buff *msg, -struct rdma_restrack_entry *res) +int c4iw_fill_res_cm_id_entry (struct sk_buff *msg, +struct rdma_cm_id *cm_id) { -struct rdma_cm_id *cm_id =rdma_res_to_id (res);struct nlattr *table_attr;struct c4iw_ep_common *epcp;struct c4iw_listen_ep *listen_ep =NULL ;
@@ -486,7 +485,3 @@ int c4iw_fill_res_mr_entry(struct sk_buff *msg, struct ib_mr *ibmr) err:return -EMSGSIZE ; } - -c4iw_restrack_func *c4iw_restrack_funcs[RDMA_RESTRACK_MAX ] = { - [RDMA_RESTRACK_CM_ID ] = fill_res_ep_entry, -};
include/rdma/ib_verbs.h +2 -2
@@ -75,6 +75,7 @@ struct ib_umem_odp;struct ib_uqp_object ;struct ib_usrq_object ;struct ib_uwq_object ; +struct rdma_cm_id ;extern struct workqueue_struct *ib_wq;extern struct workqueue_struct *ib_comp_wq;
@@ -2582,11 +2583,10 @@ struct ib_device_ops {/** * Allows rdma drivers to add their own restrack attributes. */ -int (*fill_res_entry)(struct sk_buff *msg, -struct rdma_restrack_entry *entry);int (*fill_res_mr_entry)(struct sk_buff *msg,struct ib_mr *ibmr);int (*fill_res_cq_entry)(struct sk_buff *msg,struct ib_cq *ibcq);int (*fill_res_qp_entry)(struct sk_buff *msg,struct ib_qp *ibqp); +int (*fill_res_cm_id_entry)(struct sk_buff *msg,struct rdma_cm_id *id);/* Device lifecycle callbacks */ /*
Signature · 1 line
2.26.2
PATCH v3 8/11 RDMA: Add support to dump resource tracker in RAW format
In reply to Leon RomanovskyFrom: Maor Gottlieb <[email protected]>
Add support to get resource dump in raw format. It enable vendors to return the entire QP/CQ/MR context without a need from the vendor to set each field separately.
When user request to get the data in RAW, we return as key value the generic fields which not require to query the vendor and in addition we return the rest of the data as binary.
Example:
$rdma res show mr dev mlx5_1 mrn 2 -r -j [{"ifindex":7,"ifname":"mlx5_1", "data":[0,4,255,254,0,0,0,0,0,0,0,0,16,28,0,216,...]}]
--- drivers/infiniband/core/device.c | 3 + drivers/infiniband/core/nldev.c | 182 ++++++++++++++++++++----------- include/rdma/ib_verbs.h | 3 + include/uapi/rdma/rdma_netlink.h | 8 ++ 4 files changed, 134 insertions(+), 62 deletions(-)
drivers/infiniband/core/device.c +3 -0
@@ -2619,8 +2619,11 @@ void ib_set_device_ops(struct ib_device *dev, const struct ib_device_ops *ops)SET_DEVICE_OP (dev_ops, enable_driver);SET_DEVICE_OP (dev_ops, fill_res_cm_id_entry);SET_DEVICE_OP (dev_ops, fill_res_cq_entry); +SET_DEVICE_OP (dev_ops, fill_res_cq_entry_raw);SET_DEVICE_OP (dev_ops, fill_res_mr_entry); +SET_DEVICE_OP (dev_ops, fill_res_mr_entry_raw);SET_DEVICE_OP (dev_ops, fill_res_qp_entry); +SET_DEVICE_OP (dev_ops, fill_res_qp_entry_raw);SET_DEVICE_OP (dev_ops, fill_stat_mr_entry);SET_DEVICE_OP (dev_ops, get_dev_fw_str);SET_DEVICE_OP (dev_ops, get_dma_mr);
drivers/infiniband/core/nldev.c +120 -62
335 lines not on this page · raw message
include/rdma/ib_verbs.h +3 -0
@@ -2584,8 +2584,11 @@ struct ib_device_ops {* Allows rdma drivers to add their own restrack attributes. */ int (*fill_res_mr_entry)(struct sk_buff *msg,struct ib_mr *ibmr); +int (*fill_res_mr_entry_raw)(struct sk_buff *msg,struct ib_mr *ibmr);int (*fill_res_cq_entry)(struct sk_buff *msg,struct ib_cq *ibcq); +int (*fill_res_cq_entry_raw)(struct sk_buff *msg,struct ib_cq *ibcq);int (*fill_res_qp_entry)(struct sk_buff *msg,struct ib_qp *ibqp); +int (*fill_res_qp_entry_raw)(struct sk_buff *msg,struct ib_qp *ibqp);int (*fill_res_cm_id_entry)(struct sk_buff *msg,struct rdma_cm_id *id);/* Device lifecycle callbacks */
include/uapi/rdma/rdma_netlink.h +8 -0
@@ -287,6 +287,12 @@ enum rdma_nldev_command {RDMA_NLDEV_CMD_STAT_DEL , +RDMA_NLDEV_CMD_RES_QP_GET_RAW , + +RDMA_NLDEV_CMD_RES_CQ_GET_RAW , + +RDMA_NLDEV_CMD_RES_MR_GET_RAW , + RDMA_NLDEV_NUM_OPS };
@@ -525,6 +531,8 @@ enum rdma_nldev_attr {*/ RDMA_NLDEV_ATTR_DEV_DIM ,/* u8 */ + RDMA_NLDEV_ATTR_RES_RAW, /* binary */ +/* * Always the end */
--
2.26.2
PATCH v3 9/11 RDMA/mlx5: Add support to get QP resource in RAW format
In reply to Leon RomanovskyFrom: Maor Gottlieb <[email protected]>
Add a generic function that use the resource dump mechanism to get the resource data. This patch adds the support to QP.
--- drivers/infiniband/hw/mlx5/main.c | 1 + drivers/infiniband/hw/mlx5/mlx5_ib.h | 1 + drivers/infiniband/hw/mlx5/restrack.c | 77 +++++++++++++++++++++++++++ 3 files changed, 79 insertions(+)
drivers/infiniband/hw/mlx5/main.c +1 -0
@@ -6599,6 +6599,7 @@ static const struct ib_device_ops mlx5_ib_dev_ops = { .drain_sq = mlx5_ib_drain_sq, .enable_driver = mlx5_ib_enable_driver, .fill_res_mr_entry = mlx5_ib_fill_res_mr_entry, + .fill_res_qp_entry_raw = mlx5_ib_fill_res_qp_entry_raw, .fill_stat_mr_entry = mlx5_ib_fill_stat_mr_entry, .get_dev_fw_str = get_dev_fw_str, .get_dma_mr = mlx5_ib_get_dma_mr,
drivers/infiniband/hw/mlx5/mlx5_ib.h +1 -0
@@ -1376,6 +1376,7 @@ struct mlx5_core_dev *mlx5_ib_get_native_port_mdev(struct mlx5_ib_dev *dev,void mlx5_ib_put_native_port_mdev (struct mlx5_ib_dev *dev,u8 port_num);int mlx5_ib_fill_res_mr_entry (struct sk_buff *msg,struct ib_mr *ib_mr); +int mlx5_ib_fill_res_qp_entry_raw (struct sk_buff *msg,struct ib_qp *ibqp);int mlx5_ib_fill_stat_mr_entry (struct sk_buff *msg,struct ib_mr *ib_mr);extern const struct uapi_definition mlx5_ib_devx_defs[];
drivers/infiniband/hw/mlx5/restrack.c +77 -0
90 lines not on this page · raw message
Signature · 1 line
2.26.2
PATCH v3 10/11 RDMA/mlx5: Add support to get CQ resource in RAW format
In reply to Leon RomanovskyFrom: Maor Gottlieb <[email protected]>
Add support to get CQ resource dump in RAW format.
--- drivers/infiniband/hw/mlx5/main.c | 1 + drivers/infiniband/hw/mlx5/mlx5_ib.h | 1 + drivers/infiniband/hw/mlx5/restrack.c | 8 ++++++++ 3 files changed, 10 insertions(+)
drivers/infiniband/hw/mlx5/main.c +1 -0
@@ -6598,6 +6598,7 @@ static const struct ib_device_ops mlx5_ib_dev_ops = { .drain_rq = mlx5_ib_drain_rq, .drain_sq = mlx5_ib_drain_sq, .enable_driver = mlx5_ib_enable_driver, + .fill_res_cq_entry_raw = mlx5_ib_fill_res_cq_entry_raw, .fill_res_mr_entry = mlx5_ib_fill_res_mr_entry, .fill_res_qp_entry_raw = mlx5_ib_fill_res_qp_entry_raw, .fill_stat_mr_entry = mlx5_ib_fill_stat_mr_entry,
drivers/infiniband/hw/mlx5/mlx5_ib.h +1 -0
@@ -1377,6 +1377,7 @@ void mlx5_ib_put_native_port_mdev(struct mlx5_ib_dev *dev, u8 port_num);int mlx5_ib_fill_res_mr_entry (struct sk_buff *msg,struct ib_mr *ib_mr);int mlx5_ib_fill_res_qp_entry_raw (struct sk_buff *msg,struct ib_qp *ibqp); +int mlx5_ib_fill_res_cq_entry_raw (struct sk_buff *msg,struct ib_cq *ibcq);int mlx5_ib_fill_stat_mr_entry (struct sk_buff *msg,struct ib_mr *ib_mr);extern const struct uapi_definition mlx5_ib_devx_defs[];
drivers/infiniband/hw/mlx5/restrack.c +8 -0
@@ -138,6 +138,14 @@ int mlx5_ib_fill_res_mr_entry(struct sk_buff *msg,return -EMSGSIZE ; } +int mlx5_ib_fill_res_cq_entry_raw (struct sk_buff *msg,struct ib_cq *ibcq) +{ +struct mlx5_ib_dev *dev =to_mdev (ibcq->device); +struct mlx5_ib_cq *cq =to_mcq (ibcq); + +return fill_res_raw (msg, dev,MLX5_SGMT_TYPE_PRM_QUERY_CQ , cq->mcq.cqn); +} +int mlx5_ib_fill_res_qp_entry_raw (struct sk_buff *msg,struct ib_qp *ibqp) {struct mlx5_ib_dev *dev =to_mdev (ibqp->device);
Signature · 1 line
2.26.2
PATCH v3 11/11 RDMA/mlx5: Add support to get MR resource in RAW format
In reply to Leon RomanovskyFrom: Maor Gottlieb <[email protected]>
Add support to get MR (mkey) resource dump in RAW format.
--- drivers/infiniband/hw/mlx5/main.c | 1 + drivers/infiniband/hw/mlx5/mlx5_ib.h | 1 + drivers/infiniband/hw/mlx5/restrack.c | 8 ++++++++ 3 files changed, 10 insertions(+)
drivers/infiniband/hw/mlx5/main.c +1 -0
@@ -6600,6 +6600,7 @@ static const struct ib_device_ops mlx5_ib_dev_ops = { .enable_driver = mlx5_ib_enable_driver, .fill_res_cq_entry_raw = mlx5_ib_fill_res_cq_entry_raw, .fill_res_mr_entry = mlx5_ib_fill_res_mr_entry, + .fill_res_mr_entry_raw = mlx5_ib_fill_res_mr_entry_raw, .fill_res_qp_entry_raw = mlx5_ib_fill_res_qp_entry_raw, .fill_stat_mr_entry = mlx5_ib_fill_stat_mr_entry, .get_dev_fw_str = get_dev_fw_str,
drivers/infiniband/hw/mlx5/mlx5_ib.h +1 -0
@@ -1376,6 +1376,7 @@ struct mlx5_core_dev *mlx5_ib_get_native_port_mdev(struct mlx5_ib_dev *dev,void mlx5_ib_put_native_port_mdev (struct mlx5_ib_dev *dev,u8 port_num);int mlx5_ib_fill_res_mr_entry (struct sk_buff *msg,struct ib_mr *ib_mr); +int mlx5_ib_fill_res_mr_entry_raw (struct sk_buff *msg,struct ib_mr *ib_mr);int mlx5_ib_fill_res_qp_entry_raw (struct sk_buff *msg,struct ib_qp *ibqp);int mlx5_ib_fill_res_cq_entry_raw (struct sk_buff *msg,struct ib_cq *ibcq);int mlx5_ib_fill_stat_mr_entry (struct sk_buff *msg,struct ib_mr *ib_mr);
drivers/infiniband/hw/mlx5/restrack.c +8 -0
@@ -109,6 +109,14 @@ int mlx5_ib_fill_stat_mr_entry(struct sk_buff *msg,return -EMSGSIZE ; } +int mlx5_ib_fill_res_mr_entry_raw (struct sk_buff *msg,struct ib_mr *ibmr) +{ +struct mlx5_ib_mr *mr =to_mmr (ibmr); + +return fill_res_raw (msg, mr->dev,MLX5_SGMT_TYPE_PRM_QUERY_MKEY , +mlx5_mkey_to_idx (mr->mmkey.key)); +} +int mlx5_ib_fill_res_mr_entry (struct sk_buff *msg,struct ib_mr *ibmr) {
Signature · 1 line
2.26.2
Quoted 24 lines · Leon Romanovsky
From: Leon Romanovsky <[email protected]>
Changelog:
v3:
* Rewrote query interface in patch "RDMA: Add support to dump resource tracker in RAW format"
v2:
https://lore.kernel.org/linux-rdma/[email protected]
* Converted to specific nldev ops for RAW.
* Rebased on top of v5.8-rc1.
v1:
https://lore.kernel.org/linux-rdma/[email protected]
* Maor dropped controversial change to dummy interface.
v0:
https://lore.kernel.org/linux-rdma/[email protected]Hi,
The following series adds support to get the RDMA resource data in RAW format. The main motivation for doing this is to enable vendors to return the entire QP/CQ/MR data without a need from the vendor to set each field separately.
Quoted 6 lines
Thanks
Maor Gottlieb (11):
net/mlx5: Export resource dump interface net/mlx5: Add support in query QP, CQ and MKEY segments
It looks OK can you apply these too the shared branch?
Thanks,
Jason
Leon Romanovsky
AppliedQuoted 25 lines · Jason Gunthorpe
Quoted 24 lines · Leon Romanovsky
From: Leon Romanovsky <[email protected]>
Changelog:
v3:
* Rewrote query interface in patch "RDMA: Add support to dump resource tracker in RAW format"
v2:
https://lore.kernel.org/linux-rdma/[email protected]
* Converted to specific nldev ops for RAW.
* Rebased on top of v5.8-rc1.
v1:
https://lore.kernel.org/linux-rdma/[email protected]
* Maor dropped controversial change to dummy interface.
v0:
https://lore.kernel.org/linux-rdma/[email protected]Hi,
The following series adds support to get the RDMA resource data in RAW format. The main motivation for doing this is to enable vendors to return the entire QP/CQ/MR data without a need from the vendor to set each field separately.
Quoted 8 lines
Quoted 6 lines
Thanks
Maor Gottlieb (11):
net/mlx5: Export resource dump interface net/mlx5: Add support in query QP, CQ and MKEY segmentsIt looks OK can you apply these too the shared branch?
Thanks, applied.
608ca553c9a2 net/mlx5: Add support in query QP, CQ and MKEY segments d63cc24933c7 net/mlx5: Export resource dump interface
Quoted 3 lines
Thanks,
Jason
Jason Gunthorpe
AppliedQuoted 33 lines · Leon Romanovsky
Quoted 32 lines · Jason Gunthorpe
Quoted 30 lines · Leon Romanovsky
From: Leon Romanovsky <[email protected]>
Changelog:
v3:
* Rewrote query interface in patch "RDMA: Add support to dump resource tracker in RAW format"
v2:
https://lore.kernel.org/linux-rdma/[email protected]
* Converted to specific nldev ops for RAW.
* Rebased on top of v5.8-rc1.
v1:
https://lore.kernel.org/linux-rdma/[email protected]
* Maor dropped controversial change to dummy interface.
v0:
https://lore.kernel.org/linux-rdma/[email protected]Hi,
The following series adds support to get the RDMA resource data in RAW format. The main motivation for doing this is to enable vendors to return the entire QP/CQ/MR data without a need from the vendor to set each field separately.
Thanks
Maor Gottlieb (11):
net/mlx5: Export resource dump interface net/mlx5: Add support in query QP, CQ and MKEY segments
Quoted 6 lines
Quoted 1 line
It looks OK can you apply these too the shared branch?
Thanks, applied.
608ca553c9a2net/mlx5: Add support in query QP, CQ and MKEY segmentsd63cc24933c7net/mlx5: Export resource dump interface
Applied to for-next, thanks
Jason