Skip to contentSkip to conversation

RDMA/ipoib: Return void from ipoib_ib_dev_stop()

PATCH Applied Kamal Heib 2 participants 2 messages Jun 23, 2020 InfiniBand

lore
Share & tools
lore

Kamal Heib

author
#0 lore raw

PATCH 1/1 RDMA/ipoib: Return void from ipoib_ib_dev_stop()

The return value from ipoib_ib_dev_stop() is always 0 - change it to be void.

---
 drivers/infiniband/ulp/ipoib/ipoib.h    | 2 +-
 drivers/infiniband/ulp/ipoib/ipoib_ib.c | 4 +---
 2 files changed, 2 insertions(+), 4 deletions(-)
drivers/infiniband/ulp/ipoib/ipoib.h +1 -1
index 15f519ce7e0b..3440dc48d02c 100644
@@ -515,7 +515,7 @@ void ipoib_ib_dev_cleanup(struct net_device *dev);
 
 int ipoib_ib_dev_open_default(struct net_device *dev);
 int ipoib_ib_dev_open(struct net_device *dev);
-int ipoib_ib_dev_stop(struct net_device *dev);
+void ipoib_ib_dev_stop(struct net_device *dev);
 void ipoib_ib_dev_up(struct net_device *dev);
 void ipoib_ib_dev_down(struct net_device *dev);
 int ipoib_ib_dev_stop_default(struct net_device *dev);
drivers/infiniband/ulp/ipoib/ipoib_ib.c +1 -3
index da3c5315bbb5..6ee64c25aaff 100644
@@ -846,7 +846,7 @@ int ipoib_ib_dev_stop_default(struct net_device *dev)
 	return 0;
 }
 
-int ipoib_ib_dev_stop(struct net_device *dev)
+void ipoib_ib_dev_stop(struct net_device *dev)
 {
 	struct ipoib_dev_priv *priv = ipoib_priv(dev);
 
@@ -854,8 +854,6 @@ int ipoib_ib_dev_stop(struct net_device *dev)
 
 	clear_bit(IPOIB_FLAG_INITIALIZED, &priv->flags);
 	ipoib_flush_ah(dev);
-
-	return 0;
 }
 
 int ipoib_ib_dev_open_default(struct net_device *dev)
Signature · 1 line
2.25.4
maintainer Applied
#1 lore raw

drivers/infiniband/ulp/ipoib/ipoib.h void ipoib_ib_dev_cleanup(struct net_device *dev);

Quoted 14 lines · Kamal Heib

The return value from ipoib_ib_dev_stop() is always 0 - change it to be void.

---
 drivers/infiniband/ulp/ipoib/ipoib.h    | 2 +-
 drivers/infiniband/ulp/ipoib/ipoib_ib.c | 4 +---
 2 files changed, 2 insertions(+), 4 deletions(-)
drivers/infiniband/ulp/ipoib/ipoib.h +0 -0
index 15f519ce7e0b..3440dc48d02c 100644
@@ -515,7 +515,7 @@ void ipoib_ib_dev_cleanup(struct net_device *dev);

Applied to for-next, thanks

Jason