fix bound check in pmc_core_mphy_pg_show
PATCH 1/1 fix bound check in pmc_core_mphy_pg_show
Check bounds before accessing map[].
Signed-off-by Gaurav Singh <[email protected]>
--- drivers/platform/x86/intel_pmc_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/platform/x86/intel_pmc_core.c +1 -1
@@ -795,7 +795,7 @@ static int pmc_core_mphy_pg_show(struct seq_file *s, void *unused)msleep (10 ); val_high =pmc_core_reg_read (pmcdev,SPT_PMC_MFPMC_OFFSET ); -for (index =0 ; map[index].name && index <8 ; index++) { +for (index =0 ; index <8 && map[index].name; index++) { seq_printf(s, "%-32s\tState: %s\n", map[index].name, map[index].bit_mask & val_low ? "Not power gated" :
Signature · 1 line
2.17.1
Quoted 3 lines · Gaurav Singh
Check bounds before accessing map[].
Pushed to my review and testing queue, thanks!
Quoted 19 lines
Signed-off-by Gaurav Singh <[email protected]>--- drivers/platform/x86/intel_pmc_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/platform/x86/intel_pmc_core.c +1
-2@@ -795,7 +795,7 @@ static int pmc_core_mphy_pg_show(struct seq_file *s, void *unused)msleep (10 ); val_high =pmc_core_reg_read (pmcdev,SPT_PMC_MFPMC_OFFSET ); -for (index =0 ; map[index].name && index <8 ; index++) { +for (index =0 ; index <8 && map[index].name; index++) { seq_printf(s, "%-32s\tState: %s\n", map[index].name, map[index].bit_mask & val_low ? "Not power gated" : --
Quoted 2 lines
2.17.1
--
With Best Regards,
Andy Shevchenko