linux-next: Fixes tag needs some work in the scsi-fixes tree
Subsystems (3)
Hi all,
In commit
46da547e21d6 ("scsi: lpfc: Avoid another null dereference in lpfc_sli4_hba_unset()")
Fixes tag
has these problem(s):
- Subject does not match target commit subject
Just use
git log -1 --format='Fixes: %h ("%s")'Signature · 2 lines
Cheers, Stephen Rothwell
Quoted 11 lines · On Wed, 24 Jun 2020 17:07:42 +1000 Stephen Rothwell <[email protected]>…
[-- Attachment #1: Type: text/plain, Size: 385 bytes --]
Hi all,
In commit
46da547e21d6("scsi: lpfc: Avoid another null dereference inlpfc_sli4_hba_unset()")Fixes tag
Quoted 7 lines
Fixes 1ffdd2c0440d ("scsi: lpfc: resolve static checker warning inlpfc_sli4_hba_unset")has these problem(s):
- Subject does not match target commit subject
Just use git log -1 --format='Fixes: %h ("%s")'
Oops, sorry for the mistake. I will send the fixed version in reply to this.
Thanks,
SeongJae Park
Quoted 4 lines
Signature · 3 lines
-- Cheers, Stephen Rothwell
PATCH v2 1/1 scsi: lpfc: Avoid another null dereference in lpfc_sli4_hba_unset()
From: SeongJae Park <[email protected]>
Commit cdb42becdd40 ("scsi: lpfc: Replace io_channels for nvme and fcp with general hdw_queues per cpu") has introduced static checker warnings for potential null dereferences in 'lpfc_sli4_hba_unset()' and commit 1ffdd2c0440d ("scsi: lpfc: resolve static checker warning in lpfc_sli4_hba_unset") has tried to fix it. However, yet another potential null dereference is remaining. This commit fixes it.
This bug was discovered and resolved using Coverity Static Analysis Security Testing (SAST) by Synopsys, Inc.
--- drivers/scsi/lpfc/lpfc_init.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/scsi/lpfc/lpfc_init.c +2 -1
@@ -11878,7 +11878,8 @@ lpfc_sli4_hba_unset(struct lpfc_hba *phba)lpfc_sli4_xri_exchange_busy_wait (phba);/* per-phba callback de-registration for hotplug event */ -lpfc_cpuhp_remove (phba); +if (phba->pport) +lpfc_cpuhp_remove (phba);/* Disable PCI subsystem interrupt */ lpfc_sli4_disable_intr (phba);
Signature · 1 line
2.17.1
Hi SeongJae,
Quoted 2 lines · On Wed, 24 Jun 2020 09:14:47 +0200 SeongJae Park <[email protected]> wrote:
Oops, sorry for the mistake. I will send the fixed version in reply to this.
Unless Martin says otherwise, I am not sure it is worth fixing. Just remember for next time.
Signature · 2 lines
Cheers, Stephen Rothwell