Skip to contentSkip to conversation

kselftest: arm64: Remove redundant clean target

PATCH Applied Mark Brown 2 participants 2 messages Jun 24, 2020

Subsystems (2)
lore
Share & tools
lore

Mark Brown

author
#0 lore raw

PATCH 1/1 kselftest: arm64: Remove redundant clean target

The arm64 signal tests generate warnings during build since both they and the toplevel lib.mk define a clean target:

Makefile:25: warning: overriding recipe for target 'clean' ../../lib.mk:126: warning: ignoring old recipe for target 'clean'

Since the inclusion of lib.mk is in the signal Makefile there is no situation where this warning could be avoided so just remove the redundant clean target.

---
 tools/testing/selftests/arm64/signal/Makefile | 4 ----
 1 file changed, 4 deletions(-)
tools/testing/selftests/arm64/signal/Makefile +0 -4
index b497cfea4643..ac4ad0005715 100644
@@ -21,10 +21,6 @@ include ../../lib.mk
 $(TEST_GEN_PROGS): $(PROGS)
 	cp $(PROGS) $(OUTPUT)/
 
-clean:
-	$(CLEAN)
-	rm -f $(PROGS)
-
 # Common test-unit targets to build common-layout test-cases executables
 # Needs secondary expansion to properly include the testcase c-file in pre-reqs
 .SECONDEXPANSION:
Signature · 1 line
2.20.1
maintainer Applied
#1 lore raw
Quoted 9 lines · Mark Brown

The arm64 signal tests generate warnings during build since both they and the toplevel lib.mk define a clean target:

Makefile:25: warning: overriding recipe for target 'clean' ../../lib.mk:126: warning: ignoring old recipe for target 'clean'

Since the inclusion of lib.mk is in the signal Makefile there is no situation where this warning could be avoided so just remove the redundant clean target.

Applied to arm64 (for-next/fixes), thanks!

[1/1] kselftest: arm64: Remove redundant clean target

      https://git.kernel.org/arm64/c/cb944f02d0d8

Cheers,

Signature · 5 lines
Will

https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev