Skip to contentSkip to conversation

arm64: defconfig: enable QoriQ dependencies as modules

PATCH In review Ard Biesheuvel 3 participants 4 messages Jun 24, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm64: defconfig: enable QoriQ dependencies as modules

The arm64 port adopts a single image policy, and therefore has a single defconfig that should produce a kernel that can boot on any platform. Given the shared nature, we typically enable tristate Kconfig options as modules, unless there is a good reason to enable it as a builtin.

In the case of commit 97c1ed02f765bc89 ("arm64: defconfig: Enable PHY devices used on QorIQ boards"), this is not really the case, and the various options are enabled as builtins as a convenience for the NXP developers that actually work on such boards. This pulls in other dependencies, such as CRYPTO_AES and CRYPTO_ECB (for MICROSEMI_PHY), which themselves pull in other pieces of the crypto stack.

Since all the options that this commit enables are tristate, let's switch them all to =m

Fixes 97c1ed02f765bc89 ("arm64: defconfig: Enable PHY devices used on QorIQ boards")
---
 arch/arm64/configs/defconfig | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
arch/arm64/configs/defconfig +5 -5
index 883e8bace3ed..b0c5cf72a4c3 100644
@@ -318,17 +318,17 @@ CONFIG_STMMAC_ETH=m
 CONFIG_TI_K3_AM65_CPSW_NUSS=y
 CONFIG_QCOM_IPA=m
 CONFIG_MDIO_BUS_MUX_MMIOREG=y
-CONFIG_MDIO_BUS_MUX_MULTIPLEXER=y
-CONFIG_AQUANTIA_PHY=y
+CONFIG_MDIO_BUS_MUX_MULTIPLEXER=m
+CONFIG_AQUANTIA_PHY=m
 CONFIG_MARVELL_PHY=m
 CONFIG_MARVELL_10G_PHY=m
 CONFIG_MESON_GXL_PHY=m
 CONFIG_MICREL_PHY=y
-CONFIG_MICROSEMI_PHY=y
+CONFIG_MICROSEMI_PHY=m
 CONFIG_AT803X_PHY=y
 CONFIG_REALTEK_PHY=m
 CONFIG_ROCKCHIP_PHY=y
-CONFIG_VITESSE_PHY=y
+CONFIG_VITESSE_PHY=m
 CONFIG_USB_PEGASUS=m
 CONFIG_USB_RTL8150=m
 CONFIG_USB_RTL8152=m
@@ -951,7 +951,7 @@ CONFIG_OPTEE=y
 CONFIG_SLIMBUS=m
 CONFIG_SLIM_QCOM_CTRL=m
 CONFIG_SLIM_QCOM_NGD_CTRL=m
-CONFIG_MUX_MMIO=y
+CONFIG_MUX_MMIO=m
 CONFIG_EXT2_FS=y
 CONFIG_EXT3_FS=y
 CONFIG_EXT4_FS_POSIX_ACL=y
Signature · 7 lines
2.27.0


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Acked-by on v1 1/1
#1 lore raw
Quoted 13 lines · Ard Biesheuvel

The arm64 port adopts a single image policy, and therefore has a single defconfig that should produce a kernel that can boot on any platform. Given the shared nature, we typically enable tristate Kconfig options as modules, unless there is a good reason to enable it as a builtin.

In the case of commit 97c1ed02f765bc89 ("arm64: defconfig: Enable PHY devices used on QorIQ boards"), this is not really the case, and the various options are enabled as builtins as a convenience for the NXP developers that actually work on such boards. This pulls in other dependencies, such as CRYPTO_AES and CRYPTO_ECB (for MICROSEMI_PHY), which themselves pull in other pieces of the crypto stack.

Quoted 5 lines

Since all the options that this commit enables are tristate, let's switch them all to =m

Fixes 97c1ed02f765bc89 ("arm64: defconfig: Enable PHY devices used on QorIQ boards")

I assume it's sufficient to apply this in linux-5.9 rather than 5.8, right?

Arnd

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#2 lore raw
Quoted 18 lines · Arnd Bergmann
Quoted 16 lines · Ard Biesheuvel

The arm64 port adopts a single image policy, and therefore has a single defconfig that should produce a kernel that can boot on any platform. Given the shared nature, we typically enable tristate Kconfig options as modules, unless there is a good reason to enable it as a builtin.

In the case of commit 97c1ed02f765bc89 ("arm64: defconfig: Enable PHY devices used on QorIQ boards"), this is not really the case, and the various options are enabled as builtins as a convenience for the NXP developers that actually work on such boards. This pulls in other dependencies, such as CRYPTO_AES and CRYPTO_ECB (for MICROSEMI_PHY), which themselves pull in other pieces of the crypto stack.

Since all the options that this commit enables are tristate, let's switch them all to =m

Quoted 7 lines
Quoted 2 lines
Fixes 97c1ed02f765bc89 ("arm64: defconfig: Enable PHY devices used on QorIQ boards")

I assume it's sufficient to apply this in linux-5.9 rather than 5.8, right?

Whatever you prefer.

Thanks,
Ard.

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Acked-by on v1 1/1
#3 lore raw
In reply to Ard Biesheuvel
Quoted 15 lines

-----Original Message-----
From: Ard Biesheuvel <[email protected]>
Sent: Wednesday, June 24, 2020 9:05 AM
To: [email protected]
Cc: [email protected]; [email protected]; Leo Li <[email protected]>; Ard Biesheuvel <[email protected]>
Subject: [PATCH] arm64: defconfig: enable QoriQ dependencies as modules

The arm64 port adopts a single image policy, and therefore has a single defconfig that should produce a kernel that can boot on any platform. Given the shared nature, we typically enable tristate Kconfig options as modules, unless there is a good reason to enable it as a builtin.

Quoted 6 lines

In the case of commit 97c1ed02f765bc89 ("arm64: defconfig: Enable PHY devices used on QorIQ boards"), this is not really the case, and the various options are enabled as builtins as a convenience for the NXP developers that actually work on such boards. This pulls in other dependencies, such as CRYPTO_AES and CRYPTO_ECB (for MICROSEMI_PHY), which themselves pull in other pieces of the crypto stack.

I agree that this makes it even worse to be enabled as built-in. I will try to change the way of work for NXP developers. If they really need these drivers to be built-in they will need to maintain a config fragment in private to do that.

Quoted 7 lines

Since all the options that this commit enables are tristate, let's switch them all to =m

Fixes 97c1ed02f765bc89 ("arm64: defconfig: Enable PHY devices used on

QorIQ boards")

Quoted 40 lines
---
 arch/arm64/configs/defconfig | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
arch/arm64/configs/defconfig +5 -6
index 883e8bace3ed..b0c5cf72a4c3 100644
@@ -318,17 +318,17 @@ CONFIG_STMMAC_ETH=m
 CONFIG_TI_K3_AM65_CPSW_NUSS=y
 CONFIG_QCOM_IPA=m
 CONFIG_MDIO_BUS_MUX_MMIOREG=y
-CONFIG_MDIO_BUS_MUX_MULTIPLEXER=y
-CONFIG_AQUANTIA_PHY=y
+CONFIG_MDIO_BUS_MUX_MULTIPLEXER=m
+CONFIG_AQUANTIA_PHY=m
 CONFIG_MARVELL_PHY=m
 CONFIG_MARVELL_10G_PHY=m
 CONFIG_MESON_GXL_PHY=m
 CONFIG_MICREL_PHY=y
-CONFIG_MICROSEMI_PHY=y
+CONFIG_MICROSEMI_PHY=m
 CONFIG_AT803X_PHY=y
 CONFIG_REALTEK_PHY=m
 CONFIG_ROCKCHIP_PHY=y
-CONFIG_VITESSE_PHY=y
+CONFIG_VITESSE_PHY=m
 CONFIG_USB_PEGASUS=m
 CONFIG_USB_RTL8150=m
 CONFIG_USB_RTL8152=m
@@ -951,7 +951,7 @@ CONFIG_OPTEE=y
 CONFIG_SLIMBUS=m
 CONFIG_SLIM_QCOM_CTRL=m
 CONFIG_SLIM_QCOM_NGD_CTRL=m
-CONFIG_MUX_MMIO=y
+CONFIG_MUX_MMIO=m
 CONFIG_EXT2_FS=y
 CONFIG_EXT3_FS=y
 CONFIG_EXT4_FS_POSIX_ACL=y
--
Quoted 1 line

2.27.0

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel