package/freescale-imx: clean-up proposal
cover package/freescale-imx: clean-up proposal
Here is - as promised [1] - a patch set whose aim is to clean up the firmware-imx package. I believe this may help installing EPDC fw, SDMA FW and so on based on the actual need from each platform and respond to [2].
BR,
Stephane.
[1] http://lists.busybox.net/pipermail/buildroot/2020-June/284032.html
[2] http://lists.busybox.net/pipermail/buildroot/2020-June/285218.html
Stephane Viau (2):
package/freescale-imx: Add option for all i.MX FW needs package/freescale-imx/firmware-imx: Clean up the image/target semantic
package/freescale-imx/Config.in | 39 ++++++++++++ package/freescale-imx/firmware-imx/firmware-imx.mk | 70 +++++++++++++++++----- 2 files changed, 93 insertions(+), 16 deletions(-)
Signature · 1 line
2.7.4
PATCH 1/2 package/freescale-imx: Add option for all i.MX FW needs
Some SoC need a HDMI FW for their bootloader, some other require EPDC, SDMA and/or VPU.
Instead of trying to "guess" what firmware images need to be installed in firmware-imx.mk, let the Config framework do the job and allow each SoC to actually 'select' what firmware they need.
Note that this patch should also help introducing an eventual DP FW, as Gary mentioned in a separate thread [1].
[1] http://lists.busybox.net/pipermail/buildroot/2020-May/283181.html
--- package/freescale-imx/Config.in | 39 +++++++++++++++++++++++++++++++++++++++ 1 file changed, 39 insertions(+)
package/freescale-imx/Config.in +39 -0
@@ -12,40 +12,63 @@ choice config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX25_3STACK bool "imx25-3stack" + select BR2_PACKAGE_FREESCALE_IMX_NEED_SDMA_FW config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX27ADS bool "imx27ads" + select BR2_PACKAGE_FREESCALE_IMX_NEED_SDMA_FW + select BR2_PACKAGE_FREESCALE_IMX_NEED_VPU_FW_LEGACY config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX37_3STACK bool "imx37-3stack" + select BR2_PACKAGE_FREESCALE_IMX_NEED_SDMA_FW + select BR2_PACKAGE_FREESCALE_IMX_NEED_VPU_FW_LEGACY config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX50 bool "imx50" + select BR2_PACKAGE_FREESCALE_IMX_NEED_SDMA_FW + select BR2_PACKAGE_FREESCALE_IMX_NEED_VPU_FW_LEGACY config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX51 bool "imx51" + select BR2_PACKAGE_FREESCALE_IMX_NEED_SDMA_FW + select BR2_PACKAGE_FREESCALE_IMX_NEED_VPU_FW_LEGACY config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX53 bool "imx53" + select BR2_PACKAGE_FREESCALE_IMX_NEED_SDMA_FW + select BR2_PACKAGE_FREESCALE_IMX_NEED_VPU_FW_LEGACY config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX6Q bool "imx6q/imx6dl" + select BR2_PACKAGE_FREESCALE_IMX_NEED_EPDC_FW + select BR2_PACKAGE_FREESCALE_IMX_NEED_SDMA_FW + select BR2_PACKAGE_FREESCALE_IMX_NEED_VPU_FW_LEGACY config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX6S bool "imx6sl/imx6sx" + select BR2_PACKAGE_FREESCALE_IMX_NEED_EPDC_FW + select BR2_PACKAGE_FREESCALE_IMX_NEED_SDMA_FW + select BR2_PACKAGE_FREESCALE_IMX_NEED_VPU_FW_LEGACY config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX6UL bool "imx6ul/imx6ull" + select BR2_PACKAGE_FREESCALE_IMX_NEED_SDMA_FW + select BR2_PACKAGE_FREESCALE_IMX_NEED_VPU_FW_LEGACY config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX7 bool "imx7d/imx7ulp" + select BR2_PACKAGE_FREESCALE_IMX_NEED_SDMA_FW + select BR2_PACKAGE_FREESCALE_IMX_NEED_VPU_FW_LEGACY config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8 bool "imx8" + select BR2_PACKAGE_FREESCALE_IMX_NEED_VPU_FW_IMX8_IMX8X config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8M bool "imx8m" select BR2_PACKAGE_FREESCALE_IMX_NEED_DDR_FW + select BR2_PACKAGE_FREESCALE_IMX_NEED_HDMI_FW config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8MM bool "imx8mm"
@@ -57,6 +80,7 @@ config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8MN config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8X bool "imx8x" + select BR2_PACKAGE_FREESCALE_IMX_NEED_VPU_FW_IMX8_IMX8X endchoice config BR2_PACKAGE_FREESCALE_IMX_PLATFORM
@@ -102,6 +126,21 @@ config BR2_PACKAGE_FREESCALE_IMX_HAS_VIV_GPU config BR2_PACKAGE_FREESCALE_IMX_NEED_DDR_FW bool +config BR2_PACKAGE_FREESCALE_IMX_NEED_EPDC_FW + bool + +config BR2_PACKAGE_FREESCALE_IMX_NEED_HDMI_FW + bool + +config BR2_PACKAGE_FREESCALE_IMX_NEED_SDMA_FW + bool + +config BR2_PACKAGE_FREESCALE_IMX_NEED_VPU_FW_LEGACY + bool + +config BR2_PACKAGE_FREESCALE_IMX_NEED_VPU_FW_IMX8_IMX8X + bool + source "package/freescale-imx/imx-alsa-plugins/Config.in" source "package/freescale-imx/imx-codec/Config.in" source "package/freescale-imx/imx-kobs/Config.in"
Signature · 1 line
2.7.4
Fabio Estevam
reviewerPATCH 1/2 package/freescale-imx: Add option for all i.MX FW needs
Hi Stephane,
package/freescale-imx/Config.in choice · line 46
Quoted 5 lines · Stephane Viau
config
BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX6S
bool "imx6sl/imx6sx"package/freescale-imx/Config.in +3
-0+ select BR2_PACKAGE_FREESCALE_IMX_NEED_EPDC_FW + select BR2_PACKAGE_FREESCALE_IMX_NEED_SDMA_FW + select BR2_PACKAGE_FREESCALE_IMX_NEED_VPU_FW_LEGACY
There is no VPU on i.MX6SL/i.MX6SX.
Review
Quoted 4 lines
config
BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX6UL
bool "imx6ul/imx6ull"(quoted diff) +2
-0+ select BR2_PACKAGE_FREESCALE_IMX_NEED_SDMA_FW + select BR2_PACKAGE_FREESCALE_IMX_NEED_VPU_FW_LEGACY
There is no VPU on i.MX6UL/i.MX6ULL.
Review
Quoted 4 lines
config
BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX7
bool "imx7d/imx7ulp"(quoted diff) +2
-0+ select BR2_PACKAGE_FREESCALE_IMX_NEED_SDMA_FW + select BR2_PACKAGE_FREESCALE_IMX_NEED_VPU_FW_LEGACY
There is no VPU on i.MX7.
Fabio Estevam
reviewerPATCH 1/2 package/freescale-imx: Add option for all i.MX FW needs
In reply to Stephane ViauHi Stephane,
Forgot to add one more comment:
Quoted 1 line · Stephane Viau
+config
BR2_PACKAGE_FREESCALE_IMX_NEED_VPU_FW_LEGACY
Should we name this after the VPU IP name instead? Something like this:
BR2_PACKAGE_FREESCALE_IMX_NEED_VPU_FW_CODA
Quoted 1 line
+config
BR2_PACKAGE_FREESCALE_IMX_NEED_VPU_FW_IMX8_IMX8X
BR2_PACKAGE_FREESCALE_IMX_NEED_VPU_FW_MALONE
PATCH 1/2 package/freescale-imx: Add option for all i.MX FW needs
Fabio, St?phane, All,
On 2020-06-24 17:11 -0300, Fabio Estevam spake thusly:
Quoted 5 lines
Forgot to add one more comment:
On Wed, Jun 24, 2020 at 12:57 PM Stephane Viau
<[email protected]> wrote:
Quoted 7 lines
Quoted 1 line
+config
BR2_PACKAGE_FREESCALE_IMX_NEED_VPU_FW_LEGACYShould we name this after the VPU IP name instead? Something like this:
BR2_PACKAGE_FREESCALE_IMX_NEED_VPU_FW_CODAQuoted 1 line
+config
BR2_PACKAGE_FREESCALE_IMX_NEED_VPU_FW_IMX8_IMX8X
BR2_PACKAGE_FREESCALE_IMX_NEED_VPU_FW_MALONE
If the VPU code names are pretty commonly known, then yes, that looks better, indeed.
Regards,
Yann E. MORIN.
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'
PATCH 1/2 package/freescale-imx: Add option for all i.MX FW needs
In reply to Stephane ViauHello,
Thanks for doing this work! It's definitely bringing some good sanity into this firmware-imx mess! See below some comments.
Quoted 84 lines · On Wed, 24 Jun 2020 17:23:47 +0200 Stephane Viau <[email protected]>…
package/freescale-imx/Config.in +28
-0@@ -12,40 +12,63 @@ choice config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX25_3STACK bool "imx25-3stack" + select BR2_PACKAGE_FREESCALE_IMX_NEED_SDMA_FW config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX27ADS bool "imx27ads" + select BR2_PACKAGE_FREESCALE_IMX_NEED_SDMA_FW + select BR2_PACKAGE_FREESCALE_IMX_NEED_VPU_FW_LEGACY config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX37_3STACK bool "imx37-3stack" + select BR2_PACKAGE_FREESCALE_IMX_NEED_SDMA_FW + select BR2_PACKAGE_FREESCALE_IMX_NEED_VPU_FW_LEGACY config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX50 bool "imx50" + select BR2_PACKAGE_FREESCALE_IMX_NEED_SDMA_FW + select BR2_PACKAGE_FREESCALE_IMX_NEED_VPU_FW_LEGACY config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX51 bool "imx51" + select BR2_PACKAGE_FREESCALE_IMX_NEED_SDMA_FW + select BR2_PACKAGE_FREESCALE_IMX_NEED_VPU_FW_LEGACY config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX53 bool "imx53" + select BR2_PACKAGE_FREESCALE_IMX_NEED_SDMA_FW + select BR2_PACKAGE_FREESCALE_IMX_NEED_VPU_FW_LEGACY config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX6Q bool "imx6q/imx6dl" + select BR2_PACKAGE_FREESCALE_IMX_NEED_EPDC_FW + select BR2_PACKAGE_FREESCALE_IMX_NEED_SDMA_FW + select BR2_PACKAGE_FREESCALE_IMX_NEED_VPU_FW_LEGACY config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX6S bool "imx6sl/imx6sx" + select BR2_PACKAGE_FREESCALE_IMX_NEED_EPDC_FW + select BR2_PACKAGE_FREESCALE_IMX_NEED_SDMA_FW + select BR2_PACKAGE_FREESCALE_IMX_NEED_VPU_FW_LEGACY config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX6UL bool "imx6ul/imx6ull" + select BR2_PACKAGE_FREESCALE_IMX_NEED_SDMA_FW + select BR2_PACKAGE_FREESCALE_IMX_NEED_VPU_FW_LEGACY config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX7 bool "imx7d/imx7ulp" + select BR2_PACKAGE_FREESCALE_IMX_NEED_SDMA_FW + select BR2_PACKAGE_FREESCALE_IMX_NEED_VPU_FW_LEGACY config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8 bool "imx8" + select BR2_PACKAGE_FREESCALE_IMX_NEED_VPU_FW_IMX8_IMX8X config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8M bool "imx8m" select BR2_PACKAGE_FREESCALE_IMX_NEED_DDR_FW + select BR2_PACKAGE_FREESCALE_IMX_NEED_HDMI_FW config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8MM bool "imx8mm"@@ -57,6 +80,7 @@ config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8MN config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8X bool "imx8x" + select BR2_PACKAGE_FREESCALE_IMX_NEED_VPU_FW_IMX8_IMX8X endchoice config BR2_PACKAGE_FREESCALE_IMX_PLATFORM@@ -102,6 +126,21 @@ config BR2_PACKAGE_FREESCALE_IMX_HAS_VIV_GPU config BR2_PACKAGE_FREESCALE_IMX_NEED_DDR_FW bool +config BR2_PACKAGE_FREESCALE_IMX_NEED_EPDC_FW + bool + +config BR2_PACKAGE_FREESCALE_IMX_NEED_HDMI_FW
package/freescale-imx/Config.in config BR2_PACKAGE_FREESCALE_IMX_HAS_VIV_GPU · line 142
Quoted 10 lines
package/freescale-imx/Config.in +10
-0+ bool + +config BR2_PACKAGE_FREESCALE_IMX_NEED_SDMA_FW + bool + +config BR2_PACKAGE_FREESCALE_IMX_NEED_VPU_FW_LEGACY + bool + +config BR2_PACKAGE_FREESCALE_IMX_NEED_VPU_FW_IMX8_IMX8X + bool
It would be nicer to use "NEEDS" instead of "NEED". That would require a preparation patch that renames BR2_PACKAGE_FREESCALE_IMX_NEED_DDR_FW to BR2_PACKAGE_FREESCALE_IMX_NEEDS_DDR_FW.
However, I am wondering if package/freescale-imx/Config.in is the right place for all this logic. After all, this is only related to the firmware-imx package.
Shouldn't we instead move that to package/freescale-imx/firmware-imx/Config.in, with the following form:
config BR2_PACKAGE_FREESCALE_IMX_NEEDS_DDR_FW
bool
default y if BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8M default y if BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8MM default y if BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8MN
and ditto the other options ? Here as well, it would require a preparation patch to take care of the NEEDS_DDR_FW case, and then your patch that handles all other FW files.
Best regards,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
PATCH 1/2 package/freescale-imx: Add option for all i.MX FW needs
Quoted 2 lines
Hello,
Hello Thomas, Yann/Gary,
Quoted 3 lines
Thanks for doing this work! It's definitely bringing some good sanity into this firmware-imx mess! See below some comments.
Glad you like it & thank you for your comments.
Quoted 91 lines
Quoted 91 lines
package/freescale-imx/Config.in +34
-0@@ -12,40 +12,63 @@ choice config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX25_3STACK bool "imx25-3stack" + select BR2_PACKAGE_FREESCALE_IMX_NEED_SDMA_FW config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX27ADS bool "imx27ads" + select BR2_PACKAGE_FREESCALE_IMX_NEED_SDMA_FW + select BR2_PACKAGE_FREESCALE_IMX_NEED_VPU_FW_LEGACY config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX37_3STACK bool "imx37-3stack" + select BR2_PACKAGE_FREESCALE_IMX_NEED_SDMA_FW + select BR2_PACKAGE_FREESCALE_IMX_NEED_VPU_FW_LEGACY config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX50 bool "imx50" + select BR2_PACKAGE_FREESCALE_IMX_NEED_SDMA_FW + select BR2_PACKAGE_FREESCALE_IMX_NEED_VPU_FW_LEGACY config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX51 bool "imx51" + select BR2_PACKAGE_FREESCALE_IMX_NEED_SDMA_FW + select BR2_PACKAGE_FREESCALE_IMX_NEED_VPU_FW_LEGACY config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX53 bool "imx53" + select BR2_PACKAGE_FREESCALE_IMX_NEED_SDMA_FW + select BR2_PACKAGE_FREESCALE_IMX_NEED_VPU_FW_LEGACY config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX6Q bool "imx6q/imx6dl" + select BR2_PACKAGE_FREESCALE_IMX_NEED_EPDC_FW + select BR2_PACKAGE_FREESCALE_IMX_NEED_SDMA_FW + select BR2_PACKAGE_FREESCALE_IMX_NEED_VPU_FW_LEGACY config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX6S bool "imx6sl/imx6sx" + select BR2_PACKAGE_FREESCALE_IMX_NEED_EPDC_FW + select BR2_PACKAGE_FREESCALE_IMX_NEED_SDMA_FW + select BR2_PACKAGE_FREESCALE_IMX_NEED_VPU_FW_LEGACY config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX6UL bool "imx6ul/imx6ull" + select BR2_PACKAGE_FREESCALE_IMX_NEED_SDMA_FW + select BR2_PACKAGE_FREESCALE_IMX_NEED_VPU_FW_LEGACY config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX7 bool "imx7d/imx7ulp" + select BR2_PACKAGE_FREESCALE_IMX_NEED_SDMA_FW + select BR2_PACKAGE_FREESCALE_IMX_NEED_VPU_FW_LEGACY config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8 bool "imx8" + select BR2_PACKAGE_FREESCALE_IMX_NEED_VPU_FW_IMX8_IMX8X config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8M bool "imx8m" select BR2_PACKAGE_FREESCALE_IMX_NEED_DDR_FW + select BR2_PACKAGE_FREESCALE_IMX_NEED_HDMI_FW config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8MM bool "imx8mm"@@ -57,6 +80,7 @@ config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8MN config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8X bool "imx8x" + select BR2_PACKAGE_FREESCALE_IMX_NEED_VPU_FW_IMX8_IMX8X endchoice config BR2_PACKAGE_FREESCALE_IMX_PLATFORM@@ -102,6 +126,21 @@ config BR2_PACKAGE_FREESCALE_IMX_HAS_VIV_GPU config BR2_PACKAGE_FREESCALE_IMX_NEED_DDR_FW bool +config BR2_PACKAGE_FREESCALE_IMX_NEED_EPDC_FW + bool + +config BR2_PACKAGE_FREESCALE_IMX_NEED_HDMI_FW + bool + +config BR2_PACKAGE_FREESCALE_IMX_NEED_SDMA_FW + bool + +config BR2_PACKAGE_FREESCALE_IMX_NEED_VPU_FW_LEGACY
Quoted 8 lines
package/freescale-imx/Config.in config BR2_PACKAGE_FREESCALE_IMX_HAS_VIV_GPU · line 142
Quoted 4 lines
package/freescale-imx/Config.in +4
-0+ bool + +config BR2_PACKAGE_FREESCALE_IMX_NEED_VPU_FW_IMX8_IMX8X + boolIt would be nicer to use "NEEDS" instead of "NEED". That would require a preparation patch that renames
BR2_PACKAGE_FREESCALE_IMX_NEED_DDR_FWtoBR2_PACKAGE_FREESCALE_IMX_NEEDS_DDR_FW.
Agreed.
Quoted 14 lines
However, I am wondering if package/freescale-imx/Config.in is the right place for all this logic. After all, this is only related to the firmware-imx package.
Shouldn't we instead move that to package/freescale-imx/firmware-imx/Config.in, with the following form:
config
BR2_PACKAGE_FREESCALE_IMX_NEEDS_DDR_FW
bool
default y ifBR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8Mdefault y ifBR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8MMdefault y ifBR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8MN
Quoted 3 lines
and ditto the other options ? Here as well, it would require a preparation patch to take care of the
NEEDS_DDR_FWcase, and then your patch that handles all other FW files.
I'd like to have Yann's and/or Gary's feedback on this. I'm using 'select' based on this comment:
"
As Yann mentioned on IRC:
"Usually, when we introduce such option, it does not 'default y' based
on some other options. Instead, the other options 'select' it."
"
from http://lists.busybox.net/pipermail/buildroot/2020-May/283180.html
BR,
Stephane.
Quoted 8 lines
Best regards,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
PATCH 1/2 package/freescale-imx: Add option for all i.MX FW needs
Stephane, All,
On 2020-06-25 06:33 +0000, Stephane Viau (OSS) spake thusly:
Quoted 18 lines
Quoted 13 lines · Thomas
However, I am wondering if package/freescale-imx/Config.in is the right place for all this logic. After all, this is only related to the firmware-imx package.
Shouldn't we instead move that to package/freescale-imx/firmware-imx/Config.in, with the following form:
config
BR2_PACKAGE_FREESCALE_IMX_NEEDS_DDR_FW
bool
default y ifBR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8Mdefault y ifBR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8MMdefault y ifBR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8MNQuoted 3 lines
and ditto the other options ? Here as well, it would require a preparation patch to take care of the
NEEDS_DDR_FWcase, and then your patch that handles all other FW files.
Quoted 7 lines
I'd like to have Yann's and/or Gary's feedback on this. I'm using 'select' based on this comment:
"
As Yann mentioned on IRC:
"Usually, when we introduce such option, it does not 'default y' based
on some other options. Instead, the other options 'select' it."
"
from http://lists.busybox.net/pipermail/buildroot/2020-May/283180.html
True, that's what I said. That was based on the assumption that the options would be in package/freescale-imx/Config.in.
But now, seeing the reasonning by Thomas, I agree with him: those are better suited to live in package/freescale-imx/firmware-imx/Config.in/
And thus it is less clean that the variant selection in the generic choice would have to catter with options specific to a package.
Hence, the "default y if ..." is indeed better.
Sorry I did not have that insight to begin with...
Regards,
Yann E. MORIN.
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'
PATCH 1/2 package/freescale-imx: Add option for all i.MX FW needs
Yann, Sebastien, all,
Quoted 32 lines
Quoted 18 lines
Quoted 13 lines · Thomas
However, I am wondering if package/freescale-imx/Config.in is the right place for all this logic. After all, this is only related to the firmware-imx package.
Shouldn't we instead move that to package/freescale-imx/firmware-imx/Config.in, with the following form:
config
BR2_PACKAGE_FREESCALE_IMX_NEEDS_DDR_FW
bool
default y ifBR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8Mdefault y ifBR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8MMdefault y ifBR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8MNQuoted 3 lines
and ditto the other options ? Here as well, it would require a preparation patch to take care of the
NEEDS_DDR_FWcase, and then your patch that handles all other FW files.Quoted 7 lines
I'd like to have Yann's and/or Gary's feedback on this. I'm using 'select' based on this comment:
"
As Yann mentioned on IRC:
"Usually, when we introduce such option, it does not 'default y' based
on some other options. Instead, the other options 'select' it."
"
from http://lists.busybox.net/pipermail/buildroot/2020-May/283180.htmlTrue, that's what I said. That was based on the assumption that the options would be in package/freescale-imx/Config.in.
But now, seeing the reasonning by Thomas, I agree with him: those are better suited to live in package/freescale-imx/firmware-imx/Config.in/
Quoted 6 lines
And thus it is less clean that the variant selection in the generic choice would have to catter with options specific to a package.
Hence, the "default y if ..." is indeed better.
Sorry I did not have that insight to begin with...
No worries ; thank you all for your comments!
Will send out a v2 soon..
BTW, I'm also thinking of embedding the 'install path' fix proposed by Sebastien here:
http://lists.busybox.net/pipermail/buildroot/2020-June/284875.html
BR,
Stephane.
Quoted 11 lines
Regards,
Yann E. MORIN.Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'
PATCH 1/2 package/freescale-imx: Add option for all i.MX FW needs
In reply to Stephane Viau (OSS)Quoted 140 lines · Stephane Viau (OSS)
Date: Thu, 25 Jun 2020 06:33:59 +0000
From: "Stephane Viau (OSS)" <[email protected]>
To: Thomas Petazzoni <[email protected]>, "Yann E. MORIN"
<[email protected]>, Gary Bisson <[email protected]>
Cc: Refik Tuzakli <[email protected]>, "buildroot at buildroot.org"
<[email protected]>
Subject: Re: [Buildroot] [PATCH 1/2] package/freescale-imx: Add option for
all i.MX FW needsQuoted 1 line
Hello,
Hello Thomas, Yann/Gary,
Quoted 3 lines
Thanks for doing this work! It's definitely bringing some good sanity into this firmware-imx mess! See below some comments.
Glad you like it & thank you for your comments.
Quoted 91 lines
Quoted 91 lines
package/freescale-imx/Config.in +34
-0@@ -12,40 +12,63 @@ choice config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX25_3STACK bool "imx25-3stack" + select BR2_PACKAGE_FREESCALE_IMX_NEED_SDMA_FW config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX27ADS bool "imx27ads" + select BR2_PACKAGE_FREESCALE_IMX_NEED_SDMA_FW + select BR2_PACKAGE_FREESCALE_IMX_NEED_VPU_FW_LEGACY config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX37_3STACK bool "imx37-3stack" + select BR2_PACKAGE_FREESCALE_IMX_NEED_SDMA_FW + select BR2_PACKAGE_FREESCALE_IMX_NEED_VPU_FW_LEGACY config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX50 bool "imx50" + select BR2_PACKAGE_FREESCALE_IMX_NEED_SDMA_FW + select BR2_PACKAGE_FREESCALE_IMX_NEED_VPU_FW_LEGACY config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX51 bool "imx51" + select BR2_PACKAGE_FREESCALE_IMX_NEED_SDMA_FW + select BR2_PACKAGE_FREESCALE_IMX_NEED_VPU_FW_LEGACY config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX53 bool "imx53" + select BR2_PACKAGE_FREESCALE_IMX_NEED_SDMA_FW + select BR2_PACKAGE_FREESCALE_IMX_NEED_VPU_FW_LEGACY config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX6Q bool "imx6q/imx6dl" + select BR2_PACKAGE_FREESCALE_IMX_NEED_EPDC_FW + select BR2_PACKAGE_FREESCALE_IMX_NEED_SDMA_FW + select BR2_PACKAGE_FREESCALE_IMX_NEED_VPU_FW_LEGACY config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX6S bool "imx6sl/imx6sx" + select BR2_PACKAGE_FREESCALE_IMX_NEED_EPDC_FW + select BR2_PACKAGE_FREESCALE_IMX_NEED_SDMA_FW + select BR2_PACKAGE_FREESCALE_IMX_NEED_VPU_FW_LEGACY config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX6UL bool "imx6ul/imx6ull" + select BR2_PACKAGE_FREESCALE_IMX_NEED_SDMA_FW + select BR2_PACKAGE_FREESCALE_IMX_NEED_VPU_FW_LEGACY config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX7 bool "imx7d/imx7ulp" + select BR2_PACKAGE_FREESCALE_IMX_NEED_SDMA_FW + select BR2_PACKAGE_FREESCALE_IMX_NEED_VPU_FW_LEGACY config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8 bool "imx8" + select BR2_PACKAGE_FREESCALE_IMX_NEED_VPU_FW_IMX8_IMX8X config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8M bool "imx8m" select BR2_PACKAGE_FREESCALE_IMX_NEED_DDR_FW + select BR2_PACKAGE_FREESCALE_IMX_NEED_HDMI_FW config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8MM bool "imx8mm"@@ -57,6 +80,7 @@ config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8MN config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8X bool "imx8x" + select BR2_PACKAGE_FREESCALE_IMX_NEED_VPU_FW_IMX8_IMX8X endchoice config BR2_PACKAGE_FREESCALE_IMX_PLATFORM@@ -102,6 +126,21 @@ config BR2_PACKAGE_FREESCALE_IMX_HAS_VIV_GPU config BR2_PACKAGE_FREESCALE_IMX_NEED_DDR_FW bool +config BR2_PACKAGE_FREESCALE_IMX_NEED_EPDC_FW + bool + +config BR2_PACKAGE_FREESCALE_IMX_NEED_HDMI_FW + bool + +config BR2_PACKAGE_FREESCALE_IMX_NEED_SDMA_FW + bool + +config BR2_PACKAGE_FREESCALE_IMX_NEED_VPU_FW_LEGACYQuoted 8 lines
package/freescale-imx/Config.in config BR2_PACKAGE_FREESCALE_IMX_HAS_VIV_GPU · line 142
Quoted 4 lines
package/freescale-imx/Config.in +4
-0+ bool + +config BR2_PACKAGE_FREESCALE_IMX_NEED_VPU_FW_IMX8_IMX8X + boolIt would be nicer to use "NEEDS" instead of "NEED". That would require a preparation patch that renames
BR2_PACKAGE_FREESCALE_IMX_NEED_DDR_FWtoBR2_PACKAGE_FREESCALE_IMX_NEEDS_DDR_FW.Agreed.
Quoted 14 lines
However, I am wondering if package/freescale-imx/Config.in is the right place for all this logic. After all, this is only related to the firmware-imx package.
Shouldn't we instead move that to package/freescale-imx/firmware-imx/Config.in, with the following form:
config
BR2_PACKAGE_FREESCALE_IMX_NEEDS_DDR_FW
bool
default y ifBR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8Mdefault y ifBR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8MMdefault y ifBR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8MNQuoted 3 lines
and ditto the other options ? Here as well, it would require a preparation patch to take care of the
NEEDS_DDR_FWcase, and then your patch that handles all other FW files.
Quoted 7 lines
I'd like to have Yann's and/or Gary's feedback on this. I'm using 'select' based on this comment:
"
As Yann mentioned on IRC:
"Usually, when we introduce such option, it does not 'default y' based
on some other options. Instead, the other options 'select' it."
"
from http://lists.busybox.net/pipermail/buildroot/2020-May/283180.html
If you insert a prompt statement, then that allows to NOT include the firmware if explicitely turned off.
I'm currently working on an imx8 platform without VPU needs. I don't like shipping firmware that I don't need.
Kurt
PATCH 1/2 package/freescale-imx: Add option for all i.MX FW needs
In reply to Stephane ViauHi Stephane,
Sorry for the late reply, apart for the comments already made by otherse I have one suggestion below.
Quoted 101 lines · Stephane Viau
Some SoC need a HDMI FW for their bootloader, some other require EPDC, SDMA and/or VPU.
Instead of trying to "guess" what firmware images need to be installed in firmware-imx.mk, let the Config framework do the job and allow each SoC to actually 'select' what firmware they need.Note that this patch should also help introducing an eventual DP FW, as Gary mentioned in a separate thread [1].
[1] http://lists.busybox.net/pipermail/buildroot/2020-May/283181.html
Suggested-by Yann E. MORIN <[email protected]>Signed-off-by Stephane Viau <[email protected]>--- package/freescale-imx/Config.in | 39 +++++++++++++++++++++++++++++++++++++++ 1 file changed, 39 insertions(+)package/freescale-imx/Config.in +28
-0@@ -12,40 +12,63 @@ choice config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX25_3STACK bool "imx25-3stack" + select BR2_PACKAGE_FREESCALE_IMX_NEED_SDMA_FW config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX27ADS bool "imx27ads" + select BR2_PACKAGE_FREESCALE_IMX_NEED_SDMA_FW + select BR2_PACKAGE_FREESCALE_IMX_NEED_VPU_FW_LEGACY config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX37_3STACK bool "imx37-3stack" + select BR2_PACKAGE_FREESCALE_IMX_NEED_SDMA_FW + select BR2_PACKAGE_FREESCALE_IMX_NEED_VPU_FW_LEGACY config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX50 bool "imx50" + select BR2_PACKAGE_FREESCALE_IMX_NEED_SDMA_FW + select BR2_PACKAGE_FREESCALE_IMX_NEED_VPU_FW_LEGACY config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX51 bool "imx51" + select BR2_PACKAGE_FREESCALE_IMX_NEED_SDMA_FW + select BR2_PACKAGE_FREESCALE_IMX_NEED_VPU_FW_LEGACY config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX53 bool "imx53" + select BR2_PACKAGE_FREESCALE_IMX_NEED_SDMA_FW + select BR2_PACKAGE_FREESCALE_IMX_NEED_VPU_FW_LEGACY config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX6Q bool "imx6q/imx6dl" + select BR2_PACKAGE_FREESCALE_IMX_NEED_EPDC_FW + select BR2_PACKAGE_FREESCALE_IMX_NEED_SDMA_FW + select BR2_PACKAGE_FREESCALE_IMX_NEED_VPU_FW_LEGACY config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX6S bool "imx6sl/imx6sx" + select BR2_PACKAGE_FREESCALE_IMX_NEED_EPDC_FW + select BR2_PACKAGE_FREESCALE_IMX_NEED_SDMA_FW + select BR2_PACKAGE_FREESCALE_IMX_NEED_VPU_FW_LEGACY config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX6UL bool "imx6ul/imx6ull" + select BR2_PACKAGE_FREESCALE_IMX_NEED_SDMA_FW + select BR2_PACKAGE_FREESCALE_IMX_NEED_VPU_FW_LEGACY config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX7 bool "imx7d/imx7ulp" + select BR2_PACKAGE_FREESCALE_IMX_NEED_SDMA_FW + select BR2_PACKAGE_FREESCALE_IMX_NEED_VPU_FW_LEGACY config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8 bool "imx8" + select BR2_PACKAGE_FREESCALE_IMX_NEED_VPU_FW_IMX8_IMX8X config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8M bool "imx8m" select BR2_PACKAGE_FREESCALE_IMX_NEED_DDR_FW + select BR2_PACKAGE_FREESCALE_IMX_NEED_HDMI_FW config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8MM bool "imx8mm"@@ -57,6 +80,7 @@ config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8MN config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8X bool "imx8x" + select BR2_PACKAGE_FREESCALE_IMX_NEED_VPU_FW_IMX8_IMX8X endchoice config BR2_PACKAGE_FREESCALE_IMX_PLATFORM@@ -102,6 +126,21 @@ config BR2_PACKAGE_FREESCALE_IMX_HAS_VIV_GPU config BR2_PACKAGE_FREESCALE_IMX_NEED_DDR_FW bool +config BR2_PACKAGE_FREESCALE_IMX_NEED_EPDC_FW + bool + +config BR2_PACKAGE_FREESCALE_IMX_NEED_HDMI_FW
package/freescale-imx/Config.in config BR2_PACKAGE_FREESCALE_IMX_HAS_VIV_GPU · line 142
Quoted 10 lines
package/freescale-imx/Config.in +10
-0+ bool + +config BR2_PACKAGE_FREESCALE_IMX_NEED_SDMA_FW + bool + +config BR2_PACKAGE_FREESCALE_IMX_NEED_VPU_FW_LEGACY + bool + +config BR2_PACKAGE_FREESCALE_IMX_NEED_VPU_FW_IMX8_IMX8X + bool
So here you would copy all VPU FW for "LEGACY" but the one for IMX8/IMX8X?
I'd rather have a generic IMX_NEED_VPU_FW for all platforms that require a VPU FW and then in firmware-imx.mk only copy the files relevant to the platform selected (imx35,51,6,8x), what do you think?
Regards,
Gary
PATCH 1/2 package/freescale-imx: Add option for all i.MX FW needs
Quoted 10 lines
________________________________________
From: Gary Bisson <[email protected]>
Sent: Monday, June 29, 2020 8:08 AM
To: Stephane Viau (OSS)
Cc: buildroot at buildroot.org; Gary Bisson; Refik Tuzakli; Yann E . MORIN
Subject: Re: [Buildroot] [PATCH 1/2] package/freescale-imx: Add option for all i.MX FW needsHi Stephane,
Hi Gary,
Quoted 114 lines
Sorry for the late reply, apart for the comments already made by otherse I have one suggestion below.
Quoted 109 lines · Stephane Viau
Some SoC need a HDMI FW for their bootloader, some other require EPDC, SDMA and/or VPU.
Instead of trying to "guess" what firmware images need to be installed in firmware-imx.mk, let the Config framework do the job and allow each SoC to actually 'select' what firmware they need.Note that this patch should also help introducing an eventual DP FW, as Gary mentioned in a separate thread [1].
[1] http://lists.busybox.net/pipermail/buildroot/2020-May/283181.html
Suggested-by Yann E. MORIN <[email protected]>Signed-off-by Stephane Viau <[email protected]>--- package/freescale-imx/Config.in | 39 +++++++++++++++++++++++++++++++++++++++ 1 file changed, 39 insertions(+)package/freescale-imx/Config.in +36
-0@@ -12,40 +12,63 @@ choice config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX25_3STACK bool "imx25-3stack" + select BR2_PACKAGE_FREESCALE_IMX_NEED_SDMA_FW config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX27ADS bool "imx27ads" + select BR2_PACKAGE_FREESCALE_IMX_NEED_SDMA_FW + select BR2_PACKAGE_FREESCALE_IMX_NEED_VPU_FW_LEGACY config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX37_3STACK bool "imx37-3stack" + select BR2_PACKAGE_FREESCALE_IMX_NEED_SDMA_FW + select BR2_PACKAGE_FREESCALE_IMX_NEED_VPU_FW_LEGACY config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX50 bool "imx50" + select BR2_PACKAGE_FREESCALE_IMX_NEED_SDMA_FW + select BR2_PACKAGE_FREESCALE_IMX_NEED_VPU_FW_LEGACY config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX51 bool "imx51" + select BR2_PACKAGE_FREESCALE_IMX_NEED_SDMA_FW + select BR2_PACKAGE_FREESCALE_IMX_NEED_VPU_FW_LEGACY config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX53 bool "imx53" + select BR2_PACKAGE_FREESCALE_IMX_NEED_SDMA_FW + select BR2_PACKAGE_FREESCALE_IMX_NEED_VPU_FW_LEGACY config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX6Q bool "imx6q/imx6dl" + select BR2_PACKAGE_FREESCALE_IMX_NEED_EPDC_FW + select BR2_PACKAGE_FREESCALE_IMX_NEED_SDMA_FW + select BR2_PACKAGE_FREESCALE_IMX_NEED_VPU_FW_LEGACY config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX6S bool "imx6sl/imx6sx" + select BR2_PACKAGE_FREESCALE_IMX_NEED_EPDC_FW + select BR2_PACKAGE_FREESCALE_IMX_NEED_SDMA_FW + select BR2_PACKAGE_FREESCALE_IMX_NEED_VPU_FW_LEGACY config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX6UL bool "imx6ul/imx6ull" + select BR2_PACKAGE_FREESCALE_IMX_NEED_SDMA_FW + select BR2_PACKAGE_FREESCALE_IMX_NEED_VPU_FW_LEGACY config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX7 bool "imx7d/imx7ulp" + select BR2_PACKAGE_FREESCALE_IMX_NEED_SDMA_FW + select BR2_PACKAGE_FREESCALE_IMX_NEED_VPU_FW_LEGACY config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8 bool "imx8" + select BR2_PACKAGE_FREESCALE_IMX_NEED_VPU_FW_IMX8_IMX8X config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8M bool "imx8m" select BR2_PACKAGE_FREESCALE_IMX_NEED_DDR_FW + select BR2_PACKAGE_FREESCALE_IMX_NEED_HDMI_FW config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8MM bool "imx8mm"@@ -57,6 +80,7 @@ config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8MN config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8X bool "imx8x" + select BR2_PACKAGE_FREESCALE_IMX_NEED_VPU_FW_IMX8_IMX8X endchoice config BR2_PACKAGE_FREESCALE_IMX_PLATFORM@@ -102,6 +126,21 @@ config BR2_PACKAGE_FREESCALE_IMX_HAS_VIV_GPU config BR2_PACKAGE_FREESCALE_IMX_NEED_DDR_FW bool +config BR2_PACKAGE_FREESCALE_IMX_NEED_EPDC_FW + bool + +config BR2_PACKAGE_FREESCALE_IMX_NEED_HDMI_FW + bool + +config BR2_PACKAGE_FREESCALE_IMX_NEED_SDMA_FW + bool + +config BR2_PACKAGE_FREESCALE_IMX_NEED_VPU_FW_LEGACY + bool +
Quoted 8 lines
package/freescale-imx/Config.in config BR2_PACKAGE_FREESCALE_IMX_HAS_VIV_GPU · line 142
Quoted 2 lines
package/freescale-imx/Config.in +2
-0+config BR2_PACKAGE_FREESCALE_IMX_NEED_VPU_FW_IMX8_IMX8X + boolSo here you would copy all VPU FW for "LEGACY" but the one for IMX8/IMX8X?
I'd rather have a genericIMX_NEED_VPU_FWfor all platforms that require a VPU FW and then in firmware-imx.mk only copy the files relevant to the platform selected (imx35,51,6,8x), what do you think?
This whole section has been reworked in v2 ;
can you please review and let me know if you still want some improvement there?
BR,
Stephane.
Quoted 4 lines
Regards,
Gary
PATCH 2/2 package/freescale-imx/firmware-imx: Clean up the image/target semantic
In reply to Stephane ViauThe newly introduced BR2_PACKAGE_FREESCALE_IMX_NEED_xxx_FW symbols shall be used in lieue of the SoC type when installing images or binaries on target.
These new symbols let us define FIRMWARE_IMX_INSTALL_IMAGES_CMDS and FIRMWARE_IMX_INSTALL_TARGET_CMDS based on platform needs rather than SoC type.
--- package/freescale-imx/firmware-imx/firmware-imx.mk | 70 +++++++++++++++++----- 1 file changed, 54 insertions(+), 16 deletions(-)
package/freescale-imx/firmware-imx/firmware-imx.mk +54 -16
@@ -12,12 +12,13 @@ FIRMWARE_IMX_LICENSE = NXP Semiconductor Software License Agreement FIRMWARE_IMX_LICENSE_FILES = EULA COPYING FIRMWARE_IMX_REDISTRIBUTE = NO -FIRMWARE_IMX_BLOBS = sdma vpu - define FIRMWARE_IMX_EXTRACT_CMDS $(call FREESCALE_IMX_EXTRACT_HELPER,$(FIRMWARE_IMX_DL_DIR)/$(FIRMWARE_IMX_SOURCE)) endef +# firmware-imx install images section: +###################################### + ifeq ($(BR2_PACKAGE_FREESCALE_IMX_NEED_DDR_FW),y) FIRMWARE_IMX_INSTALL_IMAGES = YES
@@ -71,36 +72,73 @@ define FIRMWARE_IMX_PREPARE_DDR_FW $(BINARIES_DIR)/ddr4_201810_fw.bin ln -sf $(BINARIES_DIR)/ddr4_201810_fw.bin $(BINARIES_DIR)/ddr_fw.bin endef -endif +endif # DDRFW_LPDDR4 || DDRFW_DDR4 +endif # NEED_DDR_FW + +ifeq ($(BR2_PACKAGE_FREESCALE_IMX_NEED_HDMI_FW),y) +FIRMWARE_IMX_INSTALL_IMAGES = YES -ifeq ($(BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8M),y) define FIRMWARE_IMX_PREPARE_HDMI_FW cp $(@D)/firmware/hdmi/cadence/signed_hdmi_imx8m.bin \ $(BINARIES_DIR)/signed_hdmi_imx8m.bin endef -endif +endif # NEED_HDMI_FW define FIRMWARE_IMX_INSTALL_IMAGES_CMDS $(FIRMWARE_IMX_PREPARE_DDR_FW) $(FIRMWARE_IMX_PREPARE_HDMI_FW) endef -else ifeq ($(BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8X),y) -define FIRMWARE_IMX_INSTALL_TARGET_CMDS + +# firmware-imx install target section: +###################################### + +ifeq ($(BR2_PACKAGE_FREESCALE_IMX_NEED_EPDC_FW),y) +FIRMWARE_IMX_INSTALL_TARGET = YES + +define FIRMWARE_IMX_INSTALL_TARGET_EPDC_FW + mkdir -p $(TARGET_DIR)/lib/firmware/imx + cp -r $(@D)/firmware/epdc $(TARGET_DIR)/lib/firmware/imx + mv $(TARGET_DIR)/lib/firmware/imx/epdc/epdc_ED060XH2C1.fw.nonrestricted \ + $(TARGET_DIR)/lib/firmware/imx/epdc/epdc_ED060XH2C1.fw +endef +endif # NEED_EPDC_FW + +ifeq ($(BR2_PACKAGE_FREESCALE_IMX_NEED_SDMA_FW),y) +FIRMWARE_IMX_INSTALL_TARGET = YES + +define FIRMWARE_IMX_INSTALL_TARGET_SDMA_FW + mkdir -p $(TARGET_DIR)/lib/firmware/imx + cp -r $(@D)/firmware/vpu $(TARGET_DIR)/lib/firmware +endef +endif # NEED_SDMA_FW + +ifeq ($(BR2_PACKAGE_FREESCALE_IMX_NEED_VPU_FW),y) +FIRMWARE_IMX_INSTALL_TARGET = YES + +ifeq ($(BR2_PACKAGE_FIRMWARE_VPUFW_GENERIC),y) + +define FIRMWARE_IMX_INSTALL_TARGET_VPU_FW + mkdir -p $(TARGET_DIR)/lib/firmware/imx + cp -r $(@D)/firmware/vpu $(TARGET_DIR)/lib/firmware +endef + +endif +ifeq ($(BR2_PACKAGE_FIRMWARE_VPUFW_IMX8),y) + +define FIRMWARE_IMX_INSTALL_TARGET_VPU_FW $(INSTALL) -D -m 0644 $(@D)/firmware/vpu/vpu_fw_imx8_dec.bin \ $(TARGET_DIR)/lib/firmware/vpu/vpu_fw_imx8_dec.bin $(INSTALL) -D -m 0644 $(@D)/firmware/vpu/vpu_fw_imx8_enc.bin \ $(TARGET_DIR)/lib/firmware/vpu/vpu_fw_imx8_enc.bin endef -else + +endif +endif # NEED_VPU_FW + define FIRMWARE_IMX_INSTALL_TARGET_CMDS - mkdir -p $(TARGET_DIR)/lib/firmware/imx - for blobdir in $(FIRMWARE_IMX_BLOBS); do \ - cp -r $(@D)/firmware/$${blobdir} $(TARGET_DIR)/lib/firmware; \ - done - cp -r $(@D)/firmware/epdc $(TARGET_DIR)/lib/firmware/imx - mv $(TARGET_DIR)/lib/firmware/imx/epdc/epdc_ED060XH2C1.fw.nonrestricted \ - $(TARGET_DIR)/lib/firmware/imx/epdc/epdc_ED060XH2C1.fw + $(FIRMWARE_IMX_INSTALL_TARGET_EPDC_FW) + $(FIRMWARE_IMX_INSTALL_TARGET_SDMA_FW) + $(FIRMWARE_IMX_INSTALL_TARGET_VPU_FW) endef -endif $(eval $(generic-package))
Signature · 1 line
2.7.4
Fabio Estevam
reviewerPATCH 2/2 package/freescale-imx/firmware-imx: Clean up the image/target semantic
Hi Stephane,
Quoted 11 lines · Stephane Viau
The newly introduced
BR2_PACKAGE_FREESCALE_IMX_NEED_xxx_FWsymbols shall be used in lieue of the SoC type when installing images or binaries on target.These new symbols let us define
FIRMWARE_IMX_INSTALL_IMAGES_CMDSandFIRMWARE_IMX_INSTALL_TARGET_CMDSbased on platform needs rather than SoC type.Suggested-by Yann E. MORIN <[email protected]>Signed-off-by Stephane Viau <[email protected]>
This looks like a nice solution, thanks:
PATCH 2/2 package/freescale-imx/firmware-imx: Clean up the image/target semantic
In reply to Stephane ViauHello,
Quoted 10 lines · On Wed, 24 Jun 2020 17:23:48 +0200 Stephane Viau <[email protected]>…
package/freescale-imx/firmware-imx/firmware-imx.mk | 70 +++++++++++++++++----- 1 file changed, 54 insertions(+), 16 deletions(-)package/freescale-imx/firmware-imx/firmware-imx.mk +0
-0@@ -12,12 +12,13 @@ FIRMWARE_IMX_LICENSE = NXP Semiconductor Software License Agreement FIRMWARE_IMX_LICENSE_FILES = EULA COPYING FIRMWARE_IMX_REDISTRIBUTE = NO
package/freescale-imx/firmware-imx/firmware-imx.mk FIRMWARE_IMX_LICENSE = NXP Semiconductor Software License Agreement · line 21
Quoted 10 lines
package/freescale-imx/firmware-imx/firmware-imx.mk +3
-2-FIRMWARE_IMX_BLOBS = sdma vpu - define FIRMWARE_IMX_EXTRACT_CMDS $(call FREESCALE_IMX_EXTRACT_HELPER,$(FIRMWARE_IMX_DL_DIR)/$(FIRMWARE_IMX_SOURCE)) endef +# firmware-imx install images section: +###################################### +
This comment is not needed.
Quoted 16 lines
package/freescale-imx/firmware-imx/firmware-imx.mk +5
-2ifeq ($(BR2_PACKAGE_FREESCALE_IMX_NEED_DDR_FW),y) FIRMWARE_IMX_INSTALL_IMAGES = YES@@ -71,36 +72,73 @@ define FIRMWARE_IMX_PREPARE_DDR_FW $(BINARIES_DIR)/ddr4_201810_fw.bin ln -sf $(BINARIES_DIR)/ddr4_201810_fw.bin $(BINARIES_DIR)/ddr_fw.bin endef -endif +endif # DDRFW_LPDDR4 || DDRFW_DDR4 +endif # NEED_DDR_FW + +ifeq ($(BR2_PACKAGE_FREESCALE_IMX_NEED_HDMI_FW),y) +FIRMWARE_IMX_INSTALL_IMAGES = YES -ifeq ($(BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8M),y) define FIRMWARE_IMX_PREPARE_HDMI_FW
package/freescale-imx/firmware-imx/firmware-imx.mk define FIRMWARE_IMX_PREPARE_DDR_FW · line 90
Quoted 10 lines
package/freescale-imx/firmware-imx/firmware-imx.mk +1
-1cp $(@D)/firmware/hdmi/cadence/signed_hdmi_imx8m.bin \ $(BINARIES_DIR)/signed_hdmi_imx8m.bin endef -endif +endif # NEED_HDMI_FW define FIRMWARE_IMX_INSTALL_IMAGES_CMDS $(FIRMWARE_IMX_PREPARE_DDR_FW) $(FIRMWARE_IMX_PREPARE_HDMI_FW) endef
I think it would be good to group that together with the IMX_INSTALL_TARGET_CMDS definition, towards the end of the file.
package/freescale-imx/firmware-imx/firmware-imx.mk define FIRMWARE_IMX_PREPARE_DDR_FW · line 94
Quoted 6 lines
package/freescale-imx/firmware-imx/firmware-imx.mk +4
-2-else ifeq ($(BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8X),y) -define FIRMWARE_IMX_INSTALL_TARGET_CMDS + +# firmware-imx install target section: +###################################### +
Comment not really useful.
Quoted 11 lines
package/freescale-imx/firmware-imx/firmware-imx.mk +11
-0+ifeq ($(BR2_PACKAGE_FREESCALE_IMX_NEED_EPDC_FW),y) +FIRMWARE_IMX_INSTALL_TARGET = YES + +define FIRMWARE_IMX_INSTALL_TARGET_EPDC_FW + mkdir -p $(TARGET_DIR)/lib/firmware/imx + cp -r $(@D)/firmware/epdc $(TARGET_DIR)/lib/firmware/imx + mv $(TARGET_DIR)/lib/firmware/imx/epdc/epdc_ED060XH2C1.fw.nonrestricted \ + $(TARGET_DIR)/lib/firmware/imx/epdc/epdc_ED060XH2C1.fw +endef +endif # NEED_EPDC_FW +
package/freescale-imx/firmware-imx/firmware-imx.mk define FIRMWARE_IMX_PREPARE_DDR_FW · line 115
Quoted 10 lines
package/freescale-imx/firmware-imx/firmware-imx.mk +10
-0+ifeq ($(BR2_PACKAGE_FREESCALE_IMX_NEED_SDMA_FW),y) +FIRMWARE_IMX_INSTALL_TARGET = YES + +define FIRMWARE_IMX_INSTALL_TARGET_SDMA_FW + mkdir -p $(TARGET_DIR)/lib/firmware/imx + cp -r $(@D)/firmware/vpu $(TARGET_DIR)/lib/firmware +endef +endif # NEED_SDMA_FW + +ifeq ($(BR2_PACKAGE_FREESCALE_IMX_NEED_VPU_FW),y)
This option doesn't exist in your Config.in.
package/freescale-imx/firmware-imx/firmware-imx.mk define FIRMWARE_IMX_PREPARE_DDR_FW · line 118
Quoted 3 lines
package/freescale-imx/firmware-imx/firmware-imx.mk +3
-0+FIRMWARE_IMX_INSTALL_TARGET = YES + +ifeq ($(BR2_PACKAGE_FIRMWARE_VPUFW_GENERIC),y)
Are you sure this option exists ?
package/freescale-imx/firmware-imx/firmware-imx.mk define FIRMWARE_IMX_PREPARE_DDR_FW · line 126
Quoted 8 lines
package/freescale-imx/firmware-imx/firmware-imx.mk +8
-0+ +define FIRMWARE_IMX_INSTALL_TARGET_VPU_FW + mkdir -p $(TARGET_DIR)/lib/firmware/imx + cp -r $(@D)/firmware/vpu $(TARGET_DIR)/lib/firmware +endef + +endif +ifeq ($(BR2_PACKAGE_FIRMWARE_VPUFW_IMX8),y)
And this one ?
Thanks!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
cover package/freescale-imx: clean-up proposal
In reply to Stephane ViauSt?phane, All,
On 2020-06-24 17:23 +0200, Stephane Viau spake thusly:
Quoted 3 lines
Here is - as promised [1] - a patch set whose aim is to clean up the firmware-imx package. I believe this may help installing EPDC fw, SDMA FW and so on based on the actual need from each platform and respond to [2].
On principle, I like what you've proposed in this series. I haven't looked the details, though, and I will let the imx experts chime-in to validate the conditions udner which each firmware files are installed.
Regards,
Yann E. MORIN.
Quoted 21 lines
BR,
Stephane.[1] http://lists.busybox.net/pipermail/buildroot/2020-June/284032.html
[2] http://lists.busybox.net/pipermail/buildroot/2020-June/285218.htmlStephane Viau (2):
package/freescale-imx: Add option for all i.MX FW needs package/freescale-imx/firmware-imx: Clean up the image/target semanticpackage/freescale-imx/Config.in | 39 ++++++++++++ package/freescale-imx/firmware-imx/firmware-imx.mk | 70 +++++++++++++++++----- 2 files changed, 93 insertions(+), 16 deletions(-)Signature · 6 lines
2.7.4 _______________________________________________ buildroot mailing list buildroot at busybox.net http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'