Skip to contentSkip to conversation

boot/uboot/: Name U-Boot boot script image

PATCH In review Yair Ben-Avraham 3 participants 4 messages Jun 23, 2020 – Jan 9, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 boot/uboot/: Name U-Boot boot script image

---
 boot/uboot/Config.in | 5 +++++
 boot/uboot/uboot.mk  | 1 +
 2 files changed, 6 insertions(+)
boot/uboot/Config.in +5 -0
index 8cce9b1bae..310c4f8186 100644
@@ -568,6 +568,11 @@ config BR2_TARGET_UBOOT_BOOT_SCRIPT_SOURCE
        help
          Source file to generate the U-Boot boot script.
 
+config BR2_TARGET_UBOOT_BOOT_SCRIPT_IMAGE_NAME
+       string "U-Boot boot script image name"
+       help
+         Image (*not* file) name.
+
 endif
 
 if BR2_TARGET_UBOOT_BUILD_SYSTEM_KCONFIG
boot/uboot/uboot.mk +1 -0
index 71689207e3..ab945eb159 100644
@@ -340,6 +340,7 @@ define UBOOT_INSTALL_IMAGES_CMDS
        $(UBOOT_GENERATE_ENV_IMAGE)
        $(if $(BR2_TARGET_UBOOT_BOOT_SCRIPT),
                $(MKIMAGE) -C none -A $(MKIMAGE_ARCH) -T script \
+                       -n $(BR2_TARGET_UBOOT_BOOT_SCRIPT_IMAGE_NAME) \
                        -d $(call qstrip,$(BR2_TARGET_UBOOT_BOOT_SCRIPT_SOURCE)) \
                        $(BINARIES_DIR)/boot.scr)
 endef

--
2.20.1

#1 lore raw

PATCH 1/1 boot/uboot/: Name U-Boot boot script image

Yair, All,

On 2020-06-23 23:04 +0000, Yair Ben-Avraham spake thusly:

Quoted 27 lines
---
 boot/uboot/Config.in | 5 +++++
 boot/uboot/uboot.mk  | 1 +
 2 files changed, 6 insertions(+)
boot/uboot/Config.in +5 -0
index 8cce9b1bae..310c4f8186 100644
@@ -568,6 +568,11 @@ config BR2_TARGET_UBOOT_BOOT_SCRIPT_SOURCE
        help
          Source file to generate the U-Boot boot script.
 
+config BR2_TARGET_UBOOT_BOOT_SCRIPT_IMAGE_NAME
+       string "U-Boot boot script image name"
+       help
+         Image (*not* file) name.
+
 endif
 
 if BR2_TARGET_UBOOT_BUILD_SYSTEM_KCONFIG
boot/uboot/uboot.mk +0 -0
index 71689207e3..ab945eb159 100644

boot/uboot/uboot.mk define UBOOT_INSTALL_IMAGES_CMDS · line 343

Quoted 4 lines
boot/uboot/uboot.mk +1 -0
@@ -340,6 +340,7 @@ define UBOOT_INSTALL_IMAGES_CMDS
        $(UBOOT_GENERATE_ENV_IMAGE)
        $(if $(BR2_TARGET_UBOOT_BOOT_SCRIPT),
                $(MKIMAGE) -C none -A $(MKIMAGE_ARCH) -T script \
+                       -n $(BR2_TARGET_UBOOT_BOOT_SCRIPT_IMAGE_NAME) \

So, when the user does not set the option, we will end up passing:

    -n ""

Is that correct?

Regards,
Yann E. MORIN.

Quoted 9 lines
boot/uboot/uboot.mk +0 -1
                        -d $(call qstrip,$(BR2_TARGET_UBOOT_BOOT_SCRIPT_SOURCE)) \
                        $(BINARIES_DIR)/boot.scr)
 endef
--

2.20.1
_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#2 lore raw

PATCH 1/1 boot/uboot/: Name U-Boot boot script image

Hi Yann,

Not elegant, but yes. Anyway an empty string is the default in case no image name is mentioned.

See u-boot/tools/mkimage.c static struct image_tool_params params

Yair
--
Yair Ben-Avraham
yairba at protonmail.com
+31.6.1316.5535

??????? Original Message ???????

Quoted 77 lines · Yann E. MORIN

Yair, All,

On 2020-06-23 23:04 +0000, Yair Ben-Avraham spake thusly:

Quoted 35 lines
Signed-off-by Yair Ben Avraham yairba at protonmail.com

------------------------------------------------------

boot/uboot/Config.in | 5 +++++ boot/uboot/uboot.mk | 1 +

2 files changed, 6 insertions(+)
boot/uboot/Config.in +0 -0
index 8cce9b1bae..310c4f8186 100644
@@ -568,6 +568,11 @@ config BR2_TARGET_UBOOT_BOOT_SCRIPT_SOURCE

help
Source file to generate the U-Boot boot script.

boot/uboot/Config.in +1 -4
+config BR2_TARGET_UBOOT_BOOT_SCRIPT_IMAGE_NAME
 
-         string "U-Boot boot script image name"
 
 
-         help
 
 
-           Image (*not* file) name.
 
 
-

endif
if BR2_TARGET_UBOOT_BUILD_SYSTEM_KCONFIG

boot/uboot/uboot.mk +0 -0
index 71689207e3..ab945eb159 100644

boot/uboot/uboot.mk define UBOOT_INSTALL_IMAGES_CMDS · line 344

Quoted 6 lines
boot/uboot/uboot.mk +0 -1
@@ -340,6 +340,7 @@ define UBOOT_INSTALL_IMAGES_CMDS
 $(UBOOT_GENERATE_ENV_IMAGE)
 $(if $(BR2_TARGET_UBOOT_BOOT_SCRIPT),
 $(MKIMAGE) -C none -A $(MKIMAGE_ARCH) -T script \
 
-                         -n $(BR2_TARGET_UBOOT_BOOT_SCRIPT_IMAGE_NAME) \\
 

So, when the user does not set the option, we will end up passing:

-n ""

Is that correct?

Regards,
Yann E. MORIN.

Quoted 6 lines
                        -d $(call qstrip,$(BR2_TARGET_UBOOT_BOOT_SCRIPT_SOURCE)) \\
                        $(BINARIES_DIR)/boot.scr)

endef

Quoted 7 lines

------

2.20.1

buildroot mailing list buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

--

.-----------------.--------------------.------------------.--------------------.

| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | /*\ | / \ HTML MAIL | v conspiracy. |

'------------------------------^-------^------------------^--------------------'

#3 lore raw
In reply to Yair Ben-Avraham

Hi Yair,

Quoted 1 line · Yair Ben-Avraham

Shortly after you submitted this patch, the logic for U-boot scripts moved
from boot/uboot to package/u-boot-tools. Could you update this patch to take that into account?

Also, please update the commit message to explain the use case. Why would you
want the name field in the script image to be set to anything? AFAIK it is not visible or used anywhere.

Quoted 26 lines
---
  boot/uboot/Config.in | 5 +++++
  boot/uboot/uboot.mk  | 1 +
  2 files changed, 6 insertions(+)
boot/uboot/Config.in +5 -0
index 8cce9b1bae..310c4f8186 100644
@@ -568,6 +568,11 @@ config BR2_TARGET_UBOOT_BOOT_SCRIPT_SOURCE
         help
           Source file to generate the U-Boot boot script.
 
+config BR2_TARGET_UBOOT_BOOT_SCRIPT_IMAGE_NAME
+       string "U-Boot boot script image name"
+       help
+         Image (*not* file) name.
+
  endif
 
  if BR2_TARGET_UBOOT_BUILD_SYSTEM_KCONFIG
boot/uboot/uboot.mk +0 -0
index 71689207e3..ab945eb159 100644

boot/uboot/uboot.mk define UBOOT_INSTALL_IMAGES_CMDS · line 343

Quoted 4 lines
boot/uboot/uboot.mk +1 -0
@@ -340,6 +340,7 @@ define UBOOT_INSTALL_IMAGES_CMDS
         $(UBOOT_GENERATE_ENV_IMAGE)
         $(if $(BR2_TARGET_UBOOT_BOOT_SCRIPT),
                 $(MKIMAGE) -C none -A $(MKIMAGE_ARCH) -T script \
+                       -n $(BR2_TARGET_UBOOT_BOOT_SCRIPT_IMAGE_NAME) \

We generally prefer explicit quoting, i.e.

-n "$(call qstrip,$(BR2_PACKAGE_HOST_UBOOT_TOOLS_SCRIPT_IMAGE_NAME))"

Regards,
Arnout

Quoted 10 lines
boot/uboot/uboot.mk +0 -1
                         -d $(call qstrip,$(BR2_TARGET_UBOOT_BOOT_SCRIPT_SOURCE)) \
                         $(BINARIES_DIR)/boot.scr)
  endef
--

2.20.1
_______________________________________________
buildroot mailing list
[email protected]
http://lists.busybox.net/mailman/listinfo/buildroot

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot