cpufreq: intel_pstate: Support raw epp and energy_efficiency
Subsystems (3)
Srinivas Pandruvada
maintainerv3 cover cpufreq: intel_pstate: Support raw epp and energy_efficiency
v3
Some edits for the description as suggested by Doug
v2
Remove raw value support for EPB
Srinivas Pandruvada (2):
cpufreq: intel_pstate: Allow enable/disable energy efficiency
cpufreq: intel_pstate: Allow raw energy performance preference value
Documentation/admin-guide/pm/intel_pstate.rst | 13 ++- drivers/cpufreq/intel_pstate.c | 99 ++++++++++++++++--- 2 files changed, 99 insertions(+), 13 deletions(-)
Signature · 1 line
2.25.4
Srinivas Pandruvada
maintainerPATCH v3 1/2 cpufreq: intel_pstate: Allow enable/disable energy efficiency
By default intel_pstate driver disables energy efficiency by setting MSR_IA32_POWER_CTL bit 19 for Kaby Lake desktop CPU model in HWP mode. This CPU model is also shared by Coffee Lake desktop CPUs. This allows these systems to reach maximum possible frequency. But this adds power penalty, which some customers don't want. They want some way to enable/ disable dynamically.
So, add an additional attribute "energy_efficiency_enable" under /sys/devices/system/cpu/intel_pstate/ for these CPU models. This allows to read and write bit 19 ("Disable Energy Efficiency Optimization") in the MSR IA32_POWER_CTL.
This attribute is present in both HWP and non-HWP mode as this has an effect in both modes. Refer to Intel Software Developer's manual for details. The scope of this bit is package wide.
--- Documentation/admin-guide/pm/intel_pstate.rst | 7 +++ drivers/cpufreq/intel_pstate.c | 49 ++++++++++++++++++- 2 files changed, 54 insertions(+), 2 deletions(-)
Documentation/admin-guide/pm/intel_pstate.rst +7 -0
@@ -431,6 +431,13 @@ argument is passed to the kernel in the command line. supported in the current configuration, writes to this attribute will fail with an appropriate error. +``energy_efficiency_enable`` + This attribute is only present on platforms, which has CPUs matching + Kaby Lake desktop CPU model. By default "energy_efficiency" is disabled + on these CPU models in HWP mode by this driver. Enabling energy + efficiency may limit maximum operating frequency in both HWP and non + HWP mode. + Interpretation of Policy Attributes -----------------------------------
drivers/cpufreq/intel_pstate.c +47 -2
79 lines not on this page · raw message
Signature · 1 line
2.25.4
Srinivas Pandruvada
maintainerPATCH v3 2/2 cpufreq: intel_pstate: Allow raw energy performance preference value
In reply to Srinivas PandruvadaCurrently using attribute "energy_performance_preference", user space can write one of the four per-defined preference string. These preference strings gets mapped to a hard-coded Energy-Performance Preference (EPP) or Energy-Performance Bias (EPB) knob.
These four values are supposed to cover broad spectrum of use cases, but are not uniformly distributed in the range. There are number of cases, where this is not enough. For example:
Suppose user wants more performance when connected to AC. Instead of using default "balance performance", the "performance" setting can be used. This changes EPP value from 0x80 to 0x00. But setting EPP to 0, results in electrical and thermal issues on some platforms. This results in aggressive throttling, which causes a drop in performance. But some value between 0x80 and 0x00 results in better performance. But that value can't be fixed as the power curve is not linear. In some cases just changing EPP from 0x80 to 0x75 is enough to get significant performance gain.
Similarly on battery EPP 0x80 can be very aggressive in power consumption. But picking up the next choice "balance power" results in too much loss of performance, which cause bad user experience in use case like "Google Hangout". It was observed that some value between these two EPP is optimal.
This change allows fine grain EPP tuning for platform like Chromebook. Here based on the product and use cases, different EPP values can be set. This change is similar to the change done for:/sys/devices/system/cpu/cpu*/power/energy_perf_bias
where user has choice to write a predefined string or raw value.
The change itself is trivial. When user preference doesn't match predefined string preferences and value is an unsigned integer and in range, use that value for EPP. When the EPP feature is not present writing raw value is not supported.
--- Documentation/admin-guide/pm/intel_pstate.rst | 6 ++- drivers/cpufreq/intel_pstate.c | 50 +++++++++++++++---- 2 files changed, 45 insertions(+), 11 deletions(-)
Documentation/admin-guide/pm/intel_pstate.rst +5 -1
@@ -561,7 +561,11 @@ somewhere between the two extremes: Strings written to the ``energy_performance_preference`` attribute are internally translated to integer values written to the processor's Energy-Performance Preference (EPP) knob (if supported) or its -Energy-Performance Bias (EPB) knob. +Energy-Performance Bias (EPB) knob. It is also possible to write a positive +integer value between 0 to 255, if the EPP feature is present. If the EPP +feature is not present, writing integer value to this attribute is not +supported. In this case, user can use + "/sys/devices/system/cpu/cpu*/power/energy_perf_bias" interface. [Note that tasks may by migrated from one CPU to another by the scheduler's load-balancing algorithm and if different energy vs performance hints are
drivers/cpufreq/intel_pstate.c +40 -10
105 lines not on this page · raw message
Signature · 1 line
2.25.4