Skip to contentSkip to conversation

staging: gasket: Convert symbolic permission to octal

PATCH In review Brooke Basile 2 participants 2 messages Jun 25, 2020 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: gasket: Convert symbolic permission to octal

Fixing checkpatch WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'.

---
 drivers/staging/gasket/gasket_sysfs.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/gasket/gasket_sysfs.h +1 -1
index ab5aa351d555..eb0fd3b0490f 100644
@@ -71,7 +71,7 @@ struct gasket_sysfs_attribute {
 
 #define GASKET_SYSFS_RO(_name, _show_function, _attr_type)                     \
 	{                                                                      \
-		.attr = __ATTR(_name, S_IRUGO, _show_function, NULL),          \
+		.attr = __ATTR(_name, 0444, _show_function, NULL),	       \
 		.data.attr_type = _attr_type                                   \
 	}
 
Signature · 1 line
2.27.0
maintainer
#1 lore raw
Quoted 12 lines · Brooke Basile

Fixing checkpatch WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'.

---
 drivers/staging/gasket/gasket_sysfs.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/gasket/gasket_sysfs.h +0 -0
index ab5aa351d555..eb0fd3b0490f 100644

drivers/staging/gasket/gasket_sysfs.h struct gasket_sysfs_attribute { · line 76

Quoted 7 lines
drivers/staging/gasket/gasket_sysfs.h +1 -1
@@ -71,7 +71,7 @@ struct gasket_sysfs_attribute {
 
 #define GASKET_SYSFS_RO(_name, _show_function, _attr_type)                     \
 	{                                                                      \
-		.attr = __ATTR(_name, S_IRUGO, _show_function, NULL),          \
+		.attr = __ATTR(_name, 0444, _show_function, NULL),	       \
 		.data.attr_type = _attr_type                                   \
 	}

Someone else sent this a few days before you did:

	 https://lore.kernel.org/r/[email protected]

sorry,

greg k-h