can: m_can: make m_can driver work with sleep state pinconfig
Subsystems (4)
PATCH 1/1 can: m_can: make m_can driver work with sleep state pinconfig
Hi,
When trying to use the m_can driver on an stm32mp15 based system, I found that I could not send or receive any data. Analyzing the pinctrl registers revealed, that the pins were configured for sleep state even when the can interfaces were in use.
Looking at the m_can_platform.c driver I found that:
commit f524f829b75a ("can: m_can: Create a m_can platform framework")
introduced a call to m_can_class_suspend() in the m_can_runtime_suspend() function which wasn't there in the original code and which causes the pins used by the controller to be configured for sleep state.
commit 0704c5743694 ("can: m_can_platform: remove unnecessary m_can_class_resume() call") already removed a bogus call to m_can_class_resume() from the m_can_runtime_resume() function, but failed to remove the matching
call to m_can_class_suspend() from the m_can_runtime_suspend() function.
Removing the bogus call to m_can_class_suspend() in the m_can_runtime_suspend() function fixes this.
--- drivers/net/can/m_can/m_can_platform.c | 2 -- 1 file changed, 2 deletions(-)
drivers/net/can/m_can/m_can_platform.c +0 -2
@@ -144,8 +144,6 @@ static int __maybe_unused m_can_runtime_suspend(struct device *dev)struct net_device *ndev =dev_get_drvdata (dev);struct m_can_classdev *mcan_class =netdev_priv (ndev); -m_can_class_suspend (dev); -clk_disable_unprepare (mcan_class->cclk);clk_disable_unprepare (mcan_class->hclk);
Signature · 14 lines
2.11.0 -- ___________________________________________________________ Ka-Ro electronics GmbH | Pascalstraße 22 | D - 52076 Aachen Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10 Geschäftsführer: Matthias Kaussen Handelsregistereintrag: Amtsgericht Aachen, HRB 4996 www.karo-electronics.de | [email protected] ___________________________________________________________
Lothar
Quoted 15 lines · Lothar Waßmann
Hi,
When trying to use the
m_candriver on an stm32mp15 based system, I found that I could not send or receive any data. Analyzing the pinctrl registers revealed, that the pins were configured for sleep state even when the can interfaces were in use.Looking at the
m_can_platform.cdriver I found that:commit
f524f829b75a("can:m_can: Create am_canplatform framework")introduced a call to
m_can_class_suspend()in them_can_runtime_suspend()function which wasn't there in the original code and which causes the pins used by the controller to be configured for sleep state.
Quoted 7 lines
commit
0704c5743694("can:m_can_platform: remove unnecessarym_can_class_resume()call") already removed a bogus call tom_can_class_resume()from them_can_runtime_resume()function, but failed to remove the matching
call tom_can_class_suspend()from them_can_runtime_suspend()function.Removing the bogus call to
m_can_class_suspend()in them_can_runtime_suspend()function fixes this.
Thank you for the patch Richard G has already submitted a similar patch
https://lore.kernel.org/patchwork/patch/1253401/
Dan