Skip to contentSkip to conversation

virtio-console: swap cols,rows fields in struct virtio_console_resize

PATCH New Szymon Lukasz 1 participant 1 message Jun 25, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 virtio-console: swap cols,rows fields in struct virtio_console_resize

I would like to propose a change to the order of these fields to match the implementation in the Linux Kernel. I checked that FreeBSD and OpenBSD do not implement the virtio feature using this struct.

If there is some less popular implementation of virtio driver that uses the same order as the current version of the spec then I would like to leave it to a hypervisor to deal with this issue, i.e. it should be outside the scope of the virtio spec.

---
 content.tex | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
content.tex +1 -1
index 91735e3..f95e708 100644
@@ -4886,8 +4886,8 @@ \subsubsection{Multiport Device Operation}\label{sec:Device Types / Console Devi
   a console size change.  \field{value} is unused.  The buffer is followed by the number of columns and rows:
 \begin{lstlisting}
 struct virtio_console_resize {
-        le16 cols;
         le16 rows;
+        le16 cols;
 };
 \end{lstlisting}
 \item [VIRTIO_CONSOLE_PORT_OPEN (6)] This message is sent by both the
Signature · 18 lines
2.27.0


This publicly archived list offers a means to provide input to the
OASIS Virtual I/O Device (VIRTIO) TC.

In order to verify user consent to the Feedback License terms and
to minimize spam in the list archive, subscription is required
before posting.

Subscribe: [email protected]
Unsubscribe: [email protected]
List help: [email protected]
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/