Skip to contentSkip to conversation

zfs: fix missing include for disk_partition definition

PATCH New Joel Johnson 2 participants 2 messages Jun 20, 2020 – Jun 25, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 zfs: fix missing include for disk_partition definition

Commit 0528979fa7ab ("part: Drop disk_partition_t typedef") changed to a struct. As a result it uncovered an apparent missing include in zfs_common.h for part.h which actually contains the definition. The ZFS handles the struct exclusively as pointers so it was only a warning.

warning: ?struct disk_partition? declared inside parameter list will not be visible outside of this definition or declaration
void zfs_set_blk_dev(struct blk_desc *rbdd, struct disk_partition *info);

Series-CC: Simon Glass <[email protected]>
---

 include/zfs_common.h | 2 ++
 1 file changed, 2 insertions(+)
include/zfs_common.h +2 -0
index 027ba91b28..cb83e59e83 100644
@@ -22,6 +22,8 @@
 #ifndef __ZFS_COMMON__
 #define __ZFS_COMMON__
 
+#include <part.h>
+
 #define SECTOR_SIZE			0x200
 #define SECTOR_BITS			9
 
Signature · 1 line
2.26.2
#1 lore raw

PATCH 1/1 zfs: fix missing include for disk_partition definition

Quoted 5 lines · Joel Johnson

Commit 0528979fa7ab ("part: Drop disk_partition_t typedef") changed to a struct. As a result it uncovered an apparent missing include in zfs_common.h for part.h which actually contains the definition. The ZFS handles the struct exclusively as pointers so it was only a warning.

Quoted 7 lines

warning: ?struct disk_partition? declared inside parameter list will not be visible outside of this definition or declaration
void zfs_set_blk_dev(struct blk_desc *rbdd, struct disk_partition *info);

Series-CC: Simon Glass <[email protected]>

Applied (back on June 23rd) to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200625/a58e77c5/attachment.sig>