Skip to contentSkip to conversation

iwlwifi: yoyo: don't print failure if debug firmware is missing

RFC PATCH In review Wolfram Sang 4 participants 7 messages Jun 25, 2020 – Nov 26, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

RFC PATCH 1/1 iwlwifi: yoyo: don't print failure if debug firmware is missing

Missing this firmware is not fatal, my wifi card still works. Even more, I couldn't find any documentation what it is or where to get it. So, I don't think the users should be notified if it is missing. If you browse the net, you see the message is present is in quite some logs. Better remove it.

---

This is only build tested because I wanted to get your opinions first. I couldn't find any explanation about yoyo, so I am entering unknown territory here.

 drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c +1 -1
index 7987a288917b..f180db2936e3 100644
@@ -468,7 +468,7 @@ void iwl_dbg_tlv_load_bin(struct device *dev, struct iwl_trans *trans)
 	if (!iwlwifi_mod_params.enable_ini)
 		return;
 
-	res = request_firmware(&fw, "iwl-debug-yoyo.bin", dev);
+	res = firmware_request_nowarn(&fw, "iwl-debug-yoyo.bin", dev);
 	if (res)
 		return;
 
Signature · 1 line
2.20.1
#1 lore raw
Quoted 8 lines · Wolfram Sang

Missing this firmware is not fatal, my wifi card still works. Even more, I couldn't find any documentation what it is or where to get it. So, I don't think the users should be notified if it is missing. If you browse the net, you see the message is present is in quite some logs. Better remove it.

---

Any input on this? Or people I should add to CC?

Quoted 24 lines

This is only build tested because I wanted to get your opinions first. I couldn't find any explanation about yoyo, so I am entering unknown territory here.

 drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c +1 -1
index 7987a288917b..f180db2936e3 100644
@@ -468,7 +468,7 @@ void iwl_dbg_tlv_load_bin(struct device *dev, struct iwl_trans *trans)
 	if (!iwlwifi_mod_params.enable_ini)
 		return;
 
-	res = request_firmware(&fw, "iwl-debug-yoyo.bin", dev);
+	res = firmware_request_nowarn(&fw, "iwl-debug-yoyo.bin", dev);
 	if (res)
 		return;
 
Signature · 1 line
2.20.1
#2 lore raw
Quoted 11 lines · Wolfram Sang
Quoted 8 lines · Wolfram Sang

Missing this firmware is not fatal, my wifi card still works. Even more, I couldn't find any documentation what it is or where to get it. So, I don't think the users should be notified if it is missing. If you browse the net, you see the message is present is in quite some logs. Better remove it.

---

Any input on this? Or people I should add to CC?

This was discussed on another thread:

https://lkml.kernel.org/r/[email protected]

Unless Intel folks object I'm planning to take this to wireless-drivers-next.

Signature · 1 line
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
#3 lore raw
Quoted 12 lines · Kalle Valo
Quoted 10 lines · Wolfram Sang
Quoted 8 lines · Wolfram Sang

Missing this firmware is not fatal, my wifi card still works. Even more, I couldn't find any documentation what it is or where to get it. So, I don't think the users should be notified if it is missing. If you browse the net, you see the message is present is in quite some logs. Better remove it.

---

Quoted 8 lines
Quoted 1 line

Any input on this? Or people I should add to CC?

This was discussed on another thread:

https://lkml.kernel.org/r/[email protected]

Unless Intel folks object I'm planning to take this to wireless-drivers-next.

Cool, thanks for the heads up!

#4 lore raw
In reply to Kalle Valo
Quoted 12 lines · Kalle Valo
Quoted 10 lines · Wolfram Sang
Quoted 8 lines · Wolfram Sang

Missing this firmware is not fatal, my wifi card still works. Even more, I couldn't find any documentation what it is or where to get it. So, I don't think the users should be notified if it is missing. If you browse the net, you see the message is present is in quite some logs. Better remove it.

---

Quoted 8 lines
Quoted 1 line

Any input on this? Or people I should add to CC?

This was discussed on another thread:

https://lkml.kernel.org/r/[email protected]

Unless Intel folks object I'm planning to take this to wireless-drivers-next.

Yes, please, just go ahead and take it. I have the same change in our internal tree, but I didn't have the time to send it out due to my vacations (from which I'm now back).

--
Cheers,
Luca.

#5 lore raw
In reply to Wolfram Sang
Quoted 7 lines · Wolfram Sang

Missing this firmware is not fatal, my wifi card still works. Even more, I couldn't find any documentation what it is or where to get it. So, I don't think the users should be notified if it is missing. If you browse the net, you see the message is present is in quite some logs. Better remove it.

Patch applied to wireless-drivers-next.git, thanks.

3f4600de8c93 iwlwifi: yoyo: don't print failure if debug firmware is missing

Signature · 3 lines
https://patchwork.kernel.org/patch/11625759/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
#6 lore raw
In reply to Wolfram Sang

[Sorry, I did not know where and how to import the thread, and only got the first message from Patchwork.]

Dear Linux folks,

Am 25.06.20 um 18:52 schrieb Wolfram Sang:

Quoted 6 lines

Missing this firmware is not fatal, my wifi card still works. Even more, I couldn't find any documentation what it is or where to get it. So, I don't think the users should be notified if it is missing. If you browse the net, you see the message is present is in quite some logs. Better remove it.

Quoted 6 lines

---

This is only build tested because I wanted to get your opinions first. I couldn't find any explanation about yoyo, so I am entering unknown territory here.

[…]

Despite commit 3f4600de8c93 (iwlwifi: yoyo: don't print failure if debug firmware is missing) being in Linux since version 5.9-rc1, I am still seeing this with Debian’s Linux 5.9.9.

Kind regards,

Paul