Skip to contentSkip to conversation

sch_cake: add RFC 8622 LE PHB support to CAKE diffserv handling

PATCH RESEND Applied Toke Høiland-Jørgensen 2 participants 2 messages Jun 25, 2020

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH RESEND 1/1 sch_cake: add RFC 8622 LE PHB support to CAKE diffserv handling

From: Kevin Darbyshire-Bryant <[email protected]>

Change tin mapping on diffserv3, 4 & 8 for LE PHB support, in essence making LE a member of the Bulk tin.

Bulk has the least priority and minimum of 1/16th total bandwidth in the face of higher priority traffic.

NB: Diffserv 3 & 4 swap tin 0 & 1 priorities from the default order as found in diffserv8, in case anyone is wondering why it looks a bit odd.

[ reword commit message slightly ]

---
Resending this as standalone after splitting out the rest of the series to -net

 net/sched/sch_cake.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
net/sched/sch_cake.c +4 -4
index 60f8ae578819..cae367515804 100644
@@ -312,8 +312,8 @@ static const u8 precedence[] = {
 };
 
 static const u8 diffserv8[] = {
-	2, 5, 1, 2, 4, 2, 2, 2,
-	0, 2, 1, 2, 1, 2, 1, 2,
+	2, 0, 1, 2, 4, 2, 2, 2,
+	1, 2, 1, 2, 1, 2, 1, 2,
 	5, 2, 4, 2, 4, 2, 4, 2,
 	3, 2, 3, 2, 3, 2, 3, 2,
 	6, 2, 3, 2, 3, 2, 3, 2,
@@ -323,7 +323,7 @@ static const u8 diffserv8[] = {
 };
 
 static const u8 diffserv4[] = {
-	0, 2, 0, 0, 2, 0, 0, 0,
+	0, 1, 0, 0, 2, 0, 0, 0,
 	1, 0, 0, 0, 0, 0, 0, 0,
 	2, 0, 2, 0, 2, 0, 2, 0,
 	2, 0, 2, 0, 2, 0, 2, 0,
@@ -334,7 +334,7 @@ static const u8 diffserv4[] = {
 };
 
 static const u8 diffserv3[] = {
-	0, 0, 0, 0, 2, 0, 0, 0,
+	0, 1, 0, 0, 2, 0, 0, 0,
 	1, 0, 0, 0, 0, 0, 0, 0,
 	0, 0, 0, 0, 0, 0, 0, 0,
 	0, 0, 0, 0, 0, 0, 0, 0,
Signature · 1 line
2.27.0
maintainer Applied
#1 lore raw

From: Toke Høiland-Jørgensen <[email protected]>
Date: Thu, 25 Jun 2020 22:18:00 +0200

Quoted 8 lines

From: Kevin Darbyshire-Bryant <[email protected]>

Change tin mapping on diffserv3, 4 & 8 for LE PHB support, in essence making LE a member of the Bulk tin.

Bulk has the least priority and minimum of 1/16th total bandwidth in the face of higher priority traffic.

Quoted 6 lines

NB: Diffserv 3 & 4 swap tin 0 & 1 priorities from the default order as found in diffserv8, in case anyone is wondering why it looks a bit odd.

[ reword commit message slightly ]

Applied, thanks!