Skip to contentSkip to conversation

dt-bindings: arm: bcm: Add a select to the RPI Firmware binding

PATCH Applied Maxime Ripard 5 participants 10 messages Jun 26, 2020 – Jul 27, 2020

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dt-bindings: arm: bcm: Add a select to the RPI Firmware binding

The RaspberryPi firmware binding uses two compatible, include simple-bus. The select statement generated by default will thus select any node that has simple-bus, not all of them being the raspberrypi firmware node.

This results in warnings being wrongfully reported. Let's add a custom select statement to fix that.

Fixes 5bc0b9be8544 ("dt-bindings: arm: bcm: Convert BCM2835 firmware binding to YAML")

---

The original binding has been merged through the clock tree, so it should be merged there.

Even though the original binding (and the DT) are using the simple-bus compatible, this creates some DTC warnings since the firmware really isn't a bus, so the node name doesn't match what a bus should have, none of the children have a reg property, #address-cells and #size-cells are missing, etc.

I can only guess that simple-bus was used to make the sub-devices probe, but maybe simple-mfd would be more appropriate here?

---
 .../bindings/arm/bcm/raspberrypi,bcm2835-firmware.yaml   | 9 +++++++++
 1 file changed, 9 insertions(+)
Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.yaml +9 -0
index b48ed875eb8e..17e4f20c8d39 100644
@@ -10,6 +10,15 @@ maintainers:
   - Eric Anholt <[email protected]>
   - Stefan Wahren <[email protected]>
 
+select:
+  properties:
+    compatible:
+      contains:
+        const: raspberrypi,bcm2835-firmware
+
+  required:
+    - compatible
+
 properties:
   compatible:
     items:
Signature · 1 line
2.26.2
Acked-by on v1 1/1
#1 lore raw
Quoted 9 lines · Maxime Ripard

The RaspberryPi firmware binding uses two compatible, include simple-bus. The select statement generated by default will thus select any node that has simple-bus, not all of them being the raspberrypi firmware node.

This results in warnings being wrongfully reported. Let's add a custom select statement to fix that.

Fixes 5bc0b9be8544 ("dt-bindings: arm: bcm: Convert BCM2835 firmware binding to YAML")

Thanks Maxime!

Signature · 1 line
Florian
maintainer
#2 lore raw
In reply to Maxime Ripard
Quoted 15 lines · Maxime Ripard

The RaspberryPi firmware binding uses two compatible, include simple-bus. The select statement generated by default will thus select any node that has simple-bus, not all of them being the raspberrypi firmware node.

This results in warnings being wrongfully reported. Let's add a custom select statement to fix that.

Fixes 5bc0b9be8544 ("dt-bindings: arm: bcm: Convert BCM2835 firmware binding to YAML")

---

The original binding has been merged through the clock tree, so it should be merged there.

Quoted 8 lines

Even though the original binding (and the DT) are using the simple-bus compatible, this creates some DTC warnings since the firmware really isn't a bus, so the node name doesn't match what a bus should have, none of the children have a reg property, #address-cells and #size-cells are missing, etc.

I can only guess that simple-bus was used to make the sub-devices probe, but maybe simple-mfd would be more appropriate here?

As these are not mmio devices, I think simple-mfd is better.

Quoted 27 lines
---
 .../bindings/arm/bcm/raspberrypi,bcm2835-firmware.yaml   | 9 +++++++++
 1 file changed, 9 insertions(+)
Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.yaml +9 -0
index b48ed875eb8e..17e4f20c8d39 100644
@@ -10,6 +10,15 @@ maintainers:
   - Eric Anholt <[email protected]>
   - Stefan Wahren <[email protected]>
 
+select:
+  properties:
+    compatible:
+      contains:
+        const: raspberrypi,bcm2835-firmware
+
+  required:
+    - compatible
+
 properties:
   compatible:
     items:
Signature · 1 line
2.26.2
#3 lore raw
In reply to Maxime Ripard

Hi Stephen, Mike,

Quoted 7 lines · Maxime Ripard

The RaspberryPi firmware binding uses two compatible, include simple-bus. The select statement generated by default will thus select any node that has simple-bus, not all of them being the raspberrypi firmware node.

This results in warnings being wrongfully reported. Let's add a custom select statement to fix that.

Quoted 7 lines
Fixes 5bc0b9be8544 ("dt-bindings: arm: bcm: Convert BCM2835 firmware binding to YAML")

---

The original binding has been merged through the clock tree, so it should be merged there.

Could you apply that patch to clk-next?

Thanks!
Maxime

Acked-by
#4 lore raw
Quoted 14 lines · Maxime Ripard

Hi Stephen, Mike,

Quoted 10 lines · Maxime Ripard

The RaspberryPi firmware binding uses two compatible, include simple-bus. The select statement generated by default will thus select any node that has simple-bus, not all of them being the raspberrypi firmware node.

This results in warnings being wrongfully reported. Let's add a custom select statement to fix that.

Fixes 5bc0b9be8544 ("dt-bindings: arm: bcm: Convert BCM2835 firmware binding to YAML")
Quoted 6 lines
Quoted 4 lines

---

The original binding has been merged through the clock tree, so it should be merged there.

Could you apply that patch to clk-next?

While I said 'simple-mfd' would be more appropriate, that's a separate issue I guess, so:

BTW, qcom,msm8996-apcc.yaml is also breaking linux-next.

maintainer
#5 lore raw
In reply to Maxime Ripard

Quoting Maxime Ripard (2020-07-23 08:44:21)

Quoted 13 lines

Hi Stephen, Mike,

Quoted 10 lines · Maxime Ripard

The RaspberryPi firmware binding uses two compatible, include simple-bus. The select statement generated by default will thus select any node that has simple-bus, not all of them being the raspberrypi firmware node.

This results in warnings being wrongfully reported. Let's add a custom select statement to fix that.

Fixes 5bc0b9be8544 ("dt-bindings: arm: bcm: Convert BCM2835 firmware binding to YAML")
Quoted 7 lines
Quoted 4 lines

---

The original binding has been merged through the clock tree, so it should be merged there.

Could you apply that patch to clk-next?

Rob has an unresolved comment on this patch.

maintainer Applied
#6 lore raw
In reply to Maxime Ripard

Quoting Maxime Ripard (2020-06-26 04:54:33)

Quoted 11 lines

The RaspberryPi firmware binding uses two compatible, include simple-bus. The select statement generated by default will thus select any node that has simple-bus, not all of them being the raspberrypi firmware node.

This results in warnings being wrongfully reported. Let's add a custom select statement to fix that.

Fixes 5bc0b9be8544 ("dt-bindings: arm: bcm: Convert BCM2835 firmware binding to YAML")

---

Applied to clk-next but I had to fix the fixes tag.

maintainer
#7 lore raw
In reply to Maxime Ripard

Quoting Maxime Ripard (2020-06-26 04:54:33)

Quoted 21 lines

The RaspberryPi firmware binding uses two compatible, include simple-bus. The select statement generated by default will thus select any node that has simple-bus, not all of them being the raspberrypi firmware node.

This results in warnings being wrongfully reported. Let's add a custom select statement to fix that.

Fixes 5bc0b9be8544 ("dt-bindings: arm: bcm: Convert BCM2835 firmware binding to YAML")

---

The original binding has been merged through the clock tree, so it should be merged there.

Even though the original binding (and the DT) are using the simple-bus compatible, this creates some DTC warnings since the firmware really isn't a bus, so the node name doesn't match what a bus should have, none of the children have a reg property, #address-cells and #size-cells are missing, etc.

Quoted 5 lines

I can only guess that simple-bus was used to make the sub-devices probe, but maybe simple-mfd would be more appropriate here?

---
 .../bindings/arm/bcm/raspberrypi,bcm2835-firmware.yaml   | 9 +++++++++
 1 file changed, 9 insertions(+)

Hmm. I'm still seeing warnings.

Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.example.dts:23.37-26.15: Warning (simple_bus_reg): /example-0/firmware/clocks: missing or emp ty reg/ranges property
Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.example.dt.yaml: firmware: $nodename:0: 'firmware' does not match '^(bus|soc|axi|ahb|apb)(@[0-9a-f]+)?$' Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.example.dt.yaml: firmware: '#address-cells' is a required property Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.example.dt.yaml: firmware: '#size-cells' is a required property Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.example.dt.yaml: firmware: 'ranges' is a required property

#8 lore raw
Quoted 28 lines · Stephen Boyd

Quoting Maxime Ripard (2020-06-26 04:54:33)

Quoted 21 lines

The RaspberryPi firmware binding uses two compatible, include simple-bus. The select statement generated by default will thus select any node that has simple-bus, not all of them being the raspberrypi firmware node.

This results in warnings being wrongfully reported. Let's add a custom select statement to fix that.

Fixes 5bc0b9be8544 ("dt-bindings: arm: bcm: Convert BCM2835 firmware binding to YAML")

---

The original binding has been merged through the clock tree, so it should be merged there.

Even though the original binding (and the DT) are using the simple-bus compatible, this creates some DTC warnings since the firmware really isn't a bus, so the node name doesn't match what a bus should have, none of the children have a reg property, #address-cells and #size-cells are missing, etc.

Quoted 5 lines

I can only guess that simple-bus was used to make the sub-devices probe, but maybe simple-mfd would be more appropriate here?

---
 .../bindings/arm/bcm/raspberrypi,bcm2835-firmware.yaml   | 9 +++++++++
 1 file changed, 9 insertions(+)
Quoted 8 lines

Hmm. I'm still seeing warnings.

Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.example.dts:23.37-26.15: Warning (simple_bus_reg): /example-0/firmware/clocks: missing or emp ty reg/ranges property
Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.example.dt.yaml: firmware: $nodename:0: 'firmware' does not match '^(bus|soc|axi|ahb|apb)(@[0-9a-f]+)?$' Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.example.dt.yaml: firmware: '#address-cells' is a required property Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.example.dt.yaml: firmware: '#size-cells' is a required property Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.example.dt.yaml: firmware: 'ranges' is a required property

Yeah, those are the warnings related to the issue we were discussing with Rob. The patch should fix an hard error.

I'll send a followup patch for the warnings.

Thanks!
Maxime

maintainer
#9 lore raw

Quoting Maxime Ripard (2020-07-27 08:52:32)

Quoted 38 lines · Stephen Boyd
Quoted 28 lines

Quoting Maxime Ripard (2020-06-26 04:54:33)

Quoted 21 lines

The RaspberryPi firmware binding uses two compatible, include simple-bus. The select statement generated by default will thus select any node that has simple-bus, not all of them being the raspberrypi firmware node.

This results in warnings being wrongfully reported. Let's add a custom select statement to fix that.

Fixes 5bc0b9be8544 ("dt-bindings: arm: bcm: Convert BCM2835 firmware binding to YAML")

---

The original binding has been merged through the clock tree, so it should be merged there.

Even though the original binding (and the DT) are using the simple-bus compatible, this creates some DTC warnings since the firmware really isn't a bus, so the node name doesn't match what a bus should have, none of the children have a reg property, #address-cells and #size-cells are missing, etc.

Quoted 5 lines

I can only guess that simple-bus was used to make the sub-devices probe, but maybe simple-mfd would be more appropriate here?

---
 .../bindings/arm/bcm/raspberrypi,bcm2835-firmware.yaml   | 9 +++++++++
 1 file changed, 9 insertions(+)
Quoted 8 lines

Hmm. I'm still seeing warnings.

Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.example.dts:23.37-26.15: Warning (simple_bus_reg): /example-0/firmware/clocks: missing or emp ty reg/ranges property
Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.example.dt.yaml: firmware: $nodename:0: 'firmware' does not match '^(bus|soc|axi|ahb|apb)(@[0-9a-f]+)?$' Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.example.dt.yaml: firmware: '#address-cells' is a required property Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.example.dt.yaml: firmware: '#size-cells' is a required property Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.example.dt.yaml: firmware: 'ranges' is a required property

Quoted 4 lines

Yeah, those are the warnings related to the issue we were discussing with Rob. The patch should fix an hard error.

I'll send a followup patch for the warnings.

Ah ok. Let me merge it up now.